September 2018 - flashrom-gerrit

Change in flashrom[master]: flashchips: Mark Winbond W25Q256.V as tested
by Angel Pons (Code Review) 30 Sep '18

30 Sep '18

Angel Pons has uploaded this change for review. ( https://review.coreboot.org/28816 Change subject: flashchips: Mark Winbond W25Q256.V as tested ...................................................................... flashchips: Mark Winbond W25Q256.V as tested As per Richard Hughes via the mailing list. Change-Id: Ic562a65d1a7d394f9d2c3980833d10a87bd9358a Signed-off-by: Angel Pons <th3fanbus(a)gmail.com> --- M flashchips.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/16/28816/1 diff --git a/flashchips.c b/flashchips.c index 7610b24..4b934bc 100644 --- a/flashchips.c +++ b/flashchips.c @@ -15366,7 +15366,7 @@ /* FOUR_BYTE_ADDR: supports 4-bytes addressing mode */ .feature_bits = FEATURE_WRSR_WREN | FEATURE_OTP | FEATURE_4BA_ENTER_WREN | FEATURE_4BA_EXT_ADDR | FEATURE_4BA_READ | FEATURE_4BA_FAST_READ, - .tested = TEST_UNTESTED, + .tested = TEST_OK_PREW, .probe = probe_spi_rdid, .probe_timing = TIMING_ZERO, .block_erasers = -- To view, visit https://review.coreboot.org/28816 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ic562a65d1a7d394f9d2c3980833d10a87bd9358a Gerrit-Change-Number: 28816 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com>

1 0

Change in flashrom[master]: flashchips: Mark Macronix MX66L51235 as tested
by Angel Pons (Code Review) 30 Sep '18

30 Sep '18

Angel Pons has uploaded this change for review. ( https://review.coreboot.org/28815 Change subject: flashchips: Mark Macronix MX66L51235 as tested ...................................................................... flashchips: Mark Macronix MX66L51235 as tested As per Nick (cel366) on 2018-05-16 via mailing list. Change-Id: I44363e6755167adbc120444a481b09bb4e1063c5 Signed-off-by: Angel Pons <th3fanbus(a)gmail.com> --- M flashchips.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/15/28815/1 diff --git a/flashchips.c b/flashchips.c index 0d72f1d..7610b24 100644 --- a/flashchips.c +++ b/flashchips.c @@ -8398,7 +8398,7 @@ .page_size = 256, /* OTP: 512B total; enter 0xB1, exit 0xC1 */ .feature_bits = FEATURE_WRSR_WREN | FEATURE_OTP | FEATURE_4BA, - .tested = TEST_UNTESTED, + .tested = TEST_OK_PREW, .probe = probe_spi_rdid, .probe_timing = TIMING_ZERO, .block_erasers = -- To view, visit https://review.coreboot.org/28815 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I44363e6755167adbc120444a481b09bb4e1063c5 Gerrit-Change-Number: 28815 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com>

1 0

Change in flashrom[master]: flashchips: Mark Atmel AT25DF161 as tested
by Angel Pons (Code Review) 30 Sep '18

30 Sep '18

Angel Pons has uploaded this change for review. ( https://review.coreboot.org/28814 Change subject: flashchips: Mark Atmel AT25DF161 as tested ...................................................................... flashchips: Mark Atmel AT25DF161 as tested As per Konstantin on 2018-06-08 via mailing list. Change-Id: I75fb4b17cf330451489811ae9303cbb33ebcb183 Signed-off-by: Angel Pons <th3fanbus(a)gmail.com> --- M flashchips.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/14/28814/1 diff --git a/flashchips.c b/flashchips.c index bdf50fa..0d72f1d 100644 --- a/flashchips.c +++ b/flashchips.c @@ -1679,7 +1679,7 @@ .total_size = 2048, .page_size = 256, .feature_bits = FEATURE_WRSR_WREN, - .tested = TEST_OK_PROBE, + .tested = TEST_OK_PREW, .probe = probe_spi_rdid, .probe_timing = TIMING_ZERO, .block_erasers = -- To view, visit https://review.coreboot.org/28814 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I75fb4b17cf330451489811ae9303cbb33ebcb183 Gerrit-Change-Number: 28814 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com>

1 0

Change in flashrom[master]: flashchips: Add LE25FU206/A and LE25FU106B
by Angel Pons (Code Review) 30 Sep '18

30 Sep '18

Angel Pons has uploaded this change for review. ( https://review.coreboot.org/28813 Change subject: flashchips: Add LE25FU206/A and LE25FU106B ...................................................................... flashchips: Add LE25FU206/A and LE25FU106B As per user `The_Raven Raven` on the mailing list. Change-Id: I6c26aafdca232110986334e85297d73d513600dc Signed-off-by: Angel Pons <th3fanbus(a)gmail.com> --- M flashchips.c M flashchips.h 2 files changed, 96 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/13/28813/1 diff --git a/flashchips.c b/flashchips.c index f7a94e1..bdf50fa 100644 --- a/flashchips.c +++ b/flashchips.c @@ -11617,6 +11617,99 @@ { .vendor = "Sanyo", + .name = "LE25FU106B", + .bustype = BUS_SPI, + .manufacture_id = SANYO_ID, + .model_id = SANYO_LE25FU106B, + .total_size = 128, + .page_size = 256, + .feature_bits = FEATURE_WRSR_WREN, + .tested = TEST_OK_PREW, + .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, + .block_erasers = { + { + .eraseblocks = { {2 * 1024, 64} }, + .block_erase = spi_block_erase_d7, + }, { + .eraseblocks = { {32 * 1024, 4} }, + .block_erase = spi_block_erase_d8, + }, { + .eraseblocks = { {128 * 1024, 1} }, + .block_erase = spi_block_erase_c7, + } + }, + .printlock = spi_prettyprint_status_register_bp1_srwd, + .unlock = spi_disable_blockprotect_bp1_srwd, + .write = spi_chip_write_256, + .read = spi_chip_read, + .voltage = {2300, 3600}, + }, + +{ + .vendor = "Sanyo", + .name = "LE25FU206", + .bustype = BUS_SPI, + .manufacture_id = SANYO_ID, + .model_id = SANYO_LE25FU206, + .total_size = 256, + .page_size = 256, + .tested = TEST_OK_PREW, + .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, + .block_erasers = + { + { + .eraseblocks = { {4 * 1024, 64} }, + .block_erase = spi_block_erase_d7, + }, { + .eraseblocks = { {64 * 1024, 4} }, + .block_erase = spi_block_erase_d8, + }, { + .eraseblocks = { {256 * 1024, 1} }, + .block_erase = spi_block_erase_c7, + } + }, + .printlock = spi_prettyprint_status_register_bp2_srwd, + .unlock = spi_disable_blockprotect, /* #WP pin write-protects SRWP bit. */ + .write = spi_chip_write_256, + .read = spi_chip_read, + .voltage = {2300, 3600}, + }, + + { + .vendor = "Sanyo", + .name = "LE25FU206A", + .bustype = BUS_SPI, + .manufacture_id = SANYO_ID, + .model_id = SANYO_LE25FU206A, + .total_size = 256, + .page_size = 256, + .tested = TEST_OK_PREW, + .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, + .block_erasers = + { + { + .eraseblocks = { {4 * 1024, 64} }, + .block_erase = spi_block_erase_d7, + }, { + .eraseblocks = { {64 * 1024, 4} }, + .block_erase = spi_block_erase_d8, + }, { + .eraseblocks = { {256 * 1024, 1} }, + .block_erase = spi_block_erase_c7, + } + }, + .printlock = spi_prettyprint_status_register_bp2_srwd, + .unlock = spi_disable_blockprotect, /* #WP pin write-protects SRWP bit. */ + .write = spi_chip_write_256, + .read = spi_chip_read, + .voltage = {2300, 3600}, + }, + + { + .vendor = "Sanyo", .name = "LE25FU406B", .bustype = BUS_SPI, .manufacture_id = SANYO_ID, diff --git a/flashchips.h b/flashchips.h index d17d26d..f640495 100644 --- a/flashchips.h +++ b/flashchips.h @@ -606,6 +606,9 @@ #define SANYO_LE25FW406 0x07 /* RES2 */ #define SANYO_LE25FW418A 0x10 /* RES2 and some weird 1 byte RDID variant */ #define SANYO_LE25FW406A 0x1A /* RES2, no datasheet */ +#define SANYO_LE25FU106B 0x1D62 +#define SANYO_LE25FU206 0x4462 +#define SANYO_LE25FU206A 0x612 #define SANYO_LE25FU406B 0x1E /* LE25FW418A without HD_READ mode option variant */ #define SANYO_LE25FU406C 0x0613 /* Also known as LE25U40CMC apparently */ #define SANYO_LE25FW806 0x26 /* RES2 and some weird 1 byte RDID variant */ -- To view, visit https://review.coreboot.org/28813 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I6c26aafdca232110986334e85297d73d513600dc Gerrit-Change-Number: 28813 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com>

1 0

Change in flashrom[master]: flashchips: Mark Macronix MX25U12835F as tested
by Angel Pons (Code Review) 30 Sep '18

30 Sep '18

Angel Pons has uploaded this change for review. ( https://review.coreboot.org/28812 Change subject: flashchips: Mark Macronix MX25U12835F as tested ...................................................................... flashchips: Mark Macronix MX25U12835F as tested As reported by David Martinka on the mailing list. Erase has not been tested, but since writes are reported as working, it is very likely erase works as well. Change-Id: I172453fe902ccface2a3a85817d775d45dd7cf80 Signed-off-by: Angel Pons <th3fanbus(a)gmail.com> --- M flashchips.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/12/28812/1 diff --git a/flashchips.c b/flashchips.c index 07c8949..f7a94e1 100644 --- a/flashchips.c +++ b/flashchips.c @@ -8572,7 +8572,7 @@ .page_size = 256, /* OTP: 512B total; enter 0xB1, exit 0xC1 */ .feature_bits = FEATURE_WRSR_WREN | FEATURE_OTP | FEATURE_QPI, - .tested = TEST_UNTESTED, + .tested = TEST_OK_PREW, .probe = probe_spi_rdid, .probe_timing = TIMING_ZERO, .block_erasers = -- To view, visit https://review.coreboot.org/28812 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I172453fe902ccface2a3a85817d775d45dd7cf80 Gerrit-Change-Number: 28812 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com>

1 0

Change in flashrom[master]: flashchips: Mark Eon EN25S40 as tested
by Angel Pons (Code Review) 30 Sep '18

30 Sep '18

Angel Pons has uploaded this change for review. ( https://review.coreboot.org/28811 Change subject: flashchips: Mark Eon EN25S40 as tested ...................................................................... flashchips: Mark Eon EN25S40 as tested As reported by `The_Raven Raven` on the mailing list. Change-Id: I00f9c6fcf13c486765d0ac4fe06a8b0989b03f91 Signed-off-by: Angel Pons <th3fanbus(a)gmail.com> --- M flashchips.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/11/28811/1 diff --git a/flashchips.c b/flashchips.c index 0f517a8..07c8949 100644 --- a/flashchips.c +++ b/flashchips.c @@ -5091,7 +5091,7 @@ .page_size = 256, /* OTP: 256B total; enter 0x3A */ .feature_bits = FEATURE_WRSR_WREN | FEATURE_OTP, - .tested = TEST_UNTESTED, + .tested = TEST_OK_PREW, .probe = probe_spi_rdid, .probe_timing = TIMING_ZERO, .block_erasers = { -- To view, visit https://review.coreboot.org/28811 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I00f9c6fcf13c486765d0ac4fe06a8b0989b03f91 Gerrit-Change-Number: 28811 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com>

1 0

Change in flashrom[master]: flaschips: Mark GigaDevice GD25Q128 as tested
by Angel Pons (Code Review) 30 Sep '18

30 Sep '18

Angel Pons has uploaded this change for review. ( https://review.coreboot.org/28810 Change subject: flaschips: Mark GigaDevice GD25Q128 as tested ...................................................................... flaschips: Mark GigaDevice GD25Q128 as tested Alexander reported this chip as tested using a GD25B128CPIG (same device ID, apparently) on 2018-08-30 via the mailing list. Change-Id: I134d3816c0f02e20764ab132a01bcba9f4e93f0d Signed-off-by: Angel Pons <th3fanbus(a)gmail.com> --- M flashchips.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/10/28810/1 diff --git a/flashchips.c b/flashchips.c index d6061ca..0f517a8 100644 --- a/flashchips.c +++ b/flashchips.c @@ -6358,7 +6358,7 @@ .page_size = 256, /* OTP: 1024B total, 256B reserved; read 0x48; write 0x42, erase 0x44 */ .feature_bits = FEATURE_WRSR_WREN | FEATURE_OTP, - .tested = TEST_UNTESTED, + .tested = TEST_OK_PREW, .probe = probe_spi_rdid, .probe_timing = TIMING_ZERO, .block_erasers = -- To view, visit https://review.coreboot.org/28810 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I134d3816c0f02e20764ab132a01bcba9f4e93f0d Gerrit-Change-Number: 28810 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com>

1 0

Change in flashrom[master]: flashchips: Add ISSI IS25LP064
by Angel Pons (Code Review) 30 Sep '18

30 Sep '18

Angel Pons has uploaded this change for review. ( https://review.coreboot.org/28809 Change subject: flashchips: Add ISSI IS25LP064 ...................................................................... flashchips: Add ISSI IS25LP064 Grabbed from mailing list, created by Simon Buhrow. Since no logs were attached, the chip is marked as untested. Change-Id: Idc26162fc5a5a429acef546b30b12d8b1f195e0a Signed-off-by: Angel Pons <th3fanbus(a)gmail.com> --- M flashchips.c M flashchips.h 2 files changed, 42 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/09/28809/1 diff --git a/flashchips.c b/flashchips.c index 9085c7d..d6061ca 100644 --- a/flashchips.c +++ b/flashchips.c @@ -7255,6 +7255,47 @@ { .vendor = "ISSI", + .name = "IS25LP064", + .bustype = BUS_SPI, + .manufacture_id = ISSI_ID_SPI, + .model_id = ISSI_IS25LP064, + .total_size = 8192, + .page_size = 256, + /* OTP: 1024B total; read 0x48; write 0x42 */ + .feature_bits = FEATURE_WRSR_WREN | FEATURE_OTP, + .tested = TEST_UNTESTED, + .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, + .block_erasers = + { + { + .eraseblocks = { {4 * 1024, 2048} }, + .block_erase = spi_block_erase_20, + }, { + .eraseblocks = { {4 * 1024, 2048} }, + .block_erase = spi_block_erase_d7, + }, { + .eraseblocks = { {32 * 1024, 256} }, + .block_erase = spi_block_erase_52, + }, { + .eraseblocks = { {64 * 1024, 128} }, + .block_erase = spi_block_erase_d8, + }, { + .eraseblocks = { {8 * 1024 * 1024, 1} }, + .block_erase = spi_block_erase_60, + }, { + .eraseblocks = { {8 * 1024 * 1024, 1} }, + .block_erase = spi_block_erase_c7, + } + }, + .unlock = spi_disable_blockprotect, + .write = spi_chip_write_256, + .read = spi_chip_read, + .voltage = {2300, 3600}, + }, + + { + .vendor = "ISSI", .name = "IS25LP128", .bustype = BUS_SPI, .manufacture_id = ISSI_ID_SPI, diff --git a/flashchips.h b/flashchips.h index ecd8d7a..d17d26d 100644 --- a/flashchips.h +++ b/flashchips.h @@ -453,6 +453,7 @@ #define ISSI_ID 0xD5 /* ISSI Integrated Silicon Solutions, see also PMC. */ #define ISSI_ID_SPI 0x9D /* ISSI ID used for SPI flash, see also PMC_ID_NOPREFIX */ +#define ISSI_IS25LP064 0x6017 #define ISSI_IS25LP128 0x6018 #define ISSI_IS25WP128 0x7018 #define ISSI_PMC_IS29GL032B 0xF9 -- To view, visit https://review.coreboot.org/28809 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Idc26162fc5a5a429acef546b30b12d8b1f195e0a Gerrit-Change-Number: 28809 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com>

1 0

Change in flashrom[master]: flashchips: Mark Micron MT25QL512 as tested
by Angel Pons (Code Review) 30 Sep '18

30 Sep '18

Angel Pons has uploaded this change for review. ( https://review.coreboot.org/28808 Change subject: flashchips: Mark Micron MT25QL512 as tested ...................................................................... flashchips: Mark Micron MT25QL512 as tested As reported by `Yuta Teshima` on the mailing list. Change-Id: I7325d42b43b71ab5fc2c7618e0577e4a7b31f01a Signed-off-by: Angel Pons <th3fanbus(a)gmail.com> --- M flashchips.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/08/28808/1 diff --git a/flashchips.c b/flashchips.c index 2001d8c..9085c7d 100644 --- a/flashchips.c +++ b/flashchips.c @@ -10233,7 +10233,7 @@ /* supports SFDP */ /* OTP: 64B total; read 0x4B, write 0x42 */ .feature_bits = FEATURE_WRSR_WREN | FEATURE_OTP | FEATURE_4BA_WREN, - .tested = TEST_UNTESTED, + .tested = TEST_OK_PREW, .probe = probe_spi_rdid, .probe_timing = TIMING_ZERO, .block_erasers = { -- To view, visit https://review.coreboot.org/28808 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I7325d42b43b71ab5fc2c7618e0577e4a7b31f01a Gerrit-Change-Number: 28808 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com>

1 0

Change in flashrom[master]: [WIP]layout.c: Use a linked lists for layout
by Angel Pons (Code Review) 30 Sep '18

30 Sep '18

Angel Pons has posted comments on this change. ( https://review.coreboot.org/27106 ) Change subject: [WIP]layout.c: Use a linked lists for layout ...................................................................... Patch Set 3: I tested this patch on an Asus P8H61-M PRO using the internal programmer. I found issues when writing to the flash chip. When writing, various operations (both with and without --ifd) would report "Chip content is identical to the requested image.", even though the image was different. -- To view, visit https://review.coreboot.org/27106 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id7f48ac613da1590f30247bee979034cf1f74e9e Gerrit-Change-Number: 27106 Gerrit-PatchSet: 3 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Sun, 30 Sep 2018 11:56:30 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit September 2018