flashrom-gerrit September 2018

flashrom-gerrit@flashrom.org

1 participants
45 discussions

Change in flashrom[master]: Add initial support for Dediprog SF200.
by Nico Huber (Code Review) 11 Sep '18

11 Sep '18

Nico Huber has posted comments on this change. ( https://review.coreboot.org/28272 ) Change subject: Add initial support for Dediprog SF200. ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/28272 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I025d1533e249f6a75b6d9015a18a6abf350456b6 Gerrit-Change-Number: 28272 Gerrit-PatchSet: 2 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Tue, 11 Sep 2018 12:30:17 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in flashrom[master]: Add initial J-Link SPI programmer
by Martin Roth (Code Review) 06 Sep '18

06 Sep '18

Martin Roth has posted comments on this change. ( https://review.coreboot.org/28087 ) Change subject: Add initial J-Link SPI programmer ...................................................................... Patch Set 7: I'll try to work on getting the builders updated tonight. -- To view, visit https://review.coreboot.org/28087 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie03a054a75457ec9e1cab36ea124bb53b10e8d7e Gerrit-Change-Number: 28087 Gerrit-PatchSet: 7 Gerrit-Owner: Marc Schink <flashrom-dev(a)marcschink.de> Gerrit-Reviewer: Marc Schink <flashrom-dev(a)marcschink.de> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 06 Sep 2018 18:29:07 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in flashrom[master]: Add initial support for Dediprog SF200.
by David Hendricks (Code Review) 02 Sep '18

02 Sep '18

David Hendricks has posted comments on this change. ( https://review.coreboot.org/28272 ) Change subject: Add initial support for Dediprog SF200. ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/28272 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I025d1533e249f6a75b6d9015a18a6abf350456b6 Gerrit-Change-Number: 28272 Gerrit-PatchSet: 2 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Sun, 02 Sep 2018 01:52:43 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in flashrom[master]: Add initial support for Dediprog SF200.
by David Hendricks (Code Review) 02 Sep '18

02 Sep '18

David Hendricks has posted comments on this change. ( https://review.coreboot.org/28272 ) Change subject: Add initial support for Dediprog SF200. ...................................................................... Patch Set 2: (1 comment) There were some whitespace issues that I went ahead and fixed, too. https://review.coreboot.org/#/c/28272/1/dediprog.c File dediprog.c: https://review.coreboot.org/#/c/28272/1/dediprog.c@1146 PS1, Line 1146: case DEV_SF200: > Should this comment be updated? Yes. I also updated this to use a switch statement since we're dealing with three programmers, two of which are nearly identical. -- To view, visit https://review.coreboot.org/28272 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I025d1533e249f6a75b6d9015a18a6abf350456b6 Gerrit-Change-Number: 28272 Gerrit-PatchSet: 2 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Sun, 02 Sep 2018 01:50:26 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in flashrom[master]: Add initial support for Dediprog SF200.
by David Hendricks (Code Review) 02 Sep '18

02 Sep '18

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/28272 to look at the new patch set (#2). Change subject: Add initial support for Dediprog SF200. ...................................................................... Add initial support for Dediprog SF200. Change-Id: I025d1533e249f6a75b6d9015a18a6abf350456b6 Signed-off-by: Jay Thompson <thompson.jay.thomas(a)gmail.com> Signed-off-by: David Hendricks <dhendricks(a)fb.com> --- M dediprog.c 1 file changed, 14 insertions(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/72/28272/2 -- To view, visit https://review.coreboot.org/28272 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I025d1533e249f6a75b6d9015a18a6abf350456b6 Gerrit-Change-Number: 28272 Gerrit-PatchSet: 2 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com>

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit September 2018