Paul Menzel has posted comments on this change. ( https://review.coreboot.org/23701 )
Change subject: flashchips: Add Zettadevice ZD25D40
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
https://review.coreboot.org/#/c/23701/2//COMMIT_MSG
Commit Message:
https://review.coreboot.org/#/c/23701/2//COMMIT_MSG@14
PS2, Line 14:
Remove the blank line, and move the Change-Id even above the Signed-off-by line.
--
To view, visit https://review.coreboot.org/23701
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0400b059ddacdf166d1b77f619becec3a250cece
Gerrit-Change-Number: 23701
Gerrit-PatchSet: 2
Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Mon, 12 Feb 2018 13:16:53 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
David Hendricks has posted comments on this change. ( https://review.coreboot.org/23701 )
Change subject: flashchips: Add Zettadevice ZD25D40
......................................................................
Patch Set 2:
The original author's PR was titled "Added W25P16 (tested) and ZD25D40 (untested)"
However W25P16 support wasn't really added - There seemed to be some confusion about what the author was intending to add support for.
The ZD25D40 part looked good so I split that out. I also added ZD25D20 support in the follow-up in my own patch.
--
To view, visit https://review.coreboot.org/23701
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0400b059ddacdf166d1b77f619becec3a250cece
Gerrit-Change-Number: 23701
Gerrit-PatchSet: 2
Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Mon, 12 Feb 2018 02:49:27 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
Hello Stefan Tauner, build bot (Jenkins), Nico Huber,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/23702
to look at the new patch set (#3).
Change subject: flashchips: Add ZD25D20
......................................................................
flashchips: Add ZD25D20
This adds another Zetta Device chip, the ZD25D20.
Change-Id: Idf805252647be44e28296a161d2e6160710bcc71
Signed-off-by: David Hendricks <david.hendricks(a)gmail.com>
---
M flashchips.c
M flashchips.h
2 files changed, 39 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/02/23702/3
--
To view, visit https://review.coreboot.org/23702
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Idf805252647be44e28296a161d2e6160710bcc71
Gerrit-Change-Number: 23702
Gerrit-PatchSet: 3
Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Stefan Tauner <stefan.tauner(a)gmx.at>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Hello build bot (Jenkins), Nico Huber,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/23701
to look at the new patch set (#2).
Change subject: flashchips: Add Zettadevice ZD25D40
......................................................................
flashchips: Add Zettadevice ZD25D40
This introduces the Zettadevice manufacturer ID and adds support for the
ZD25D40 chip.
Based on PR20 from Github.
Signed-off-by: David Hendricks <david.hendricks(a)gmail.com>
Change-Id: I0400b059ddacdf166d1b77f619becec3a250cece
---
M flashchips.c
M flashchips.h
2 files changed, 42 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/01/23701/2
--
To view, visit https://review.coreboot.org/23701
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I0400b059ddacdf166d1b77f619becec3a250cece
Gerrit-Change-Number: 23701
Gerrit-PatchSet: 2
Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Hello Stefan Tauner, build bot (Jenkins), Nico Huber,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/23700
to look at the new patch set (#2).
Change subject: flashchips: Add Winbond W25P80/16/32 support
......................................................................
flashchips: Add Winbond W25P80/16/32 support
This adds support for W25P80/16/32 chips. Most notably these chips only
have two erase commands - one for 64KiB "sectors" and one for chip
erase.
Change-Id: Ie09ba8e28fee35c42e17ca05219dc673413de93b
Signed-off-by: David Hendricks <david.hendricks(a)gmail.com>
---
M flashchips.c
M flashchips.h
2 files changed, 89 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/00/23700/2
--
To view, visit https://review.coreboot.org/23700
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie09ba8e28fee35c42e17ca05219dc673413de93b
Gerrit-Change-Number: 23700
Gerrit-PatchSet: 2
Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Stefan Tauner <stefan.tauner(a)gmx.at>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/23702
to look at the new patch set (#2).
Change subject: flashchips: Add ZD25D20
......................................................................
flashchips: Add ZD25D20
This adds another Zetta Device chip, the ZD25D20.
Change-Id: Idf805252647be44e28296a161d2e6160710bcc71
Signed-off-by: David Hendricks <david.hendricks(a)gmail.com>
---
M flashchips.c
M flashchips.h
2 files changed, 39 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/02/23702/2
--
To view, visit https://review.coreboot.org/23702
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Idf805252647be44e28296a161d2e6160710bcc71
Gerrit-Change-Number: 23702
Gerrit-PatchSet: 2
Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>