Change in flashrom[master]: Fixed mingw detection on Windows 7 (NT-6.1) and hopefully in another ...

[Márton Miklós (Code Review)]

Márton Miklós has posted comments on this change. ( https://review.coreboot.org/23865 )

Change subject: Fixed mingw detection on Windows 7 (NT-6.1) and hopefully in another non
XP Windows build environments too.
......................................................................


Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/23865/1//COMMIT_MSG
Commit Message:

https://review.coreboot.org/#/c/23865/1//COMMIT_MSG@7
PS1, Line 7: 
Sure:
This patch utilizes a regular expression to check if we are compiling under mingw
environment rather than comparing the uname output to a predefined string
(MINGW32_NT-5.1). In newer Windows based mingw enviroments the uname returns different
version number so the platform will not be detected properly and the compilation will
fail. 

I have tested it only on Windows 7 (where the uname returns INGW32_NT-6.1), however the
regex should match the MINGW64 environments too see:
https://regexr.com/3lgp9



-- 
To view, visit https://review.coreboot.org/23865
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7f856dc4847c4ca9197b1935b7a9b9071b46c70a
Gerrit-Change-Number: 23865
Gerrit-PatchSet: 1
Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-Reviewer: Miklós Márton <martonmiklosqdev(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Márton Miklós <martonmiklosqdev(a)gmail.com>
Gerrit-Comment-Date: Wed, 28 Feb 2018 20:26:54 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No