- flashrom-gerrit - mail.coreboot.org

[S] Change in flashrom[main]: doc: Add manpage entries for nic3com, gfxnvidia, satasii
by Anastasia Klimchuk (Code Review) 26 Jul '24

26 Jul '24

Anastasia Klimchuk has submitted this change. ( https://review.coreboot.org/c/flashrom/+/83467?usp=email ) Change subject: doc: Add manpage entries for nic3com, gfxnvidia, satasii ...................................................................... doc: Add manpage entries for nic3com, gfxnvidia, satasii These programmers have a little information about them on wiki. It's too little info to create a dedicated page for each programmer, however info can go to the manpage. For reference, wiki pages are the following: https://wiki.flashrom.org/NIC3Com https://wiki.flashrom.org/Gfxnvidia https://wiki.flashrom.org/Supported_programmers (search for the programmers in the table). Change-Id: Id2a2aefc6a3c8348fdaa4498aaa704fd2da7602f Signed-off-by: Anastasia Klimchuk <aklm(a)flashrom.org> Reviewed-on: https://review.coreboot.org/c/flashrom/+/83467 Reviewed-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M doc/classic_cli_manpage.rst 1 file changed, 20 insertions(+), 0 deletions(-) Approvals: Stefan Reinauer: Looks good to me, approved build bot (Jenkins): Verified diff --git a/doc/classic_cli_manpage.rst b/doc/classic_cli_manpage.rst index 19c804a..d8380c7 100644 --- a/doc/classic_cli_manpage.rst +++ b/doc/classic_cli_manpage.rst @@ -636,6 +636,7 @@ flashrom -p nic3com:pci=05:04.0 +Some of these programmers have more info below. atavia programmer ^^^^^^^^^^^^^^^^^ @@ -655,6 +656,13 @@ fact that, on the tested device (a Promise Ultra100), not all of the chip's address lines were actually connected. You may use this programmer to flash firmware updates, since these are only 16 kB in size (padding to 32 kB is required). +nic3com programmer +^^^^^^^^^^^^^^^^^^ + +flashrom supports some 3Com network cards to reflash the (parallel) flash attached to these cards, +but it is also possible to use these cards to reflash other chips which fit in there electrically. +Please note that the small number of address lines connected to the chip may make accessing large chips impossible. +The maximum supported chip size is 128KB. nicintel_eeprom programmer ^^^^^^^^^^^^^^^^^^^^^^^^^^ @@ -666,6 +674,18 @@ Intel specifies following EEPROMs to be compatible: Atmel AT25128, AT25256, Micron (ST) M95128, M95256 and OnSemi (Catalyst) CAT25CS128. +gfxnvidia programmer +^^^^^^^^^^^^^^^^^^^^ + +Flashrom supports some Nvidia graphic cards to reflash the (parallel) flash attached to these cards, +but it is also possible to use these cards to reflash other chips which fit in there electrically. + +satasii programmer +^^^^^^^^^^^^^^^^^^ + +Flashrom supports some SiI ATA/SATA controllers to reflash the flash attached to these controller cards, +but it is also possible to use these cards to reflash other chips which fit in there electrically. +Please note that the small number of address lines connected to the chip may make accessing large chips impossible. ft2232_spi programmer ^^^^^^^^^^^^^^^^^^^^^ -- To view, visit https://review.coreboot.org/c/flashrom/+/83467?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Id2a2aefc6a3c8348fdaa4498aaa704fd2da7602f Gerrit-Change-Number: 83467 Gerrit-PatchSet: 2 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[S] Change in flashrom[main]: doc: Add manpage entries for nic3com, gfxnvidia, satasii
by Anastasia Klimchuk (Code Review) 26 Jul '24

26 Jul '24

Anastasia Klimchuk has posted comments on this change by Anastasia Klimchuk. ( https://review.coreboot.org/c/flashrom/+/83467?usp=email ) Change subject: doc: Add manpage entries for nic3com, gfxnvidia, satasii ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > Wait until the tag v1.4.0 done and after that the patch can be submitted. ETA 26 July. […] Done -- To view, visit https://review.coreboot.org/c/flashrom/+/83467?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Id2a2aefc6a3c8348fdaa4498aaa704fd2da7602f Gerrit-Change-Number: 83467 Gerrit-PatchSet: 1 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 26 Jul 2024 08:30:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org>

1 0

[S] Change in flashrom[main]: flashchips: Add Support for XMC XM25QU512C/XM25QU512D
by Anastasia Klimchuk (Code Review) 26 Jul '24

26 Jul '24

Anastasia Klimchuk has submitted this change. ( https://review.coreboot.org/c/flashrom/+/83243?usp=email ) Change subject: flashchips: Add Support for XMC XM25QU512C/XM25QU512D ...................................................................... flashchips: Add Support for XMC XM25QU512C/XM25QU512D Add initial support for the SPI flash chip XM25QU512C/XM25QU512D Datasheet link: https://www.xmcwh.com/uploads/808/XM25QU512C_V1.6.pdf Tested with ch341a programmer: probe, read, write, erase Change-Id: I251c66b5d3b4fc94242c2c9d6b7c0f03c1bd7d0b Signed-off-by: Kan Sun <ssunkkan(a)gmail.com> Reviewed-on: https://review.coreboot.org/c/flashrom/+/83243 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Anastasia Klimchuk <aklm(a)chromium.org> --- M flashchips.c M include/flashchips.h 2 files changed, 49 insertions(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified Anastasia Klimchuk: Looks good to me, approved diff --git a/flashchips.c b/flashchips.c index ad7d72a..46b87e3 100644 --- a/flashchips.c +++ b/flashchips.c @@ -22595,6 +22595,54 @@ }, { + .vendor = "XMC", + .name = "XM25QU512C/XM25QU512D", + .bustype = BUS_SPI, + .manufacture_id = ST_ID, + .model_id = XMC_XM25QU512C, + .total_size = 64 * 1024, + .page_size = 256, + /* supports SFDP */ + /* OTP: 1024B total, 256B reserved; read 0x48; write 0x42, erase 0x44, read ID 0x4B */ + /* FOUR_BYTE_ADDR: supports 4-bytes addressing mode */ + .feature_bits = FEATURE_WRSR_WREN | FEATURE_OTP | FEATURE_4BA_ENTER_WREN + | FEATURE_4BA_EAR_C5C8 | FEATURE_4BA_READ | FEATURE_4BA_FAST_READ, + .tested = TEST_OK_PREW, + .probe = PROBE_SPI_RDID, + .probe_timing = TIMING_ZERO, + .block_erasers = + { + { + .eraseblocks = { {4 * 1024, 16384} }, + .block_erase = SPI_BLOCK_ERASE_21, + }, { + .eraseblocks = { {4 * 1024, 16384} }, + .block_erase = SPI_BLOCK_ERASE_20, + }, { + .eraseblocks = { {32 * 1024, 2048} }, + .block_erase = SPI_BLOCK_ERASE_52, + }, { + .eraseblocks = { {64 * 1024, 1024} }, + .block_erase = SPI_BLOCK_ERASE_DC, + }, { + .eraseblocks = { {64 * 1024, 1024} }, + .block_erase = SPI_BLOCK_ERASE_D8, + }, { + .eraseblocks = { {64 * 1024 * 1024, 1} }, + .block_erase = SPI_BLOCK_ERASE_60, + }, { + .eraseblocks = { {64 * 1024 * 1024, 1} }, + .block_erase = SPI_BLOCK_ERASE_C7, + } + }, + .printlock = SPI_PRETTYPRINT_STATUS_REGISTER_PLAIN, /* TODO: improve */ + .unlock = SPI_DISABLE_BLOCKPROTECT, + .write = SPI_CHIP_WRITE256, + .read = SPI_CHIP_READ, + .voltage = {1650, 1950}, + }, + + { .vendor = "XTX Technology Limited", .name = "XT25F02E", .bustype = BUS_SPI, diff --git a/include/flashchips.h b/include/flashchips.h index 8d6c8db..22509c4 100644 --- a/include/flashchips.h +++ b/include/flashchips.h @@ -859,6 +859,7 @@ #define XMC_XM25QU256C 0x4119 /* Same as XM25QU256D */ #define XMC_XM25RU256C 0x4419 #define XMC_XM25QH512C 0x4020 /* Same as XM25QH512D */ +#define XMC_XM25QU512C 0x4120 /* Same as XM25QU512D */ #define ST_M25PX80 0x7114 #define ST_M25PX16 0x7115 #define ST_M25PX32 0x7116 -- To view, visit https://review.coreboot.org/c/flashrom/+/83243?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I251c66b5d3b4fc94242c2c9d6b7c0f03c1bd7d0b Gerrit-Change-Number: 83243 Gerrit-PatchSet: 5 Gerrit-Owner: Ssunk <ssunkkan(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[S] Change in flashrom[main]: flashchips: Add Support for XMC XM25QU512C/XM25QU512D
by Anastasia Klimchuk (Code Review) 26 Jul '24

26 Jul '24

Attention is currently required from: Nikolai Artemiev, Ssunk, Stefan Reinauer. Anastasia Klimchuk has posted comments on this change by Ssunk. ( https://review.coreboot.org/c/flashrom/+/83243?usp=email ) Change subject: flashchips: Add Support for XMC XM25QU512C/XM25QU512D ...................................................................... Patch Set 4: (1 comment) Patchset: PS4: > Wait until the tag v1.4.0 done and after that the patch can be submitted. ETA 26 July. […] Done -- To view, visit https://review.coreboot.org/c/flashrom/+/83243?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I251c66b5d3b4fc94242c2c9d6b7c0f03c1bd7d0b Gerrit-Change-Number: 83243 Gerrit-PatchSet: 4 Gerrit-Owner: Ssunk <ssunkkan(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Ssunk <ssunkkan(a)gmail.com> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Comment-Date: Fri, 26 Jul 2024 08:29:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org>

1 0

[S] Change in flashrom[main]: flashchips: Add Support for XMC XM25QH512C/XM25QH512D
by Anastasia Klimchuk (Code Review) 26 Jul '24

26 Jul '24

Anastasia Klimchuk has submitted this change. ( https://review.coreboot.org/c/flashrom/+/83242?usp=email ) Change subject: flashchips: Add Support for XMC XM25QH512C/XM25QH512D ...................................................................... flashchips: Add Support for XMC XM25QH512C/XM25QH512D Add initial support for the SPI flash chip XM25QH512C/XM25QH512D Datasheet link: https://www.xmcwh.com/uploads/803/XM25QH512C_V1.6.pdf Tested with ch341a programmer: probe, read, write, erase Change-Id: Ica8ed5eaba2435a9416274b94f633ea40dfeea2f Signed-off-by: Kan Sun <ssunkkan(a)gmail.com> Reviewed-on: https://review.coreboot.org/c/flashrom/+/83242 Reviewed-by: Anastasia Klimchuk <aklm(a)chromium.org> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M flashchips.c M include/flashchips.h 2 files changed, 49 insertions(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified Anastasia Klimchuk: Looks good to me, approved diff --git a/flashchips.c b/flashchips.c index 669da50..ad7d72a 100644 --- a/flashchips.c +++ b/flashchips.c @@ -22547,6 +22547,54 @@ }, { + .vendor = "XMC", + .name = "XM25QH512C/XM25QH512D", + .bustype = BUS_SPI, + .manufacture_id = ST_ID, + .model_id = XMC_XM25QH512C, + .total_size = 64 * 1024, + .page_size = 256, + /* supports SFDP */ + /* OTP: 1024B total, 256B reserved; read 0x48; write 0x42, erase 0x44, read ID 0x4B */ + /* FOUR_BYTE_ADDR: supports 4-bytes addressing mode */ + .feature_bits = FEATURE_WRSR_WREN | FEATURE_OTP | FEATURE_4BA_ENTER_WREN + | FEATURE_4BA_EAR_C5C8 | FEATURE_4BA_READ | FEATURE_4BA_FAST_READ, + .tested = TEST_OK_PREW, + .probe = PROBE_SPI_RDID, + .probe_timing = TIMING_ZERO, + .block_erasers = + { + { + .eraseblocks = { {4 * 1024, 16384} }, + .block_erase = SPI_BLOCK_ERASE_21, + }, { + .eraseblocks = { {4 * 1024, 16384} }, + .block_erase = SPI_BLOCK_ERASE_20, + }, { + .eraseblocks = { {32 * 1024, 2048} }, + .block_erase = SPI_BLOCK_ERASE_52, + }, { + .eraseblocks = { {64 * 1024, 1024} }, + .block_erase = SPI_BLOCK_ERASE_DC, + }, { + .eraseblocks = { {64 * 1024, 1024} }, + .block_erase = SPI_BLOCK_ERASE_D8, + }, { + .eraseblocks = { {64 * 1024 * 1024, 1} }, + .block_erase = SPI_BLOCK_ERASE_60, + }, { + .eraseblocks = { {64 * 1024 * 1024, 1} }, + .block_erase = SPI_BLOCK_ERASE_C7, + } + }, + .printlock = SPI_PRETTYPRINT_STATUS_REGISTER_PLAIN, /* TODO: improve */ + .unlock = SPI_DISABLE_BLOCKPROTECT, + .write = SPI_CHIP_WRITE256, + .read = SPI_CHIP_READ, + .voltage = {2700, 3600}, + }, + + { .vendor = "XTX Technology Limited", .name = "XT25F02E", .bustype = BUS_SPI, diff --git a/include/flashchips.h b/include/flashchips.h index fc89ec1..8d6c8db 100644 --- a/include/flashchips.h +++ b/include/flashchips.h @@ -858,6 +858,7 @@ #define XMC_XM25QH256C 0x4019 /* Same as XM25QH256D */ #define XMC_XM25QU256C 0x4119 /* Same as XM25QU256D */ #define XMC_XM25RU256C 0x4419 +#define XMC_XM25QH512C 0x4020 /* Same as XM25QH512D */ #define ST_M25PX80 0x7114 #define ST_M25PX16 0x7115 #define ST_M25PX32 0x7116 -- To view, visit https://review.coreboot.org/c/flashrom/+/83242?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Ica8ed5eaba2435a9416274b94f633ea40dfeea2f Gerrit-Change-Number: 83242 Gerrit-PatchSet: 4 Gerrit-Owner: Ssunk <ssunkkan(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[S] Change in flashrom[main]: flashchips: Add Support for XMC XM25QH512C/XM25QH512D
by Anastasia Klimchuk (Code Review) 26 Jul '24

26 Jul '24

Attention is currently required from: Nikolai Artemiev, Ssunk, Stefan Reinauer. Anastasia Klimchuk has posted comments on this change by Ssunk. ( https://review.coreboot.org/c/flashrom/+/83242?usp=email ) Change subject: flashchips: Add Support for XMC XM25QH512C/XM25QH512D ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: > Wait until the tag v1.4.0 done and after that the patch can be submitted. ETA 26 July. […] Done -- To view, visit https://review.coreboot.org/c/flashrom/+/83242?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Ica8ed5eaba2435a9416274b94f633ea40dfeea2f Gerrit-Change-Number: 83242 Gerrit-PatchSet: 3 Gerrit-Owner: Ssunk <ssunkkan(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Ssunk <ssunkkan(a)gmail.com> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Comment-Date: Fri, 26 Jul 2024 08:28:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org>

1 0

[XS] Change in flashrom[main]: flashchips: Add Support for XMC XM25QU256D
by Anastasia Klimchuk (Code Review) 26 Jul '24

26 Jul '24

Anastasia Klimchuk has submitted this change. ( https://review.coreboot.org/c/flashrom/+/83241?usp=email ) Change subject: flashchips: Add Support for XMC XM25QU256D ...................................................................... flashchips: Add Support for XMC XM25QU256D Add initial support for the SPI flash chip XM25QU256D (same as XM25QU256C) Datasheet link: https://www.xmcwh.com/uploads/224/XM25QU256C%20_%20Ver%202.0.pdf Tested with ch341a programmer: probe, read, write, erase Change-Id: I504699160f804cfbacd189409596e105752d94eb Signed-off-by: Kan Sun <ssunkkan(a)gmail.com> Reviewed-on: https://review.coreboot.org/c/flashrom/+/83241 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Anastasia Klimchuk <aklm(a)chromium.org> --- M flashchips.c M include/flashchips.h 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Anastasia Klimchuk: Looks good to me, approved build bot (Jenkins): Verified diff --git a/flashchips.c b/flashchips.c index f968966..669da50 100644 --- a/flashchips.c +++ b/flashchips.c @@ -22464,7 +22464,7 @@ { .vendor = "XMC", - .name = "XM25QU256C", + .name = "XM25QU256C/XM25QU256D", .bustype = BUS_SPI, .manufacture_id = ST_ID, .model_id = XMC_XM25QU256C, diff --git a/include/flashchips.h b/include/flashchips.h index eb66e6c..fc89ec1 100644 --- a/include/flashchips.h +++ b/include/flashchips.h @@ -856,7 +856,7 @@ #define XMC_XM25QH128C 0x4018 /* Same as XM25QH128D */ #define XMC_XM25QU128C 0x4118 /* Same as XM25QU128D */ #define XMC_XM25QH256C 0x4019 /* Same as XM25QH256D */ -#define XMC_XM25QU256C 0x4119 +#define XMC_XM25QU256C 0x4119 /* Same as XM25QU256D */ #define XMC_XM25RU256C 0x4419 #define ST_M25PX80 0x7114 #define ST_M25PX16 0x7115 -- To view, visit https://review.coreboot.org/c/flashrom/+/83241?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I504699160f804cfbacd189409596e105752d94eb Gerrit-Change-Number: 83241 Gerrit-PatchSet: 3 Gerrit-Owner: Ssunk <ssunkkan(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[XS] Change in flashrom[main]: flashchips: Add Support for XMC XM25QU256D
by Anastasia Klimchuk (Code Review) 26 Jul '24

26 Jul '24

Attention is currently required from: Nikolai Artemiev, Ssunk, Stefan Reinauer. Anastasia Klimchuk has posted comments on this change by Ssunk. ( https://review.coreboot.org/c/flashrom/+/83241?usp=email ) Change subject: flashchips: Add Support for XMC XM25QU256D ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: > Wait until the tag v1.4.0 done and after that the patch can be submitted. ETA 26 July. […] Done -- To view, visit https://review.coreboot.org/c/flashrom/+/83241?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I504699160f804cfbacd189409596e105752d94eb Gerrit-Change-Number: 83241 Gerrit-PatchSet: 2 Gerrit-Owner: Ssunk <ssunkkan(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Ssunk <ssunkkan(a)gmail.com> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Comment-Date: Fri, 26 Jul 2024 08:24:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org>

1 0

[XS] Change in flashrom[main]: flashchips: Add Support for XMC XM25QH256D
by Anastasia Klimchuk (Code Review) 26 Jul '24

26 Jul '24

Anastasia Klimchuk has submitted this change. ( https://review.coreboot.org/c/flashrom/+/83240?usp=email ) Change subject: flashchips: Add Support for XMC XM25QH256D ...................................................................... flashchips: Add Support for XMC XM25QH256D Add initial support for the SPI flash chip XM25QH256D (same as XM25QH256C) Datasheet link: https://www.xmcwh.com/uploads/802/XM25QH256C%20_%20Ver%202.0.pdf Tested with ch341a programmer: probe, read, write, erase Change-Id: I77481e63eb98ed12935288dc0d6286cb1baf8edb Signed-off-by: Kan Sun <ssunkkan(a)gmail.com> Reviewed-on: https://review.coreboot.org/c/flashrom/+/83240 Reviewed-by: Anastasia Klimchuk <aklm(a)chromium.org> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M flashchips.c M include/flashchips.h 2 files changed, 3 insertions(+), 3 deletions(-) Approvals: build bot (Jenkins): Verified Anastasia Klimchuk: Looks good to me, approved diff --git a/flashchips.c b/flashchips.c index eaeb390..f968966 100644 --- a/flashchips.c +++ b/flashchips.c @@ -22414,7 +22414,7 @@ { .vendor = "XMC", - .name = "XM25QH256C", + .name = "XM25QH256C/XM25QH256D", .bustype = BUS_SPI, .manufacture_id = ST_ID, .model_id = XMC_XM25QH256C, @@ -22425,7 +22425,7 @@ .feature_bits = FEATURE_WRSR_WREN | FEATURE_OTP | FEATURE_4BA_ENTER_WREN | FEATURE_4BA_EAR_C5C8 | FEATURE_4BA_READ | FEATURE_4BA_FAST_READ | FEATURE_4BA_WRITE | FEATURE_WRSR2, - .tested = TEST_OK_PR, + .tested = TEST_OK_PREW, .probe = PROBE_SPI_RDID, .probe_timing = TIMING_ZERO, .block_erasers = diff --git a/include/flashchips.h b/include/flashchips.h index cc338c4..eb66e6c 100644 --- a/include/flashchips.h +++ b/include/flashchips.h @@ -855,7 +855,7 @@ #define XMC_XM25QH128A 0x7018 #define XMC_XM25QH128C 0x4018 /* Same as XM25QH128D */ #define XMC_XM25QU128C 0x4118 /* Same as XM25QU128D */ -#define XMC_XM25QH256C 0x4019 +#define XMC_XM25QH256C 0x4019 /* Same as XM25QH256D */ #define XMC_XM25QU256C 0x4119 #define XMC_XM25RU256C 0x4419 #define ST_M25PX80 0x7114 -- To view, visit https://review.coreboot.org/c/flashrom/+/83240?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I77481e63eb98ed12935288dc0d6286cb1baf8edb Gerrit-Change-Number: 83240 Gerrit-PatchSet: 3 Gerrit-Owner: Ssunk <ssunkkan(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[XS] Change in flashrom[main]: flashchips: Add Support for XMC XM25QH256D
by Anastasia Klimchuk (Code Review) 26 Jul '24

26 Jul '24

Attention is currently required from: Nikolai Artemiev, Ssunk, Stefan Reinauer. Anastasia Klimchuk has posted comments on this change by Ssunk. ( https://review.coreboot.org/c/flashrom/+/83240?usp=email ) Change subject: flashchips: Add Support for XMC XM25QH256D ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: > Wait until the tag v1.4.0 done and after that the patch can be submitted. ETA 26 July. […] Done -- To view, visit https://review.coreboot.org/c/flashrom/+/83240?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I77481e63eb98ed12935288dc0d6286cb1baf8edb Gerrit-Change-Number: 83240 Gerrit-PatchSet: 2 Gerrit-Owner: Ssunk <ssunkkan(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Ssunk <ssunkkan(a)gmail.com> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Comment-Date: Fri, 26 Jul 2024 08:23:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org>

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit