- flashrom-gerrit - mail.coreboot.org

[M] Change in flashrom[main]: flashchips: Add XMC25QH64A
by Anastasia Klimchuk (Code Review) 25 Mar '25

25 Mar '25

Attention is currently required from: Eric Park, Nikolai Artemiev, Stefan Reinauer. Anastasia Klimchuk has posted comments on this change by Eric Park. ( https://review.coreboot.org/c/flashrom/+/86990?usp=email ) Change subject: flashchips: Add XMC25QH64A ...................................................................... Patch Set 4: (5 comments) Patchset: PS4: Eric, thank you for the patch! I added a few comments. Also wanted to ask , have you tested yourself? I can see that PR was tested, although that was a few years ago. Commit Message: https://review.coreboot.org/c/flashrom/+/86990/comment/70dd1c56_53a08c69?us… : PS4, Line 7: XMC25QH64A Let's be exact so that it's searchable, call it `XMC XM25QH64A` https://review.coreboot.org/c/flashrom/+/86990/comment/fb56adb8_b1f3a6e2?us… : PS4, Line 18: Signed-off-by: Eric Park <me(a)ericswpark.com> Add yourself too as Co-authored-by (keep the sign off line too) File flashchips/xmc.c: https://review.coreboot.org/c/flashrom/+/86990/comment/065b46b7_a2863d6a?us… : PS4, Line 251: .name = "XM25QH64A", I would put this entry just before XM25QH128A in this file too (same as their ids are ordered), would you do this? thank you! File include/flashchips.h: https://review.coreboot.org/c/flashrom/+/86990/comment/42eb61fc_6c9cd9a4?us… : PS4, Line 1085: #define XMC_ID 0x20 /* same as ST_ID */ : #define XMC_XM25QH256B 0x6019 : #define XMC_XM25QH128B 0x6018 : #define XMC_XM25QH64A 0x7017 : #define XMC_XM25QH64B 0x6017 : #define XMC_XM25QH32B 0x4016 /* 0x6016 for QPI mode */ : #define XMC_XM25QH16B 0x4015 : #define XMC_XM25QH80B 0x4014 : #define XMC_XM25QH40B 0x4013 : #define XMC_XM25QU256B 0x7019 : #define XMC_XM25QU128B 0x5018 : #define XMC_XM25QU64A 0x3817 : #define XMC_XM25QU64B 0x5017 : #define XMC_XM25QU40B 0x5013 : #define XMC_XM25QU20B 0x5012 I know it was like this in the original pull request, but we don't need to do the aliasing. So you need to add only one line, for the device you are adding, this line: #define XMC_XM25QH64A 0x7017 insert it just before the existing macro for XMC_XM25QH128A with ID 0x7018 The rest of this block just remove. -- To view, visit https://review.coreboot.org/c/flashrom/+/86990?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I5b11e30f0a5357a6cbb32ddb93f450de5364c60b Gerrit-Change-Number: 86990 Gerrit-PatchSet: 4 Gerrit-Owner: Eric Park <me(a)ericswpark.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Attention: Eric Park <me(a)ericswpark.com> Gerrit-Comment-Date: Tue, 25 Mar 2025 08:54:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[M] Change in flashrom[main]: libflashrom: Update the API for Logger Callback
by Anastasia Klimchuk (Code Review) 25 Mar '25

25 Mar '25

Attention is currently required from: Dmitry Zhadinets. Anastasia Klimchuk has posted comments on this change by Dmitry Zhadinets. ( https://review.coreboot.org/c/flashrom/+/86875?usp=email ) Change subject: libflashrom: Update the API for Logger Callback ...................................................................... Patch Set 6: (4 comments) Patchset: PS6: I have two small readability comments, otherwise the only question to decide is message size right? File include/libflashrom.h: https://review.coreboot.org/c/flashrom/+/86875/comment/475b5a75_6e689bb1?us… : PS4, Line 83: * > Hmmmm. The user does not affect this, but as you wish. I was trying to find it, but I couldn't, but then I found the addition at `flashrom_set_progress_callback_v2` :) I was thinking to add it at `flashrom_set_log_callback_v2` (the new fn that you are adding) File libflashrom.c: https://review.coreboot.org/c/flashrom/+/86875/comment/ad8d6a36_76bdf906?us… : PS4, Line 59: /* Dynamic messages and double formatting may not be ideal, : as they are slow. It would be better to limit the message : size to a fixed value (e.g., char message[1024] = {0};). */ > I would go shorter to perhaps 128 or 256 bytes, but have a fallback to dynamic allocation in case a […] I found one very long message in cli_classic.c, in `cli_classic_usage` (it prints help, as of `flashrom -h`), but I don't think it trigger a callback, since it's using printf directly? This was the only very long message that I found. The rest probably fits into 256, but maybe let's do it 512 just in case? Also 100% agree let's not drop long messages silently. Actually if we don't drop than 256 is fine File libflashrom.c: https://review.coreboot.org/c/flashrom/+/86875/comment/f4f4b00f_02493a53?us… : PS6, Line 84: if (!log_callback && global_log_callback == format_message_and_invoke_log_callback_v2) : global_log_callback = NULL; I spent some time looking at this, then I figured this is doing a reset (when log_callback is passed NULL). It is possible to understand, but I have a suggestion to change this a bit, to make it more readable (more obvious). What if you check if log_callback is NULL, and then assign all 3 values to NULL? and with 1-line comment like "Reset all callbacks since NULL is passed" I know this code works already, my comment is only about readability. ``` if (!log_callback) { /* Reset all callbacks because NULL is passed */ global_log_callback = NULL; global_log_callback_v2 = NULL; global_log_user_data = NULL; } else { .... and the rest as normal flow } ``` -- To view, visit https://review.coreboot.org/c/flashrom/+/86875?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Iea738bd371fa3d69b9cf222c89ee67490d30af39 Gerrit-Change-Number: 86875 Gerrit-PatchSet: 6 Gerrit-Owner: Dmitry Zhadinets <dzhadinets(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Dmitry Zhadinets <dzhadinets(a)gmail.com> Gerrit-Comment-Date: Tue, 25 Mar 2025 07:10:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Dmitry Zhadinets <dzhadinets(a)gmail.com> Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Comment-In-Reply-To: Peter Marheine <pmarheine(a)chromium.org>

1 0

[S] Change in flashrom[main]: flashchips: Add Macronix MX77U25650FZ4I42
by Anastasia Klimchuk (Code Review) 25 Mar '25

25 Mar '25

Attention is currently required from: DZ, Dolan Liu, Nikolai Artemiev, Stefan Reinauer. Anastasia Klimchuk has posted comments on this change by Dolan Liu. ( https://review.coreboot.org/c/flashrom/+/86348?usp=email ) Change subject: flashchips: Add Macronix MX77U25650FZ4I42 ...................................................................... Patch Set 2: (2 comments) Patchset: PS2: > Hi Anastasia, I have compared this with RPMC datasheet, all the flashchip definition is correct. Thank you so much for your help PS2: Hello Dolan, just wanted to say - the last two comments are for you to do :) It's two small things. After you do those, you will upload new patchset and this will trigger Jenkins re-run, which will give you verified +1. -- To view, visit https://review.coreboot.org/c/flashrom/+/86348?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I7866b2db343f4eb2bc194400ceca099d3af3b87d Gerrit-Change-Number: 86348 Gerrit-PatchSet: 2 Gerrit-Owner: Dolan Liu <liuyong5(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: DZ <danielzhang(a)mxic.com.cn> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: DZ <danielzhang(a)mxic.com.cn> Gerrit-Attention: Dolan Liu <liuyong5(a)huaqin.corp-partner.google.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Comment-Date: Tue, 25 Mar 2025 06:28:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: DZ <danielzhang(a)mxic.com.cn> Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org>

1 0

[M] Change in flashrom[main]: flashchips: Add XMC25QH64A
by Eric Park (Code Review) 24 Mar '25

24 Mar '25

Attention is currently required from: Anastasia Klimchuk, Eric Park, Nikolai Artemiev, Stefan Reinauer. Hello Anastasia Klimchuk, Nikolai Artemiev, Stefan Reinauer, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/86990?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Verified-1 by build bot (Jenkins) Change subject: flashchips: Add XMC25QH64A ...................................................................... flashchips: Add XMC25QH64A Based off of the now-abandoned GitHub pull request here: https://github.com/flashrom/flashrom/pull/239 This commit applies the changes on top of the refactor where the flash chip declarations were separated by vendor. Change-Id: I5b11e30f0a5357a6cbb32ddb93f450de5364c60b Co-authored-by: Ayushman Dutta <ayushman999(a)gmail.com> Co-authored-by: "aiyion.prime" <git(a)aiyionpri.me> Signed-off-by: Eric Park <me(a)ericswpark.com> --- M flashchips/xmc.c M include/flashchips.h 2 files changed, 57 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/90/86990/4 -- To view, visit https://review.coreboot.org/c/flashrom/+/86990?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I5b11e30f0a5357a6cbb32ddb93f450de5364c60b Gerrit-Change-Number: 86990 Gerrit-PatchSet: 4 Gerrit-Owner: Eric Park <me(a)ericswpark.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Attention: Eric Park <me(a)ericswpark.com>

1 0

[M] Change in flashrom[main]: flashchips: Add XMC25QH64A
by Eric Park (Code Review) 24 Mar '25

24 Mar '25

Attention is currently required from: Anastasia Klimchuk, Eric Park, Nikolai Artemiev, Stefan Reinauer. Hello Anastasia Klimchuk, Nikolai Artemiev, Stefan Reinauer, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/86990?usp=email to look at the new patch set (#3). Change subject: flashchips: Add XMC25QH64A ...................................................................... flashchips: Add XMC25QH64A Based off of the now-abandoned GitHub pull request here: https://github.com/flashrom/flashrom/pull/239 This commit applies the changes on top of the refactor where the flash chip declarations were separated by vendor. Change-Id: I5b11e30f0a5357a6cbb32ddb93f450de5364c60b Co-authored-by: Ayushman Dutta <ayushman999(a)gmail.com> Co-authored-by: "aiyion.prime" <git(a)aiyionpri.me> Signed-off-by: Eric Park <me(a)ericswpark.com> --- M flashchips/xmc.c M include/flashchips.h 2 files changed, 57 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/90/86990/3 -- To view, visit https://review.coreboot.org/c/flashrom/+/86990?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I5b11e30f0a5357a6cbb32ddb93f450de5364c60b Gerrit-Change-Number: 86990 Gerrit-PatchSet: 3 Gerrit-Owner: Eric Park <me(a)ericswpark.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Attention: Eric Park <me(a)ericswpark.com>

1 0

[M] Change in flashrom[main]: flashchips: Add XMC25QH6A
by Eric Park (Code Review) 24 Mar '25

24 Mar '25

Attention is currently required from: Anastasia Klimchuk, Eric Park, Nikolai Artemiev, Stefan Reinauer. Hello Anastasia Klimchuk, Nikolai Artemiev, Stefan Reinauer, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/86990?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified-1 by build bot (Jenkins) Change subject: flashchips: Add XMC25QH6A ...................................................................... flashchips: Add XMC25QH6A Based off of the now-abandoned GitHub pull request here: https://github.com/flashrom/flashrom/pull/239 This commit applies the changes on top of the refactor where the flash chip declarations were separated by vendor. Change-Id: I5b11e30f0a5357a6cbb32ddb93f450de5364c60b Co-authored-by: Ayushman Dutta <ayushman999(a)gmail.com> Co-authored-by: "aiyion.prime" <git(a)aiyionpri.me> Signed-off-by: Eric Park <me(a)ericswpark.com> --- M flashchips/xmc.c M include/flashchips.h 2 files changed, 57 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/90/86990/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/86990?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I5b11e30f0a5357a6cbb32ddb93f450de5364c60b Gerrit-Change-Number: 86990 Gerrit-PatchSet: 2 Gerrit-Owner: Eric Park <me(a)ericswpark.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Attention: Eric Park <me(a)ericswpark.com>

1 0

[M] Change in flashrom[main]: flashchips: Add XMC25QH6A
by Eric Park (Code Review) 24 Mar '25

24 Mar '25

Eric Park has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/86990?usp=email ) Change subject: flashchips: Add XMC25QH6A ...................................................................... flashchips: Add XMC25QH6A Based off of the now-abandoned GitHub pull request here: https://github.com/flashrom/flashrom/pull/239 This commit applies the changes on top of the refactor where the flash chip declarations were separated by vendor. Change-Id: I5b11e30f0a5357a6cbb32ddb93f450de5364c60b Co-authored-by: Ayushman Dutta <ayushman999(a)gmail.com> Co-authored-by: "aiyion.prime" <git(a)aiyionpri.me> Signed-off-by: Eric Park <me(a)ericswpark.com> --- M flashchips/xmc.c M include/flashchips.h 2 files changed, 58 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/90/86990/1 diff --git a/flashchips/xmc.c b/flashchips/xmc.c index 4ed0225..ac384a9 100644 --- a/flashchips/xmc.c +++ b/flashchips/xmc.c @@ -248,6 +248,47 @@ { .vendor = "XMC", + .name = "XM25QH64A", + .bustype = BUS_SPI, + .manufacture_id = XMC_ID, + .model_id = XMC_XM25QH64A, + .total_size = 8192, + .page_size = 256, + /* supports SFDP */ + /* OTP: 512B total; enter 0x3A */ + /* QPI enable 0x38, disable 0xFF */ + .feature_bits = FEATURE_WRSR_WREN | FEATURE_OTP | FEATURE_QPI, + .tested = TEST_OK_PREW, + .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, + .block_erasers = + { + { + .eraseblocks = { {4 * 1024, 2048} }, + .block_erase = spi_block_erase_20, + }, { + .eraseblocks = { {32 * 1024, 256} }, + .block_erase = spi_block_erase_52, + }, { + .eraseblocks = { {64 * 1024, 128} }, + .block_erase = spi_block_erase_d8, + }, { + .eraseblocks = { { 8192 * 1024, 1} }, + .block_erase = spi_block_erase_60, + }, { + .eraseblocks = { { 8192 * 1024, 1} }, + .block_erase = spi_block_erase_c7, + } + }, + .printlock = spi_prettyprint_status_register_bp3_srwd, /* bit6 is quad enable */ + .unlock = spi_disable_blockprotect_bp3_srwd, + .write = spi_chip_write_256, + .read = spi_chip_read, + .voltage = {2700, 3600}, + }, + + { + .vendor = "XMC", .name = "XM25QH64C/XM25QH64D", .bustype = BUS_SPI, .manufacture_id = ST_ID, diff --git a/include/flashchips.h b/include/flashchips.h index 556729c..f59b7ce 100644 --- a/include/flashchips.h +++ b/include/flashchips.h @@ -1082,6 +1082,23 @@ #define WINBOND_W49V002A 0xB0 #define WINBOND_W49V002FA 0x32 +#define XMC_ID 0x20 /* same as ST_ID */ +#define XMC_XM25QH256B 0x6019 +#define XMC_XM25QH128A 0x1708 +#define XMC_XM25QH128B 0x6018 +#define XMC_XM25QH64A 0x7017 +#define XMC_XM25QH64B 0x6017 +#define XMC_XM25QH32B 0x4016 /* 0x6016 for QPI mode */ +#define XMC_XM25QH16B 0x4015 +#define XMC_XM25QH80B 0x4014 +#define XMC_XM25QH40B 0x4013 +#define XMC_XM25QU256B 0x7019 +#define XMC_XM25QU128B 0x5018 +#define XMC_XM25QU64A 0x3817 +#define XMC_XM25QU64B 0x5017 +#define XMC_XM25QU40B 0x5013 +#define XMC_XM25QU20B 0x5012 + #define XTX_ID 0x0B /* XTX Technology Limited */ #define XTX_XT25F02E 0x4012 #define XTX_XT25F64B 0x4017 -- To view, visit https://review.coreboot.org/c/flashrom/+/86990?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I5b11e30f0a5357a6cbb32ddb93f450de5364c60b Gerrit-Change-Number: 86990 Gerrit-PatchSet: 1 Gerrit-Owner: Eric Park <me(a)ericswpark.com>

1 0

[XS] Change in flashrom[main]: flashchips: Add GD25B127D to the models
by Victor Lim (Code Review) 23 Mar '25

23 Mar '25

Victor Lim has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/86977?usp=email ) Change subject: flashchips: Add GD25B127D to the models ...................................................................... flashchips: Add GD25B127D to the models Added GD25B127D without verification This is a old product that is no longer in production. https://www.gigadevice.com.cn/Public/Uploads/uploadfile/files/20220714/DS-0… Change-Id: Ifa96a4d5c9cee6b74d561622664d52835caafa3f Signed-off-by: Victor <vlim(a)gigadevice.com> --- M flashchips.c M include/flashchips.h 2 files changed, 3 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/77/86977/1 diff --git a/flashchips.c b/flashchips.c index 3a2957b..6a99e3c 100644 --- a/flashchips.c +++ b/flashchips.c @@ -7405,7 +7405,7 @@ { .vendor = "GigaDevice", - .name = "GD25Q128E/GD25B128E/GD25R128E/GD25Q127C", + .name = "GD25Q128E/GD25B128E/GD25R128E/GD25Q127C/GD25B127D", .bustype = BUS_SPI, .manufacture_id = GIGADEVICE_ID, .model_id = GIGADEVICE_GD25Q128, @@ -7413,7 +7413,7 @@ .page_size = 256, /* OTP: 3072B total; read 0x48; write 0x42, erase 0x44 */ .feature_bits = FEATURE_WRSR_WREN | FEATURE_OTP | FEATURE_WRSR2, - .tested = TEST_OK_PREWB, + .tested = TEST_UNTESTED, .probe = PROBE_SPI_RDID, .probe_timing = TIMING_ZERO, .block_erasers = diff --git a/include/flashchips.h b/include/flashchips.h index 9cb4cd0..903629c 100644 --- a/include/flashchips.h +++ b/include/flashchips.h @@ -394,7 +394,7 @@ #define GIGADEVICE_GD25Q16 0x4015 /* Same as GD25Q16B (which has OTP) */ #define GIGADEVICE_GD25Q32 0x4016 /* Same as GD25Q32B */ #define GIGADEVICE_GD25Q64 0x4017 /* Same as GD25Q64B */ -#define GIGADEVICE_GD25Q128 0x4018 /* Same as GD25Q128B, GD25Q127C, GD25Q128C,and GD25Q128E, GD25B128E, GD25R128E can be distinguished by SFDP */ +#define GIGADEVICE_GD25Q128 0x4018 /* Same as GD25Q128B, GD25Q127C, GD25B127D, GD25Q128C, GD25Q128E, GD25B128E, GD25R128E can be distinguished by SFDP */ #define GIGADEVICE_GD25Q256D 0x4019 /* Same as GD25B256E, GD25Q256E, GD25R256E */ #define GIGADEVICE_GD25B512MF 0x401A /* Same as GD25R512MF */ #define GIGADEVICE_GD25VQ21B 0x4212 -- To view, visit https://review.coreboot.org/c/flashrom/+/86977?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Ifa96a4d5c9cee6b74d561622664d52835caafa3f Gerrit-Change-Number: 86977 Gerrit-PatchSet: 1 Gerrit-Owner: Victor Lim <vlim(a)gigadevice.com>

1 0

[L] Change in flashrom[main]: spidriver: Add support for the Excamera Labs SPIDriver programmer
by Anastasia Klimchuk (Code Review) 23 Mar '25

23 Mar '25

Attention is currently required from: Simon Arlott. Anastasia Klimchuk has posted comments on this change by Simon Arlott. ( https://review.coreboot.org/c/flashrom/+/86411?usp=email ) Change subject: spidriver: Add support for the Excamera Labs SPIDriver programmer ...................................................................... Patch Set 8: (1 comment) Patchset: PS8: Simon, this will be submitted in a few days, I wanted to ask you, Maybe (after the patch is submitted) you could make a post to flashrom mailing list, to tell about new programmer that you added? You've done a lot of work! -- To view, visit https://review.coreboot.org/c/flashrom/+/86411?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I07b23c1146d4ad3606b54a1e8dc8030cf4ebf57b Gerrit-Change-Number: 86411 Gerrit-PatchSet: 8 Gerrit-Owner: Simon Arlott <flashrom.simon(a)arlott.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Simon Arlott <flashrom.simon(a)arlott.org> Gerrit-Comment-Date: Mon, 24 Mar 2025 00:04:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[L] Change in flashrom[main]: spidriver: Add support for the Excamera Labs SPIDriver programmer
by Peter Marheine (Code Review) 23 Mar '25

23 Mar '25

Attention is currently required from: Simon Arlott. Peter Marheine has posted comments on this change by Simon Arlott. ( https://review.coreboot.org/c/flashrom/+/86411?usp=email ) Change subject: spidriver: Add support for the Excamera Labs SPIDriver programmer ...................................................................... Patch Set 8: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/86411?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I07b23c1146d4ad3606b54a1e8dc8030cf4ebf57b Gerrit-Change-Number: 86411 Gerrit-PatchSet: 8 Gerrit-Owner: Simon Arlott <flashrom.simon(a)arlott.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Simon Arlott <flashrom.simon(a)arlott.org> Gerrit-Comment-Date: Sun, 23 Mar 2025 21:21:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit