- flashrom-gerrit - mail.coreboot.org

[S] Change in flashrom[main]: cli: Use flashrom_supported_programmers API in cli
by Anastasia Klimchuk (Code Review) 12 Apr '25

12 Apr '25

Attention is currently required from: Dmitry Zhadinets, Peter Marheine. Anastasia Klimchuk has posted comments on this change by Dmitry Zhadinets. ( https://review.coreboot.org/c/flashrom/+/87195?usp=email ) Change subject: cli: Use flashrom_supported_programmers API in cli ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: I just thought about something, it's for the separate commit. I am writing here but it's for separate patch. It would be great if you could add information about your new APIs (3 already submitted!) to our Recent development doc. We accumulate ongoing development between releases, so that people know what's going on and then it makes it easier to write release notes (and not forget anything). Often it's included in the same patch, but it's fine to add later. The doc is in `doc/release_notes/devel.rst` and it will be displayed here https://flashrom.org/release_notes/devel.html Also a doc how to add docs https://flashrom.org/how_to_add_docs.html Thank you so much! -- To view, visit https://review.coreboot.org/c/flashrom/+/87195?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I86ac83ee0ef4e850e69aa4e7b607e28ebab9d3d5 Gerrit-Change-Number: 87195 Gerrit-PatchSet: 2 Gerrit-Owner: Dmitry Zhadinets <dzhadinets(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Dmitry Zhadinets <dzhadinets(a)gmail.com> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Comment-Date: Sat, 12 Apr 2025 12:33:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[M] Change in flashrom[main]: libflashrom: Add API for capabilitible chips
by Anastasia Klimchuk (Code Review) 12 Apr '25

12 Apr '25

Attention is currently required from: Dmitry Zhadinets, Peter Marheine. Anastasia Klimchuk has posted comments on this change by Dmitry Zhadinets. ( https://review.coreboot.org/c/flashrom/+/87251?usp=email ) Change subject: libflashrom: Add API for capabilitible chips ...................................................................... Patch Set 4: (1 comment) File tests/tests.c: https://review.coreboot.org/c/flashrom/+/87251/comment/588af163_e5e4dbcd?us… : PS4, Line 496: const struct CMUnitTest libflashrom_tests[] = { : cmocka_unit_test(flashrom_set_log_callback_test_success), : cmocka_unit_test(flashrom_set_log_callback_v2_test_success), : cmocka_unit_test(flashrom_set_log_level_test_success), : cmocka_unit_test(flashrom_supported_programmers_test_success), : cmocka_unit_test(flashrom_programmer_capabilities_test_success), : }; : ret |= cmocka_run_group_tests_name("libflashrom.c tests", libflashrom_tests, NULL, NULL); : I could repro the failing test/spi25.c when I downloaded the patch and reverted the diffs in tests/tests.c (moved the lines back). 4 errors, they look similar like this: ``` [ ERROR ] --- %s() has remaining non-returned values. : __wrap_spi_send_command../tests/spi25.c:167: note: remaining item was declared here ../tests/spi25.c:168: note: remaining item was declared here ../tests/spi25.c:169: note: remaining item was declared here __wrap_spi_send_command: '%s' parameter still has values that haven't been checked. : flash../tests/spi25.c:164: note: remaining item was declared here ``` I am not sure which test has a bug, need to have a look. The failing sequence has libflashrom_tests first and spi25_tests after that. -- To view, visit https://review.coreboot.org/c/flashrom/+/87251?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Id33fac2935b4098586526bda87b25231c9a6ab39 Gerrit-Change-Number: 87251 Gerrit-PatchSet: 4 Gerrit-Owner: Dmitry Zhadinets <dzhadinets(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Dmitry Zhadinets <dzhadinets(a)gmail.com> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Comment-Date: Sat, 12 Apr 2025 11:46:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[M] Change in flashrom[main]: libflashrom: Add API for capabilitible chips
by Anastasia Klimchuk (Code Review) 12 Apr '25

12 Apr '25

Attention is currently required from: Dmitry Zhadinets, Peter Marheine. Anastasia Klimchuk has posted comments on this change by Dmitry Zhadinets. ( https://review.coreboot.org/c/flashrom/+/87251?usp=email ) Change subject: libflashrom: Add API for capabilitible chips ...................................................................... Patch Set 4: (1 comment) Patchset: PS2: > It turns out that DUMMY is disabled in some cases. […] Sorry for some delay, while you asked for help. I read the comment and info in commit message, it seems there are few questions? 1) what happened in spi test, you said there is a bug? do you have error logs? I will try to repro. It's good if you found bug in another test, it can go in a separate commit 2) dummy has several options what to emulate (see https://github.com/flashrom/flashrom/blob/main/dummyflasher.c#L31, string values in the code https://github.com/flashrom/flashrom/blob/main/dummyflasher.c#L1216) and one of them has duplicate IDs as of now. I forgot which one, probably EMULATE_MACRONIX_MX25L6436. If you emulate it should find two matches in flashchips. 3) I still want to create a patch for probing v2, but it will need test as well, so tests are useful anyway. -- To view, visit https://review.coreboot.org/c/flashrom/+/87251?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Id33fac2935b4098586526bda87b25231c9a6ab39 Gerrit-Change-Number: 87251 Gerrit-PatchSet: 4 Gerrit-Owner: Dmitry Zhadinets <dzhadinets(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Dmitry Zhadinets <dzhadinets(a)gmail.com> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Comment-Date: Sat, 12 Apr 2025 10:43:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Dmitry Zhadinets <dzhadinets(a)gmail.com>

1 0

[S] Change in flashrom[main]: cli: Use flashrom_supported_programmers API in cli
by Anastasia Klimchuk (Code Review) 12 Apr '25

12 Apr '25

Attention is currently required from: Dmitry Zhadinets, Peter Marheine. Anastasia Klimchuk has posted comments on this change by Dmitry Zhadinets. ( https://review.coreboot.org/c/flashrom/+/87195?usp=email ) Change subject: cli: Use flashrom_supported_programmers API in cli ...................................................................... Patch Set 2: (2 comments) Patchset: PS2: > I think that this change is not needed because the code has become more complex […] I can see what you mean by saying the code is more complex. But I think we should be using our own API wherever it's applicable: it gives an example of correct usage to people, and also can help to detect breakage. I just looked and it's a bit sad that the other functions print_supported_* are not using libflashrom :( I think it's better to gradually change them one by one and maybe in future have them all using libflashrom. Commit Message: https://review.coreboot.org/c/flashrom/+/87195/comment/333a962b_31f16a1e?us… : PS2, Line 9: Testing: Both unit tests and CLI tools serve as libflashrom clients. : All unit tests run successfully. I have a suggestion instead of these two lines (which are true but very generic) add testing info which is specific to the patch. Concretely, in this case running `flashrom -h` (help) or `flashrom -L` (info on what's supported) will run the code which this patch is changing. So instead I suggest something like: Testing: `flashrom -h` and `flashrom -L` both print the list of supported programmers successfully -- To view, visit https://review.coreboot.org/c/flashrom/+/87195?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I86ac83ee0ef4e850e69aa4e7b607e28ebab9d3d5 Gerrit-Change-Number: 87195 Gerrit-PatchSet: 2 Gerrit-Owner: Dmitry Zhadinets <dzhadinets(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Dmitry Zhadinets <dzhadinets(a)gmail.com> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Comment-Date: Sat, 12 Apr 2025 09:42:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Dmitry Zhadinets <dzhadinets(a)gmail.com>

1 0

[XS] Change in flashrom[main]: doc: Update supported flashchips page because we split the large file
by Anastasia Klimchuk (Code Review) 11 Apr '25

11 Apr '25

Anastasia Klimchuk has submitted this change. ( https://review.coreboot.org/c/flashrom/+/86953?usp=email ) Change subject: doc: Update supported flashchips page because we split the large file ...................................................................... doc: Update supported flashchips page because we split the large file Change-Id: Ic6179517d0f951a32c0c4e0baf32677398224542 Signed-off-by: Anastasia Klimchuk <aklm(a)flashrom.org> Reviewed-on: https://review.coreboot.org/c/flashrom/+/86953 Reviewed-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M doc/supported_hw/supported_flashchips.rst 1 file changed, 6 insertions(+), 3 deletions(-) Approvals: build bot (Jenkins): Verified Stefan Reinauer: Looks good to me, approved diff --git a/doc/supported_hw/supported_flashchips.rst b/doc/supported_hw/supported_flashchips.rst index 8e881d2..9af2601 100644 --- a/doc/supported_hw/supported_flashchips.rst +++ b/doc/supported_hw/supported_flashchips.rst @@ -2,10 +2,13 @@ Supported flash chips ===================== -The list of all supported flash chips is in ``flashchips.c`` file in the source tree. -If you have a flashrom repo cloned locally, you can look at the file in your repo. +The info about all supported flash chips is in the ``/flashchips`` directory in the source tree. +If you have a flashrom repo cloned locally, you can look at this directory in your repo. -Alternatively inspect the file on the `web UI of our GitHub mirror <https://github.com/flashrom/flashrom/blob/main/flashchips.c>`_. +Alternatively inspect it on the `web UI of our GitHub mirror <https://github.com/flashrom/flashrom/tree/main/flashchips>`_. + +All the files in the ``/flashchips`` directory are included in parent file ``flashchips.c``. You can inspect the source +`here <https://github.com/flashrom/flashrom/blob/main/flashchips.c>`_. If you can run flashrom locally, the command ``flashrom -L`` prints the list of all supported flash chips (see :doc:`/classic_cli_manpage` for more details on command line options). The output of this command is long, so you might -- To view, visit https://review.coreboot.org/c/flashrom/+/86953?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Ic6179517d0f951a32c0c4e0baf32677398224542 Gerrit-Change-Number: 86953 Gerrit-PatchSet: 4 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[XS] Change in flashrom[main]: flashchips: Add GD25B127D to the models
by Anastasia Klimchuk (Code Review) 11 Apr '25

11 Apr '25

Anastasia Klimchuk has abandoned this change. ( https://review.coreboot.org/c/flashrom/+/86977?usp=email ) Change subject: flashchips: Add GD25B127D to the models ...................................................................... Abandoned This patch has newer version CB:86996 -- To view, visit https://review.coreboot.org/c/flashrom/+/86977?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: abandon Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Ifa96a4d5c9cee6b74d561622664d52835caafa3f Gerrit-Change-Number: 86977 Gerrit-PatchSet: 1 Gerrit-Owner: Victor Lim <vlim(a)gigadevice.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[M] Change in flashrom[main]: libflashrom: Add API for capabilitible chips
by Dmitry Zhadinets (Code Review) 10 Apr '25

10 Apr '25

Attention is currently required from: Anastasia Klimchuk. Dmitry Zhadinets has posted comments on this change by Dmitry Zhadinets. ( https://review.coreboot.org/c/flashrom/+/87251?usp=email ) Change subject: libflashrom: Add API for capabilitible chips ...................................................................... Patch Set 4: (1 comment) Patchset: PS2: > I need help with the test. […] It turns out that DUMMY is disabled in some cases. I could check the return value of programmer_init(), but… to be honest, I don’t like this test anyway—there’s no variability in it. Do you have any ideas on how to test compatibility more effectively? -- To view, visit https://review.coreboot.org/c/flashrom/+/87251?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Id33fac2935b4098586526bda87b25231c9a6ab39 Gerrit-Change-Number: 87251 Gerrit-PatchSet: 4 Gerrit-Owner: Dmitry Zhadinets <dzhadinets(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Thu, 10 Apr 2025 05:31:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Dmitry Zhadinets <dzhadinets(a)gmail.com>

1 0

[M] Change in flashrom[main]: libflashrom: Add API for capabilitible chips
by Dmitry Zhadinets (Code Review) 10 Apr '25

10 Apr '25

Attention is currently required from: Anastasia Klimchuk, Dmitry Zhadinets. Hello Anastasia Klimchuk, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/87251?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Verified-1 by build bot (Jenkins) Change subject: libflashrom: Add API for capabilitible chips ...................................................................... libflashrom: Add API for capabilitible chips There were no options available to obtain the list of compatible chips for the programmer. The implementation is based on flashrom_supported_flash_chips and flashrom_flash_probe. Arrays of constant strings are returned, and the array must be freed using flashrom_data_free. Testing: Both unit tests and CLI tools serve as libflashrom clients. All unit tests run successfully. Tests are moved because there is a bug in spi test. It does not clean everything. WIP Change-Id: Id33fac2935b4098586526bda87b25231c9a6ab39 Signed-off-by: Dmitry Zhadinets <dzhadinets(a)gmail.com> --- M include/libflashrom.h M libflashrom.c M libflashrom.map M tests/libflashrom.c M tests/tests.c M tests/tests.h 6 files changed, 69 insertions(+), 9 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/51/87251/4 -- To view, visit https://review.coreboot.org/c/flashrom/+/87251?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Id33fac2935b4098586526bda87b25231c9a6ab39 Gerrit-Change-Number: 87251 Gerrit-PatchSet: 4 Gerrit-Owner: Dmitry Zhadinets <dzhadinets(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Dmitry Zhadinets <dzhadinets(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org>

1 0

[M] Change in flashrom[main]: libflashrom: Add API for capabilitible chips
by Dmitry Zhadinets (Code Review) 10 Apr '25

10 Apr '25

Attention is currently required from: Anastasia Klimchuk. Hello Anastasia Klimchuk, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/87251?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified-1 by build bot (Jenkins) Change subject: libflashrom: Add API for capabilitible chips ...................................................................... libflashrom: Add API for capabilitible chips There were no options available to obtain the list of compatible chips for the programmer. The implementation is based on flashrom_supported_flash_chips and flashrom_flash_probe. Arrays of constant strings are returned, and the array must be freed using flashrom_data_free. Testing: Both unit tests and CLI tools serve as libflashrom clients. All unit tests run successfully. Tests are moved because there is a bug in spi test. It does not clean everything. WIP Change-Id: Id33fac2935b4098586526bda87b25231c9a6ab39 Signed-off-by: Dmitry Zhadinets <dzhadinets(a)gmail.com> --- M include/libflashrom.h M libflashrom.c M libflashrom.map M tests/libflashrom.c M tests/tests.c M tests/tests.h 6 files changed, 63 insertions(+), 9 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/51/87251/3 -- To view, visit https://review.coreboot.org/c/flashrom/+/87251?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Id33fac2935b4098586526bda87b25231c9a6ab39 Gerrit-Change-Number: 87251 Gerrit-PatchSet: 3 Gerrit-Owner: Dmitry Zhadinets <dzhadinets(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org>

1 0

[M] Change in flashrom[main]: libflashrom: Add API for capabilitible chips
by Dmitry Zhadinets (Code Review) 10 Apr '25

10 Apr '25

Attention is currently required from: Anastasia Klimchuk. Dmitry Zhadinets has posted comments on this change by Dmitry Zhadinets. ( https://review.coreboot.org/c/flashrom/+/87251?usp=email ) Change subject: libflashrom: Add API for capabilitible chips ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: I need help with the test. What dummy chip can be definitely compatible with some specific dummy parameters -- To view, visit https://review.coreboot.org/c/flashrom/+/87251?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Id33fac2935b4098586526bda87b25231c9a6ab39 Gerrit-Change-Number: 87251 Gerrit-PatchSet: 2 Gerrit-Owner: Dmitry Zhadinets <dzhadinets(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Thu, 10 Apr 2025 04:45:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit