- flashrom-gerrit - mail.coreboot.org

[M] Change in flashrom[main]: flashchips: Add Spansion S25FS512S
by Anastasia Klimchuk (Code Review) 21 Dec '24

21 Dec '24

Attention is currently required from: Anton Samsonov, Anton Samsonov, Nikolai Artemiev, Stefan Reinauer. Anastasia Klimchuk has posted comments on this change by Anton Samsonov. ( https://review.coreboot.org/c/flashrom/+/85585?usp=email ) Change subject: flashchips: Add Spansion S25FS512S ...................................................................... Patch Set 2: (3 comments) File flashchips/spansion.c: https://review.coreboot.org/c/flashrom/+/85585/comment/a1a766e3_4533b4b1?us… : PS2, Line 1043: /* Note on FEATURE_4BA_ENTER: the command set only defines command 0xB7 : to enter 4BA mode, but there is no counterpart command "Exit 4BA mode", : and the code 0xE9 is assigned to another command ("Password unlock"). */ : /* Note on FEATURE_4BA_ENTER_EAR7 (not set): the "Extended address mode" bit : is stored in configuration register CR2V[7], which can only be read / written : by generic commands ("Read any register" / "Write any register"), that itself : expect a 3- or 4-byte address of register in question, which in turn depends on : the same register, that is initially set from non-volatile register CR2NV[7] : that defaults to 0, but can be programmed to 1 for starting in 32-bit mode. */ > That is not a "wisdom", but merely observations of trial and error in finding proper combination. […] You made trials and errors, and documented it: and this comment will be helping lots of other people who are reading it. This makes community stronger, I count this as wisdom! :) My first thought about commands from datasheet: you spent time implementing Evaluate Erase Status command, and then it turns out it doesn't work as promised. I would be reluctant to spend even more on another very special command: maybe it doesn't work either? A half of promised Blank Check During Erase functionality is already implemented in flashrom: checking whether bytes already have expected "erase value", and in this case nothing to do. About your WIP work, I can think of two options. One is: do nothing. Second one: create a WIP patch and make a post on the mailing list about it. Both options are fine, you can do any. File include/flashchips.h: https://review.coreboot.org/c/flashrom/+/85585/comment/b0a325c4_35b95f51?us… : PS2, Line 717: SPANSION_S25FS512S > If you vote for the _UL suffix, then should S25FL512 also be changed to S25FL512S_UL simultaneously, since this patch alters that macro anyway? Yes I like this idea, sorry I missed the bigger picture. Also because S25FL512 -> S25FL512S_UL now has long ID, it can go together with other log IDs (as the first one alphabetically). https://review.coreboot.org/c/flashrom/+/85585/comment/8a4da31a_76819d1e?us… : PS2, Line 717: 0x02200081 > > 03h -> ?? where it is? […] Thank you so much! Very useful explanation for me. -- To view, visit https://review.coreboot.org/c/flashrom/+/85585?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I40b6c081ec7d57eac4f6d2b69cea3878bc92bb47 Gerrit-Change-Number: 85585 Gerrit-PatchSet: 2 Gerrit-Owner: Anton Samsonov <avscomputing(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Anton Samsonov <devel(a)zxlab.ru> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Anton Samsonov <avscomputing(a)gmail.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Attention: Anton Samsonov <devel(a)zxlab.ru> Gerrit-Comment-Date: Sat, 21 Dec 2024 09:04:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anton Samsonov <avscomputing(a)gmail.com> Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org>

1 0

[S] Change in flashrom[main]: Add Glasgow to supported serprog programmers documentation
by Cattus QQ (Code Review) 21 Dec '24

21 Dec '24

Attention is currently required from: Anastasia Klimchuk. Hello Anastasia Klimchuk, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/85527?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: Add Glasgow to supported serprog programmers documentation ...................................................................... Add Glasgow to supported serprog programmers documentation Updated the serprog overview page with info about the Glasgow Interface Explorer as a valid programmer. Wasn't able to test as the project wouldnt compile with meson for me (MacOS 15.1) but tried to make it as similar as possible to what was already there. Change-Id: Iabcec27dd675485c69875178858c604ce5c3da29 Signed-off-by: Cattus QQ <cattusqq(a)gmail.com> --- A doc/supported_hw/supported_prog/serprog/300px-glasgow-in-case.png A doc/supported_hw/supported_prog/serprog/300px-glasgow-pcba.png M doc/supported_hw/supported_prog/serprog/overview.rst 3 files changed, 11 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/27/85527/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/85527?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Iabcec27dd675485c69875178858c604ce5c3da29 Gerrit-Change-Number: 85527 Gerrit-PatchSet: 2 Gerrit-Owner: Cattus QQ <cattusqq(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org>

1 0

[S] Change in flashrom[main]: Add Glasgow to supported serprog programmers documentation
by Name of user not set (Code Review) 21 Dec '24

21 Dec '24

Attention is currently required from: Anastasia Klimchuk. cattusqq(a)gmail.com has posted comments on this change by cattusqq(a)gmail.com. ( https://review.coreboot.org/c/flashrom/+/85527?usp=email ) Change subject: Add Glasgow to supported serprog programmers documentation ...................................................................... Patch Set 1: (6 comments) Patchset: PS1: Thanks for being so nice Anastasia! PS1: > One more thing I forgot: in the email from Gerrit your name is "Name of user not set". […] I'm not sure why this is happening. I followed step 6, in my 'https://review.coreboot.org/settings/' page I have full name, display name, and email set. I might have done things out of order for this commit though as I was still figuring out how to use gerrit, so I'll try updating the commit, and hopefully the email will work this time. Commit Message: https://review.coreboot.org/c/flashrom/+/85527/comment/7da8425a_086e0d45?us… : PS1, Line 10: the project wouldnt compile with meson for me (MacOS 15.1) > I first thought that flashrom does not compile, but then I read your blog post and now I think maybe […] I will try again with these updates. https://review.coreboot.org/c/flashrom/+/85527/comment/5564208b_1a5789ce?us… : PS1, Line 9: Updated the serprog overview page with info about the Glasgow Interface Explorer as a valid programmer. : Wasnt able to test as the project wouldnt compile with meson for me (MacOS 15.1) : but tried to make it as similar as possible to what was already there. > We wrap commit message by 72 chars, and I think the first line is longer (maybe the second one too) […] Apologies, will fix, thankyou! File doc/supported_hw/supported_prog/serprog/overview.rst: https://review.coreboot.org/c/flashrom/+/85527/comment/c6a40c5e_ff3245ed?us… : PS1, Line 105: Source for the Glasgow Project can be found `here <https://github.com/GlasgowEmbedded/glasgow>`_ > This gives a warning `WARNING: Duplicate explicit target name: "here".` […] This is my first time using rst and gerrit, sorry for all the newbie mistakes! Did the second link generate a warning too or just the first? If only the first, I think it's saying 'here' is already used as a link target, so if I change that text to something unique it should work. I'll try that in the new commit. And I'll try again to get my build to compile. https://review.coreboot.org/c/flashrom/+/85527/comment/74f8ab68_08a3a1b0?us… : PS1, Line 108: 76hPuPkpDOTAxj7TegVqV8UkmKEjZ8TvLLBoDoVPpw > What is this hash? :) I assume that's by mistake? Yep that definitely shouldn't be there. Thanks. -- To view, visit https://review.coreboot.org/c/flashrom/+/85527?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Iabcec27dd675485c69875178858c604ce5c3da29 Gerrit-Change-Number: 85527 Gerrit-PatchSet: 1 Gerrit-Owner: cattusqq(a)gmail.com Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Sat, 21 Dec 2024 00:35:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org>

1 0

[S] Change in flashrom[main]: doc: Add section about v1.5.1 into release notes
by Matt DeVillier (Code Review) 20 Dec '24

20 Dec '24

Attention is currently required from: Anastasia Klimchuk, Peter Marheine, Stefan Reinauer. Matt DeVillier has posted comments on this change by Anastasia Klimchuk. ( https://review.coreboot.org/c/flashrom/+/85698?usp=email ) Change subject: doc: Add section about v1.5.1 into release notes ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/flashrom/+/85698?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Iea0a8a388d74f4e1ad7e9630413d4a5affc755fe Gerrit-Change-Number: 85698 Gerrit-PatchSet: 1 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Comment-Date: Fri, 20 Dec 2024 13:55:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in flashrom[main]: doc: Add section about v1.5.1 into release notes
by Anastasia Klimchuk (Code Review) 20 Dec '24

20 Dec '24

Attention is currently required from: Matt DeVillier. Hello Matt DeVillier, I'd like you to do a code review. Please visit https://review.coreboot.org/c/flashrom/+/85698?usp=email to review the following change. Change subject: doc: Add section about v1.5.1 into release notes ...................................................................... doc: Add section about v1.5.1 into release notes Change-Id: Iea0a8a388d74f4e1ad7e9630413d4a5affc755fe Original-Change-Id: I80f8423133bf779093d57ea6928f09d9d377d20e Signed-off-by: Anastasia Klimchuk <aklm(a)flashrom.org> Signed-off-by: Matt DeVillier <matt.devillier(a)gmail.com> Original-Reviewed-on: https://review.coreboot.org/c/flashrom/+/85655 Original-Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Original-Reviewed-by: Peter Marheine <pmarheine(a)chromium.org> --- M doc/release_notes/v_1_5.rst 1 file changed, 33 insertions(+), 6 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/98/85698/1 diff --git a/doc/release_notes/v_1_5.rst b/doc/release_notes/v_1_5.rst index 6fcfe33..a7c09d0 100644 --- a/doc/release_notes/v_1_5.rst +++ b/doc/release_notes/v_1_5.rst @@ -10,15 +10,42 @@ Download ======== -flashrom v1.5.0 can be downloaded in various ways: +flashrom v1.5 can be downloaded either via anonymous git at https://review.coreboot.org/flashrom.git, +or as signed source tarballs. -Anonymous checkout from the git repository at https://review.coreboot.org/flashrom.git -(tag v1.5.0) +The key fingerprint for source tarballs is -A tarball is available for download at https://download.flashrom.org/releases/flashrom-v1.5.0.tar.xz -(signature https://download.flashrom.org/releases/flashrom-v1.5.0.tar.xz.asc) +6E6E F9A0 BA47 8006 E277 6E4C C037 BB41 3134 D111 -fingerprint: 6E6E F9A0 BA47 8006 E277 6E4C C037 BB41 3134 D111 +Version v1.5.1 +--------------- + +Version 1.5.1 fixed an issue flashing some Intel-based platforms with the internal programmer +that was introduced in 1.5.0. +Users with older Intel-based platforms (Broadwell/Braswell and earlier) flashing using the internal +programmer option might encounter an 'Invalid OPCODE' error when erasing/writing which would lead to an +incomplete flash and potentially a bricked device. External flashing was not affected at all. + +All users are encouraged to update. + +Ticket: https://ticket.coreboot.org/issues/573 + +Patch: https://review.coreboot.org/c/flashrom/+/85612 + +Git tag: ``v1.5.1`` + +Tarball: https://download.flashrom.org/releases/flashrom-v1.5.1.tar.xz + +Signature: https://download.flashrom.org/releases/flashrom-v1.5.1.tar.xz.asc + +Version v1.5.0 +-------------- + +Git tag: ``v1.5.0`` + +Tarball: https://download.flashrom.org/releases/flashrom-v1.5.0.tar.xz + +Signature: https://download.flashrom.org/releases/flashrom-v1.5.0.tar.xz.asc Known issues ============ -- To view, visit https://review.coreboot.org/c/flashrom/+/85698?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Iea0a8a388d74f4e1ad7e9630413d4a5affc755fe Gerrit-Change-Number: 85698 Gerrit-PatchSet: 1 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com>

1 0

[XS] Change in flashrom[1.5.x]: VERSION: Update version to v1.5.1
by Anastasia Klimchuk (Code Review) 20 Dec '24

20 Dec '24

Anastasia Klimchuk has submitted this change. ( https://review.coreboot.org/c/flashrom/+/85688?usp=email ) Change subject: VERSION: Update version to v1.5.1 ...................................................................... VERSION: Update version to v1.5.1 Change-Id: I6cfc5ff2fa3c168f0fce04e1abbd7e834c853c5f Signed-off-by: Anastasia Klimchuk <aklm(a)flashrom.org> Reviewed-on: https://review.coreboot.org/c/flashrom/+/85688 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Peter Marheine <pmarheine(a)chromium.org> --- M VERSION 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Peter Marheine: Looks good to me, approved build bot (Jenkins): Verified diff --git a/VERSION b/VERSION index 2e7bd91..53b5bbb 100644 --- a/VERSION +++ b/VERSION @@ -1 +1 @@ -v1.5.0 +v1.5.1 -- To view, visit https://review.coreboot.org/c/flashrom/+/85688?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: flashrom Gerrit-Branch: 1.5.x Gerrit-Change-Id: I6cfc5ff2fa3c168f0fce04e1abbd7e834c853c5f Gerrit-Change-Number: 85688 Gerrit-PatchSet: 3 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[S] Change in flashrom[1.5.x]: doc: Add section about v1.5.1 into release notes
by Anastasia Klimchuk (Code Review) 20 Dec '24

20 Dec '24

Anastasia Klimchuk has submitted this change. ( https://review.coreboot.org/c/flashrom/+/85655?usp=email ) Change subject: doc: Add section about v1.5.1 into release notes ...................................................................... doc: Add section about v1.5.1 into release notes Change-Id: I80f8423133bf779093d57ea6928f09d9d377d20e Signed-off-by: Anastasia Klimchuk <aklm(a)flashrom.org> Signed-off-by: Matt DeVillier <matt.devillier(a)gmail.com> Reviewed-on: https://review.coreboot.org/c/flashrom/+/85655 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Peter Marheine <pmarheine(a)chromium.org> --- M doc/release_notes/v_1_5.rst 1 file changed, 33 insertions(+), 6 deletions(-) Approvals: build bot (Jenkins): Verified Peter Marheine: Looks good to me, approved diff --git a/doc/release_notes/v_1_5.rst b/doc/release_notes/v_1_5.rst index 6e81353..a7c09d0 100644 --- a/doc/release_notes/v_1_5.rst +++ b/doc/release_notes/v_1_5.rst @@ -10,15 +10,42 @@ Download ======== -flashrom v1.5.0 can be downloaded in various ways: +flashrom v1.5 can be downloaded either via anonymous git at https://review.coreboot.org/flashrom.git, +or as signed source tarballs. -Anonymous checkout from the git repository at https://review.coreboot.org/flashrom.git -(tag v1.5.0) +The key fingerprint for source tarballs is -A tarball is available for download at <TODO add tarball> -(signature <TODO add signature>) +6E6E F9A0 BA47 8006 E277 6E4C C037 BB41 3134 D111 -fingerprint: <TODO add fingerprint> +Version v1.5.1 +--------------- + +Version 1.5.1 fixed an issue flashing some Intel-based platforms with the internal programmer +that was introduced in 1.5.0. +Users with older Intel-based platforms (Broadwell/Braswell and earlier) flashing using the internal +programmer option might encounter an 'Invalid OPCODE' error when erasing/writing which would lead to an +incomplete flash and potentially a bricked device. External flashing was not affected at all. + +All users are encouraged to update. + +Ticket: https://ticket.coreboot.org/issues/573 + +Patch: https://review.coreboot.org/c/flashrom/+/85612 + +Git tag: ``v1.5.1`` + +Tarball: https://download.flashrom.org/releases/flashrom-v1.5.1.tar.xz + +Signature: https://download.flashrom.org/releases/flashrom-v1.5.1.tar.xz.asc + +Version v1.5.0 +-------------- + +Git tag: ``v1.5.0`` + +Tarball: https://download.flashrom.org/releases/flashrom-v1.5.0.tar.xz + +Signature: https://download.flashrom.org/releases/flashrom-v1.5.0.tar.xz.asc Known issues ============ -- To view, visit https://review.coreboot.org/c/flashrom/+/85655?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: flashrom Gerrit-Branch: 1.5.x Gerrit-Change-Id: I80f8423133bf779093d57ea6928f09d9d377d20e Gerrit-Change-Number: 85655 Gerrit-PatchSet: 5 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[XS] Change in flashrom[1.5.x]: VERSION: Update version to v1.5.1
by Peter Marheine (Code Review) 20 Dec '24

20 Dec '24

Attention is currently required from: Anastasia Klimchuk. Peter Marheine has posted comments on this change by Anastasia Klimchuk. ( https://review.coreboot.org/c/flashrom/+/85688?usp=email ) Change subject: VERSION: Update version to v1.5.1 ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/85688?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: 1.5.x Gerrit-Change-Id: I6cfc5ff2fa3c168f0fce04e1abbd7e834c853c5f Gerrit-Change-Number: 85688 Gerrit-PatchSet: 2 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Fri, 20 Dec 2024 05:52:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in flashrom[1.5.x]: doc: Add section about v1.5.1 into release notes
by Peter Marheine (Code Review) 20 Dec '24

20 Dec '24

Attention is currently required from: Anastasia Klimchuk, Matt DeVillier. Peter Marheine has posted comments on this change by Anastasia Klimchuk. ( https://review.coreboot.org/c/flashrom/+/85655?usp=email ) Change subject: doc: Add section about v1.5.1 into release notes ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/85655?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: 1.5.x Gerrit-Change-Id: I80f8423133bf779093d57ea6928f09d9d377d20e Gerrit-Change-Number: 85655 Gerrit-PatchSet: 4 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Fri, 20 Dec 2024 05:52:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in flashrom[1.5.x]: doc: Add section about v1.5.1 into release notes
by Anastasia Klimchuk (Code Review) 20 Dec '24

20 Dec '24

Attention is currently required from: Matt DeVillier, Peter Marheine. Hello Matt DeVillier, Peter Marheine, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/85655?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: doc: Add section about v1.5.1 into release notes ...................................................................... doc: Add section about v1.5.1 into release notes Change-Id: I80f8423133bf779093d57ea6928f09d9d377d20e Signed-off-by: Anastasia Klimchuk <aklm(a)flashrom.org> Signed-off-by: Matt DeVillier <matt.devillier(a)gmail.com> --- M doc/release_notes/v_1_5.rst 1 file changed, 33 insertions(+), 6 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/55/85655/4 -- To view, visit https://review.coreboot.org/c/flashrom/+/85655?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: flashrom Gerrit-Branch: 1.5.x Gerrit-Change-Id: I80f8423133bf779093d57ea6928f09d9d377d20e Gerrit-Change-Number: 85655 Gerrit-PatchSet: 4 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org>

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit