- flashrom-gerrit - mail.coreboot.org

[S] Change in flashrom[main]: dmi.h: Extract DMI declarations to a separate header
by Anastasia Klimchuk (Code Review) Jan. 17, 2026

Jan. 17, 2026

Attention is currently required from: Antonio Vázquez Blanco. Anastasia Klimchuk has posted comments on this change by Antonio Vázquez Blanco. ( https://review.coreboot.org/c/flashrom/+/90632?usp=email ) Change subject: dmi.h: Extract DMI declarations to a separate header ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: Are you sure this is needed? All 3 source file that in this patch need to include dmi.h , all of them already include programmer.h anyway. So everything that needs dmi.h also needs programmer.h - I think this means we don't need a separate header for dmi only. -- To view, visit https://review.coreboot.org/c/flashrom/+/90632?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I5fcb14da0b7f478a4f6badc8929c8389a5fa3e3c Gerrit-Change-Number: 90632 Gerrit-PatchSet: 2 Gerrit-Owner: Antonio Vázquez Blanco <antoniovazquezblanco(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Antonio Vázquez Blanco <antoniovazquezblanco(a)gmail.com> Gerrit-Comment-Date: Sat, 17 Jan 2026 09:05:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in flashrom[main]: platform/udelay: Document file and functions.
by Anastasia Klimchuk (Code Review) Jan. 17, 2026

Jan. 17, 2026

Attention is currently required from: Antonio Vázquez Blanco, Peter Marheine. Anastasia Klimchuk has posted comments on this change by Antonio Vázquez Blanco. ( https://review.coreboot.org/c/flashrom/+/90746?usp=email ) Change subject: platform/udelay: Document file and functions. ...................................................................... Patch Set 2: (2 comments) Patchset: PS1: > Documenting udelay has made me ask myself if one of the two functions could be deleted in favour of […] I think they should remain two different functions. default_delay is meant to be used for most cases (by programmers, etc), internal_sleep is for some very specific situations. I currently see two programmers using internal_sleep and I am wondering maybe we should refactor them to use default_delay (but I don't know for sure). We also need to ask Peter here, he is expert in delay and did the most recent modernisation of this functions. Patchset: PS2: Peter if you can have a look at this, thank you so much! -- To view, visit https://review.coreboot.org/c/flashrom/+/90746?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I13b514a68c01e1cf8882bdc29a0bb18309722b2d Gerrit-Change-Number: 90746 Gerrit-PatchSet: 2 Gerrit-Owner: Antonio Vázquez Blanco <antoniovazquezblanco(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Antonio Vázquez Blanco <antoniovazquezblanco(a)gmail.com> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Comment-Date: Sat, 17 Jan 2026 08:58:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Antonio Vázquez Blanco <antoniovazquezblanco(a)gmail.com>

1 0

[L] Change in flashrom[main]: serial: Refactor to use consistent naming.
by Anastasia Klimchuk (Code Review) Jan. 17, 2026

Jan. 17, 2026

Attention is currently required from: Antonio Vázquez Blanco, David Reguera Garcia (Dreg). Anastasia Klimchuk has posted comments on this change by Antonio Vázquez Blanco. ( https://review.coreboot.org/c/flashrom/+/90680?usp=email ) Change subject: serial: Refactor to use consistent naming. ...................................................................... Patch Set 3: (4 comments) Commit Message: https://review.coreboot.org/c/flashrom/+/90680/comment/65530e52_c5bce37c?us… : PS3, Line 7: . no dot at the end of commit message, can you check other patches too? thanks! https://review.coreboot.org/c/flashrom/+/90680/comment/4f46dca7_ca9f53a9?us… : PS3, Line 9: serialport, sp and ser Why you picked the longest of all prefixes? sp is the shortest, and most commonly used, sp would need much smaller change. Changing everything to serialport makes code much longer, and lines longer. But sp is a prefix that I think we can consider. https://review.coreboot.org/c/flashrom/+/90680/comment/d84bed23_fa4131e8?us… : PS3, Line 9: The serial API defined functions with the serialport, sp and ser prefixes. : Avoid the mixed naming to consistently use serialport everywhere for consistency. commit message needs to be hard-wrapped by 72 chars, can you check other patches too? File include/serial.h: https://review.coreboot.org/c/flashrom/+/90680/comment/8392df38_68dbc821?us… : PS3, Line 12: fdtype What does 'fd' here stands for? I am also thinking, maybe better leave this type name as is? -- To view, visit https://review.coreboot.org/c/flashrom/+/90680?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I987e315e6605753f964b62b2d0e44235768ca672 Gerrit-Change-Number: 90680 Gerrit-PatchSet: 3 Gerrit-Owner: Antonio Vázquez Blanco <antoniovazquezblanco(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: David Reguera Garcia (Dreg) <regueragarciadavid(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Antonio Vázquez Blanco <antoniovazquezblanco(a)gmail.com> Gerrit-Attention: David Reguera Garcia (Dreg) <regueragarciadavid(a)gmail.com> Gerrit-Comment-Date: Sat, 17 Jan 2026 08:37:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[L] Change in flashrom[main]: platform/endianness: Refactor all endianness related code into a sing...
by Anastasia Klimchuk (Code Review) Jan. 17, 2026

Jan. 17, 2026

Attention is currently required from: Antonio Vázquez Blanco, Nicholas, Peter Marheine, wthai(a)nvidia.com. Anastasia Klimchuk has posted comments on this change by Antonio Vázquez Blanco. ( https://review.coreboot.org/c/flashrom/+/90745?usp=email ) Change subject: platform/endianness: Refactor all endianness related code into a single file. ...................................................................... Patch Set 6: (7 comments) Patchset: PS6: I started reviewing and realised this goes not in the direction that we wanted, look at my comment in meson file first! :) Commit Message: https://review.coreboot.org/c/flashrom/+/90745/comment/dac44b61_7bf42864?us… : PS6, Line 7: . The dot is not needed at the end of commit title (it's always one line) https://review.coreboot.org/c/flashrom/+/90745/comment/76feb289_c8dbf484?us… : PS6, Line 7: platform/endianness: Refactor all endianness related code into a single file. : : Previously, platform endianness was handled in three source files and two header files across three folders. : Now, code has been organized into a single source file and corresponding header file to be contained in the platform/ folder. : Also, simplified meson compilation instructions and documented all header functions in doxygen format. The max width for commit message is 72 chars, you need to hard-wrap this message File include/platform/endianness.h: https://review.coreboot.org/c/flashrom/+/90745/comment/9e1c55bd_da1d91b4?us… : PS6, Line 6: * SPDX-FileCopyrightText: 2022 secunet Security Networks AG (written by Thomas Heijligen <thomas.heijligen(a)secunet.com) There were two different years for this person, I think it should be "2016, 2022" (or what is the canon way to mention two years for the same person) https://review.coreboot.org/c/flashrom/+/90745/comment/c26eeecd_d4d293a4?us… : PS6, Line 20: /** : * \brief Converts an 8-bit unsigned integer from CPU native endianness to little endian. : * \param value The value to convert. : * \return The converted value. : */ When looking at the source file, I like the previous comment style more (more concise, and it was enough to describe the functions). What advantage this verbose style gives? File platform/endianness.c: https://review.coreboot.org/c/flashrom/+/90745/comment/6e5256c6_be3a0fb5?us… : PS6, Line 15: // Byte swapping function definitions. : // Naming has been chosen because OpenBSD has conflicting definitions for swapX, _swap_X and __swapX. : Lets use the usual comment style for functions (// is usually for comments inside code) File platform/meson.build: https://review.coreboot.org/c/flashrom/+/90745/comment/71bc59f5_ea28d23c?us… : PS6, Line 1: srcs += files( : ('endian_' + host_machine.endian() + '.c'), : 'memaccess.c', : ) This is very important comment, lets discuss first. One of the longer term goals is to minimize (or get rid of completely) the pre-processor conditionals in the code, and instead make the decision by the build system (meson). Which is what it is: meson decides which file to include, either endian_big.c or endian_little.c and in the files there are no pre-processor conditionals. The third source memaccess.c contains things that should be included for any endian. This patch goes into the opposite direction from what we want: endianness.c file now introduces new pre-processor macros. So the .c files should stay as they are. When you look at this from the angle of, how to get rid of pre-processor conditionals, would the change for headers be needed? is there any other change you think can get close to the goal? -- To view, visit https://review.coreboot.org/c/flashrom/+/90745?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I0b8a2ea82ea77b0a51f6d80df1f949b4bdf017f8 Gerrit-Change-Number: 90745 Gerrit-PatchSet: 6 Gerrit-Owner: Antonio Vázquez Blanco <antoniovazquezblanco(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Nicholas <nic.c3.14(a)gmail.com> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: wthai(a)nvidia.com Gerrit-Attention: wthai(a)nvidia.com Gerrit-Attention: Antonio Vázquez Blanco <antoniovazquezblanco(a)gmail.com> Gerrit-Attention: Nicholas <nic.c3.14(a)gmail.com> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Comment-Date: Sat, 17 Jan 2026 08:06:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[L] Change in flashrom[main]: platform/endianness: Refactor all endianness related code into a sing...
by Antonio Vázquez Blanco (Code Review) Jan. 16, 2026

Jan. 16, 2026

Attention is currently required from: Anastasia Klimchuk, Nicholas, Peter Marheine, wthai(a)nvidia.com. Antonio Vázquez Blanco has posted comments on this change by Antonio Vázquez Blanco. ( https://review.coreboot.org/c/flashrom/+/90745?usp=email ) Change subject: platform/endianness: Refactor all endianness related code into a single file. ...................................................................... Patch Set 6: (3 comments) Patchset: PS6: Thanks for the review! :D File platform/endianness.c: https://review.coreboot.org/c/flashrom/+/90745/comment/50a54ff3_9b9ec526?us… : PS5, Line 8: * This header file provides functions for endianness conversions between CPU native endianness and little/big endian > ```suggestion […] Fix applied. https://review.coreboot.org/c/flashrom/+/90745/comment/0260e2ed_f9f43955?us… : PS5, Line 144: endiannes > ```suggestion […] Fix applied. -- To view, visit https://review.coreboot.org/c/flashrom/+/90745?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I0b8a2ea82ea77b0a51f6d80df1f949b4bdf017f8 Gerrit-Change-Number: 90745 Gerrit-PatchSet: 6 Gerrit-Owner: Antonio Vázquez Blanco <antoniovazquezblanco(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Nicholas <nic.c3.14(a)gmail.com> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: wthai(a)nvidia.com Gerrit-Attention: wthai(a)nvidia.com Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Nicholas <nic.c3.14(a)gmail.com> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Comment-Date: Fri, 16 Jan 2026 08:27:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Peter Marheine <pmarheine(a)chromium.org>

1 0

[S] Change in flashrom[main]: flashchips: spansion: Add missing FEATURE_WRSR_EXT2
by Anastasia Klimchuk (Code Review) Jan. 15, 2026

Jan. 15, 2026

Anastasia Klimchuk has submitted this change. ( https://review.coreboot.org/c/flashrom/+/90541?usp=email ) Change subject: flashchips: spansion: Add missing FEATURE_WRSR_EXT2 ...................................................................... flashchips: spansion: Add missing FEATURE_WRSR_EXT2 Some of the spansion devices have a status register 2. Add the feature flag so it can be accessed. Change-Id: Ibb7d50d7d5c9915dee1c1dbc92f2a7e573219461 Signed-off-by: Andrew Lunn <andrew(a)lunn.ch> Reviewed-on: https://review.coreboot.org/c/flashrom/+/90541 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Anastasia Klimchuk <aklm(a)chromium.org> --- M flashchips/spansion.c 1 file changed, 5 insertions(+), 5 deletions(-) Approvals: build bot (Jenkins): Verified Anastasia Klimchuk: Looks good to me, approved diff --git a/flashchips/spansion.c b/flashchips/spansion.c index 99ea5b3..9bcc112 100644 --- a/flashchips/spansion.c +++ b/flashchips/spansion.c @@ -401,7 +401,7 @@ .page_size = 256, /* supports 4B addressing */ /* OTP: 1024B total, 32B reserved; read 0x4B; write 0x42 */ - .feature_bits = FEATURE_WRSR_WREN | FEATURE_OTP, + .feature_bits = FEATURE_WRSR_WREN | FEATURE_WRSR_EXT2 | FEATURE_OTP, .tested = TEST_OK_PREW, .probe = PROBE_SPI_RDID, .probe_timing = TIMING_ZERO, @@ -828,7 +828,7 @@ .model_id = SPANSION_S25FL256S_UL, .total_size = 16384, /* This is just half the size.... */ .page_size = 256, - .feature_bits = FEATURE_WRSR_WREN, + .feature_bits = FEATURE_WRSR_WREN | FEATURE_WRSR_EXT2, .tested = TEST_UNTESTED, .probe = PROBE_SPI_BIG_SPANSION, .probe_timing = TIMING_ZERO, @@ -886,7 +886,7 @@ .total_size = 32768, .page_size = 256, /* OTP: 1024B total, 32B reserved; read 0x4B; write 0x42 */ - .feature_bits = FEATURE_WRSR_WREN | FEATURE_OTP | + .feature_bits = FEATURE_WRSR_WREN | FEATURE_WRSR_EXT2 | FEATURE_OTP | FEATURE_4BA_NATIVE | FEATURE_4BA_ENTER_EAR7 | FEATURE_4BA_EAR_1716, .tested = TEST_OK_PREW, .probe = PROBE_SPI_RDID, @@ -932,7 +932,7 @@ .total_size = 65536, /* 512 Mb (=> 64 MB)) */ .page_size = 256, /* OTP: 1024B total, 32B reserved; read 0x4B; write 0x42 */ - .feature_bits = FEATURE_WRSR_WREN | FEATURE_OTP | + .feature_bits = FEATURE_WRSR_WREN | FEATURE_WRSR_EXT2 | FEATURE_OTP | FEATURE_4BA_NATIVE | FEATURE_4BA_ENTER_EAR7 | FEATURE_4BA_EAR_1716, .tested = TEST_UNTESTED, .probe = PROBE_SPI_BIG_SPANSION, @@ -1031,7 +1031,7 @@ .total_size = 65536, .page_size = 256, /* 256 or 512 bytes page programming buffer */ /* OTP: 1024B total, 32B reserved; read 0x4B; write 0x42 */ - .feature_bits = FEATURE_WRSR_WREN | FEATURE_OTP | FEATURE_QPI | + .feature_bits = FEATURE_WRSR_WREN | FEATURE_WRSR_EXT2 | FEATURE_OTP | FEATURE_QPI | FEATURE_4BA_NATIVE | FEATURE_4BA_ENTER, /* Note on FEATURE_4BA_ENTER: the command set only defines command 0xB7 to enter 4BA mode, but there is no counterpart command "Exit 4BA mode", -- To view, visit https://review.coreboot.org/c/flashrom/+/90541?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Ibb7d50d7d5c9915dee1c1dbc92f2a7e573219461 Gerrit-Change-Number: 90541 Gerrit-PatchSet: 3 Gerrit-Owner: Andrew Lunn <andrew(a)lunn.ch> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[L] Change in flashrom[main]: platform/endianness: Refactor all endianness related code into a sing...
by Peter Marheine (Code Review) Jan. 15, 2026

Jan. 15, 2026

Attention is currently required from: Anastasia Klimchuk, Antonio Vázquez Blanco, Nicholas, wthai(a)nvidia.com. Peter Marheine has posted comments on this change by Antonio Vázquez Blanco. ( https://review.coreboot.org/c/flashrom/+/90745?usp=email ) Change subject: platform/endianness: Refactor all endianness related code into a single file. ...................................................................... Patch Set 5: Code-Review+2 (2 comments) File platform/endianness.c: https://review.coreboot.org/c/flashrom/+/90745/comment/94354f6c_8154bd58?us… : PS5, Line 8: * This header file provides functions for endianness conversions between CPU native endianness and little/big endian ```suggestion * This file provides functions for endianness conversions between CPU native endianness and little/big endian ``` https://review.coreboot.org/c/flashrom/+/90745/comment/bbdcb46a_f491216d?us… : PS5, Line 144: endiannes ```suggestion #error Endiannes was not defined before compiling endianness.c! ``` -- To view, visit https://review.coreboot.org/c/flashrom/+/90745?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I0b8a2ea82ea77b0a51f6d80df1f949b4bdf017f8 Gerrit-Change-Number: 90745 Gerrit-PatchSet: 5 Gerrit-Owner: Antonio Vázquez Blanco <antoniovazquezblanco(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Nicholas <nic.c3.14(a)gmail.com> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: wthai(a)nvidia.com Gerrit-Attention: wthai(a)nvidia.com Gerrit-Attention: Antonio Vázquez Blanco <antoniovazquezblanco(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Nicholas <nic.c3.14(a)gmail.com> Gerrit-Comment-Date: Thu, 15 Jan 2026 22:30:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[S] Change in flashrom[main]: dmi.h: Extract DMI declarations to a separate header
by Antonio Vázquez Blanco (Code Review) Jan. 15, 2026

Jan. 15, 2026

Attention is currently required from: Anastasia Klimchuk. Hello Anastasia Klimchuk, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/90632?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: dmi.h: Extract DMI declarations to a separate header ...................................................................... dmi.h: Extract DMI declarations to a separate header This patch moves all the declarations relevant to dmi into their own header in include/dmi.h. The corresponding functions implementations are already in dmi.c, so the declarations naturally can be in dmi.h Currently, most of the declarations reside in programmer.h making it difficult to really understand file dependency. Change-Id: I5fcb14da0b7f478a4f6badc8929c8389a5fa3e3c Signed-off-by: Antonio Vázquez <antoniovazquezblanco(a)gmail.com> --- M board_enable.c M dmi.c A include/dmi.h M include/programmer.h M programmers/internal.c 5 files changed, 26 insertions(+), 7 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/32/90632/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/90632?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I5fcb14da0b7f478a4f6badc8929c8389a5fa3e3c Gerrit-Change-Number: 90632 Gerrit-PatchSet: 2 Gerrit-Owner: Antonio Vázquez Blanco <antoniovazquezblanco(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org>

1 0

[L] Change in flashrom[main]: serial: Refactor to use consistent naming.
by Antonio Vázquez Blanco (Code Review) Jan. 15, 2026

Jan. 15, 2026

Attention is currently required from: Anastasia Klimchuk, David Reguera Garcia (Dreg). Hello Anastasia Klimchuk, David Reguera Garcia (Dreg), build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/90680?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: serial: Refactor to use consistent naming. ...................................................................... serial: Refactor to use consistent naming. The serial API defined functions with the serialport, sp and ser prefixes. Avoid the mixed naming to consistently use serialport everywhere for consistency. Change-Id: I987e315e6605753f964b62b2d0e44235768ca672 Signed-off-by: Antonio Vázquez Blanco <antoniovazquezblanco(a)gmail.com> --- M include/serial.h M programmers/buspirate_spi.c M programmers/pony_spi.c M programmers/serprog.c M programmers/spidriver.c M serial.c 6 files changed, 263 insertions(+), 263 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/80/90680/3 -- To view, visit https://review.coreboot.org/c/flashrom/+/90680?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I987e315e6605753f964b62b2d0e44235768ca672 Gerrit-Change-Number: 90680 Gerrit-PatchSet: 3 Gerrit-Owner: Antonio Vázquez Blanco <antoniovazquezblanco(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: David Reguera Garcia (Dreg) <regueragarciadavid(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: David Reguera Garcia (Dreg) <regueragarciadavid(a)gmail.com>

1 0

[L] Change in flashrom[main]: platform/endianness: Refactor all endianness related code into a sing...
by Antonio Vázquez Blanco (Code Review) Jan. 15, 2026

Jan. 15, 2026

Attention is currently required from: Anastasia Klimchuk, Nicholas, Peter Marheine, wthai(a)nvidia.com. Hello Anastasia Klimchuk, Nicholas, Peter Marheine, build bot (Jenkins), wthai(a)nvidia.com, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/90745?usp=email to look at the new patch set (#5). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: platform/endianness: Refactor all endianness related code into a single file. ...................................................................... platform/endianness: Refactor all endianness related code into a single file. Previously, platform endianness was handled in three source files and two header files across three folders. Now, code has been organized into a single source file and corresponding header file to be contained in the platform/ folder. Also, simplified meson compilation instructions and documented all header functions in doxygen format. Change-Id: I0b8a2ea82ea77b0a51f6d80df1f949b4bdf017f8 Signed-off-by: Antonio Vázquez Blanco <antoniovazquezblanco(a)gmail.com> --- M hwaccess_physmap.c D include/platform.h A include/platform/endianness.h D include/platform/swap.h D platform/endian_big.c D platform/endian_little.c A platform/endianness.c D platform/memaccess.c M platform/meson.build M programmers/ch347_spi.c M programmers/nv_sma_spi.c 11 files changed, 349 insertions(+), 237 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/45/90745/5 -- To view, visit https://review.coreboot.org/c/flashrom/+/90745?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I0b8a2ea82ea77b0a51f6d80df1f949b4bdf017f8 Gerrit-Change-Number: 90745 Gerrit-PatchSet: 5 Gerrit-Owner: Antonio Vázquez Blanco <antoniovazquezblanco(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Nicholas <nic.c3.14(a)gmail.com> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: wthai(a)nvidia.com Gerrit-Attention: wthai(a)nvidia.com Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Nicholas <nic.c3.14(a)gmail.com> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org>

1 0