Change in flashrom[master]: Fixed mingw detection on Windows 7 (NT-6.1) and hopefully in another ... - flashrom-gerrit

28 Feb 2018


      Márton Miklós has posted comments on this change. ( https://review.coreboot.org/23865 )
Change subject: Fixed mingw detection on Windows 7 (NT-6.1) and hopefully in another non XP Windows build environments too.
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/23865/1/Makefile
File Makefile:
https://review.coreboot.org/#/c/23865/1/Makefile@104
PS1, Line 104: ifeq ($(shell if  [[ $$(uname) =~ ^MINGW[0-9]{0,2}_NT-[0-9]{1,2}.[0-9]{1,2}$$ ]]; then echo yes; else echo no; fi), yes)
...
I'm not familiar with the syntax. […]
Kind of. It is a regexp check inspired by this:
https://stackoverflow.com/questions/31111360/how-to-use-regular-expression-i...
-- 
To view, visit https://review.coreboot.org/23865
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7f856dc4847c4ca9197b1935b7a9b9071b46c70a
Gerrit-Change-Number: 23865
Gerrit-PatchSet: 1
Gerrit-Owner: David Hendricks david.hendricks@gmail.com
Gerrit-Reviewer: Miklós Márton martonmiklosqdev@gmail.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Márton Miklós martonmiklosqdev@gmail.com
Gerrit-Comment-Date: Wed, 28 Feb 2018 19:21:06 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No