Attention is currently required from: Aarya, Alexander Goncharov, Sam McNally.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/77747?usp=email )
Change subject: erasure_layout: Fix double invocation of erasers ......................................................................
Patch Set 4:
(1 comment)
Patchset:
PS3:
I still encounter an error. Added comments and logs in the issue tracker.
Thank you! I added one comment to the ticket. If you give me the images I can debug too!
I think these are two different issues. The issue this patch is solving is that every block was erased twice: but the end result was correct, so end user would not notice the issues (and verification works too).
While I think there are two different issues, I would debug yours as well before deciding to submit this one: just in case.
In general, this patch is useful, and also the next one (unit test), I would really want to get it through and have the test running on jenkins.
-
Anastasia Klimchuk (Code Review)