September 2023 - flashrom-gerrit

[L] Change in flashrom[main]: doc: Convert write-protect docs to sphinx
by Anastasia Klimchuk (Code Review) 28 Sep '23

28 Sep '23

Attention is currently required from: Sergii Dmytruk, Thomas Heijligen. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/78113?usp=email ) Change subject: doc: Convert write-protect docs to sphinx ...................................................................... Patch Set 2: (3 comments) File doc/user_docs/example_partial_wp.rst: https://review.coreboot.org/c/flashrom/+/78113/comment/987e0838_af9d1098 : PS1, Line 102: control > `(sector/block-based)` can be added after `control` because I had to pause for a moment to recall wh […] Done https://review.coreboot.org/c/flashrom/+/78113/comment/ba907179_c1dcf521 : PS1, Line 103: 4 November 2022 > Block-based write-protection isn't supported as of today, so the date can be updated accordingly. Done File doc/user_docs/fw_updates_vs_spi_wp.rst: https://review.coreboot.org/c/flashrom/+/78113/comment/93c1d6f9_69860ad7 : PS1, Line 62: 4 November 2022) > CB:69517 changed the behaviour to use WP code and and then old implementation as a fallback. […] I removed the paragraph. The change CB:69517 is not a part of v1.3. But I am hoping to get some help from other people and a piece of good luck and be able to do another release this year :) -- To view, visit https://review.coreboot.org/c/flashrom/+/78113?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I223f1aa5f4531b28b04bcfcecd9becfa7899c3d9 Gerrit-Change-Number: 78113 Gerrit-PatchSet: 2 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Comment-Date: Thu, 28 Sep 2023 08:48:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-MessageType: comment

1 0

[L] Change in flashrom[main]: doc: Convert write-protect docs to sphinx
by Anastasia Klimchuk (Code Review) 28 Sep '23

28 Sep '23

Attention is currently required from: Anastasia Klimchuk, Sergii Dmytruk, Thomas Heijligen. Hello Sergii Dmytruk, Thomas Heijligen, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/78113?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+2 by Sergii Dmytruk, Verified+1 by build bot (Jenkins) Change subject: doc: Convert write-protect docs to sphinx ...................................................................... doc: Convert write-protect docs to sphinx Updated the information that WP is included in the v1.3 release, and added links to dev guidelines on how to build from head (instead of inlining the instructions). Change-Id: I223f1aa5f4531b28b04bcfcecd9becfa7899c3d9 Signed-off-by: Anastasia Klimchuk <aklm(a)flashrom.org> --- M doc/index.rst A doc/user_docs/example_partial_wp.rst A doc/user_docs/fw_updates_vs_spi_wp.rst A doc/user_docs/index.rst 4 files changed, 260 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/13/78113/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/78113?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I223f1aa5f4531b28b04bcfcecd9becfa7899c3d9 Gerrit-Change-Number: 78113 Gerrit-PatchSet: 2 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-MessageType: newpatchset

1 0

[XS] Change in flashrom[main]: doc: Fix formatting for the example of commit message
by Alexander Goncharov (Code Review) 27 Sep '23

27 Sep '23

Attention is currently required from: Anastasia Klimchuk, Peter Marheine, Thomas Heijligen. Alexander Goncharov has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/78120?usp=email ) Change subject: doc: Fix formatting for the example of commit message ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/78120?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: If0bc8327e973d9bc9a93eea38c83bfab412fb8f4 Gerrit-Change-Number: 78120 Gerrit-PatchSet: 1 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Comment-Date: Wed, 27 Sep 2023 16:04:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in flashrom[main]: doc: Convert release notes for v1.3
by Alexander Goncharov (Code Review) 27 Sep '23

27 Sep '23

Attention is currently required from: Anastasia Klimchuk, Thomas Heijligen. Alexander Goncharov has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/78116?usp=email ) Change subject: doc: Convert release notes for v1.3 ...................................................................... Patch Set 1: Code-Review+2 (2 comments) File doc/release_notes/v_1_3.rst: https://review.coreboot.org/c/flashrom/+/78116/comment/7537ee9c_86a97196 : PS1, Line 106: :code:`libftdi1, libjaylink, libusb1, libpci` ``` :code:`libftdi1`, :code:`libjaylink`, :code:`libusb1`, :code:`libpci` ``` https://review.coreboot.org/c/flashrom/+/78116/comment/818cc36d_ba5538a6 : PS1, Line 108: :code:`compiler, hwlibs, features` ``` :code:`compiler`, :code:`hwlibs`, :code:`features` ``` -- To view, visit https://review.coreboot.org/c/flashrom/+/78116?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I5b66a957249c3025715eff2b00f1be9eb0d36096 Gerrit-Change-Number: 78116 Gerrit-PatchSet: 1 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Wed, 27 Sep 2023 15:45:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in flashrom[main]: flashchips: Test MXIC MX25U25643G wp
by rogeryou (Code Review) 27 Sep '23

27 Sep '23

Attention is currently required from: Anastasia Klimchuk, Nikolai Artemiev, Stefan Reinauer. Hello Anastasia Klimchuk, Nikolai Artemiev, Stefan Reinauer, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/78142?usp=email to look at the new patch set (#2). Change subject: flashchips: Test MXIC MX25U25643G wp ...................................................................... flashchips: Test MXIC MX25U25643G wp The MX25U25643G has a WPSEL bit in the security register, but the MX25U25635F does not. Therefore, take them apart. The MX25U25643G has been tested by ch341a programmer : read, write, erase and wp. MX25U25643G datasheet is available at the following URL: https://www.mxic.com.tw/en-us/products/NOR-Flash/Serial-NOR-Flash/Pages/spe… MX25U25635F datasheet is available at the following URL: https://www.macronix.com/en-us/products/NOR-Flash/Serial-NOR-Flash/Pages/sp… Change-Id: I43de9ed123b9736c04d070754bcf9c32be5697ad Signed-off-by: rogeryou <rogeryou(a)mxic.com.cn> --- M flashchips.c 1 file changed, 58 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/42/78142/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/78142?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I43de9ed123b9736c04d070754bcf9c32be5697ad Gerrit-Change-Number: 78142 Gerrit-PatchSet: 2 Gerrit-Owner: rogeryou Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

[M] Change in flashrom[main]: flashchips: Test MXIC MX25U25643G wp
by rogeryou (Code Review) 27 Sep '23

27 Sep '23

rogeryou has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/78142?usp=email ) Change subject: flashchips: Test MXIC MX25U25643G wp ...................................................................... flashchips: Test MXIC MX25U25643G wp The MX25U25643G has a WPSEL bit in the security register, but the MX25U25635F does not. Therefore, take them apart. The MX25U25643G has been tested by ch341a programmer : read, write, erase and wp. MX25U25643G datasheet is available at the following URL: https://www.mxic.com.tw/en-us/products/NOR-Flash/Serial-NOR-Flash/Pages/spe… MX25U25635F datasheet is available at the following URL: https://www.macronix.com/en-us/products/NOR-Flash/Serial-NOR-Flash/Pages/sp… Change-Id: I43de9ed123b9736c04d070754bcf9c32be5697ad Signed-off-by: rogeryou <rogeryou(a)mxic.com.cn> --- M flashchips.c 1 file changed, 58 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/42/78142/1 diff --git a/flashchips.c b/flashchips.c index 26decb1..ae97d3f 100644 --- a/flashchips.c +++ b/flashchips.c @@ -10207,7 +10207,7 @@ { .vendor = "Macronix", - .name = "MX25U25635F/MX25U25643G", + .name = "MX25U25635F", .bustype = BUS_SPI, .manufacture_id = MACRONIX_ID, .model_id = MACRONIX_MX25U25635F, @@ -10256,6 +10256,63 @@ { .vendor = "Macronix", + .name = "MX25U25643G", + .bustype = BUS_SPI, + .manufacture_id = MACRONIX_ID, + .model_id = MACRONIX_MX25U25635F, + .total_size = 32768, + .page_size = 256, + /* OTP: 512B total; enter 0xB1, exit 0xC1 */ + .feature_bits = FEATURE_WRSR_WREN | FEATURE_OTP | FEATURE_QPI | FEATURE_4BA | FEATURE_WRSR2 | FEATURE_SCUR, + .tested = TEST_OK_PREWB, + .probe = PROBE_SPI_RDID, + .probe_timing = TIMING_ZERO, + .block_erasers = + { + { + .eraseblocks = { {4 * 1024, 8192} }, + .block_erase = SPI_BLOCK_ERASE_21, + }, { + .eraseblocks = { {4 * 1024, 8192} }, + .block_erase = SPI_BLOCK_ERASE_20, + }, { + .eraseblocks = { {32 * 1024, 1024} }, + .block_erase = SPI_BLOCK_ERASE_5C, + }, { + .eraseblocks = { {32 * 1024, 1024} }, + .block_erase = SPI_BLOCK_ERASE_52, + }, { + .eraseblocks = { {64 * 1024, 512} }, + .block_erase = SPI_BLOCK_ERASE_DC, + }, { + .eraseblocks = { {64 * 1024, 512} }, + .block_erase = SPI_BLOCK_ERASE_D8, + }, { + .eraseblocks = { {32 * 1024 * 1024, 1} }, + .block_erase = SPI_BLOCK_ERASE_60, + }, { + .eraseblocks = { {32 * 1024 * 1024, 1} }, + .block_erase = SPI_BLOCK_ERASE_C7, + } + }, + /* TODO: security register */ + .printlock = SPI_PRETTYPRINT_STATUS_REGISTER_BP3_SRWD, /* bit6 is quad enable */ + .unlock = SPI_DISABLE_BLOCKPROTECT_BP3_SRWD, + .write = SPI_CHIP_WRITE256, /* Multi I/O supported */ + .read = SPI_CHIP_READ, /* Fast read (0x0B) and multi I/O supported */ + .voltage = {1650, 2000}, + .reg_bits = + { + .srp = {STATUS1, 7, RW}, + .bp = {{STATUS1, 2, RW}, {STATUS1, 3, RW}, {STATUS1, 4, RW}, {STATUS1, 5, RW}}, + .tb = {CONFIG, 3, OTP}, + .wps = {SECURITY, 7, OTP}, /* This bit is set by WPSEL command */ + }, + .decode_range = DECODE_RANGE_SPI25, + }, + + { + .vendor = "Macronix", .name = "MX25U3235E/F", .bustype = BUS_SPI, .manufacture_id = MACRONIX_ID, -- To view, visit https://review.coreboot.org/c/flashrom/+/78142?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I43de9ed123b9736c04d070754bcf9c32be5697ad Gerrit-Change-Number: 78142 Gerrit-PatchSet: 1 Gerrit-Owner: rogeryou Gerrit-MessageType: newchange

1 0

[M] Change in flashrom[main]: flashchips: add WP features for W25X* analogous to tested W25X20
by Nikolai Artemiev (Code Review) 27 Sep '23

27 Sep '23

Attention is currently required from: Sergii Dmytruk, Vasily Galkin. Nikolai Artemiev has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/77531?usp=email ) Change subject: flashchips: add WP features for W25X* analogous to tested W25X20 ...................................................................... Patch Set 6: Code-Review+2 (1 comment) File flashchips.c: https://review.coreboot.org/c/flashrom/+/77531/comment/051d6332_e44cb398 : PS3, Line 19730: .decode_range = DECODE_RANGE_SPI25, > I can't be 100% sure since only the W25X20 from this series was phisycally tested, but according to […] Thanks Vasily, that looks good. I'm happy to leave it there, but if you want to check the exact range <-> status register bit mappings, you can use `flashrom --wp-list --VVV | grep "Enumerated range"`. -- To view, visit https://review.coreboot.org/c/flashrom/+/77531?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Ie69660a6f69e3cac31c5565792f401e69d43f8b8 Gerrit-Change-Number: 77531 Gerrit-PatchSet: 6 Gerrit-Owner: Vasily Galkin Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Vasily Galkin Gerrit-Attention: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Comment-Date: Wed, 27 Sep 2023 00:10:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Vasily Galkin Comment-In-Reply-To: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-MessageType: comment

1 0

[XS] Change in flashrom[main]: doc: Fix formatting for the example of commit message
by Patrick Georgi (Code Review) 26 Sep '23

26 Sep '23

Attention is currently required from: Anastasia Klimchuk, Thomas Heijligen. Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/78120?usp=email ) Change subject: doc: Fix formatting for the example of commit message ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/flashrom/+/78120?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: If0bc8327e973d9bc9a93eea38c83bfab412fb8f4 Gerrit-Change-Number: 78120 Gerrit-PatchSet: 1 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Tue, 26 Sep 2023 13:01:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in flashrom[main]: doc: Fix formatting for the example of commit message
by Anastasia Klimchuk (Code Review) 26 Sep '23

26 Sep '23

Anastasia Klimchuk has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/78120?usp=email ) Change subject: doc: Fix formatting for the example of commit message ...................................................................... doc: Fix formatting for the example of commit message Example of commit message was formatted with code-block directive which has language argument required or optional depending on the sphinx version. Replace code-block with simpler literal block which never has arguments, and also since the text formatted is not actually a code. Change-Id: If0bc8327e973d9bc9a93eea38c83bfab412fb8f4 Signed-off-by: Anastasia Klimchuk <aklm(a)flashrom.org> --- M doc/dev_guide/development_guide.rst 1 file changed, 1 insertion(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/20/78120/1 diff --git a/doc/dev_guide/development_guide.rst b/doc/dev_guide/development_guide.rst index bdbee37..60c5625 100644 --- a/doc/dev_guide/development_guide.rst +++ b/doc/dev_guide/development_guide.rst @@ -51,9 +51,7 @@ Commit message -------------- -Commit messages shall have the following format: - -.. code-block:: +Commit messages shall have the following format:: <component>: Short description (up to 72 characters) -- To view, visit https://review.coreboot.org/c/flashrom/+/78120?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: If0bc8327e973d9bc9a93eea38c83bfab412fb8f4 Gerrit-Change-Number: 78120 Gerrit-PatchSet: 1 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: newchange

1 0

[M] Change in flashrom[main]: doc: Convert release notes for v1.3
by Anastasia Klimchuk (Code Review) 25 Sep '23

25 Sep '23

Attention is currently required from: Alexander Goncharov, Thomas Heijligen. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/78116?usp=email ) Change subject: doc: Convert release notes for v1.3 ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: The same content as on wiki, I only re-formatted to rst. -- To view, visit https://review.coreboot.org/c/flashrom/+/78116?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I5b66a957249c3025715eff2b00f1be9eb0d36096 Gerrit-Change-Number: 78116 Gerrit-PatchSet: 1 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Comment-Date: Mon, 25 Sep 2023 13:02:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit September 2023