September 2023 - flashrom-gerrit

[S] Change in flashrom[main]: tree: Rename master branch to main
by Stefan Reinauer (Code Review) 24 Sep '23

24 Sep '23

Attention is currently required from: Anastasia Klimchuk, Patrick Georgi, Thomas Heijligen. Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/75706?usp=email ) Change subject: tree: Rename master branch to main ...................................................................... Patch Set 2: Verified+1 -- To view, visit https://review.coreboot.org/c/flashrom/+/75706?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I8f4a377735f3f6ab4a22006949ff294a218bdf22 Gerrit-Change-Number: 75706 Gerrit-PatchSet: 2 Gerrit-Owner: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Sun, 24 Sep 2023 23:15:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in flashrom[main]: tree: Rename master branch to main
by Anastasia Klimchuk (Code Review) 24 Sep '23

24 Sep '23

Attention is currently required from: Patrick Georgi, Stefan Reinauer, Thomas Heijligen. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/75706?usp=email ) Change subject: tree: Rename master branch to main ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/75706?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I8f4a377735f3f6ab4a22006949ff294a218bdf22 Gerrit-Change-Number: 75706 Gerrit-PatchSet: 2 Gerrit-Owner: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Comment-Date: Sun, 24 Sep 2023 23:13:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in flashrom[main]: tree: Rename master branch to main
by Stefan Reinauer (Code Review) 24 Sep '23

24 Sep '23

Attention is currently required from: Anastasia Klimchuk, Patrick Georgi, Thomas Heijligen. Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/75706?usp=email ) Change subject: tree: Rename master branch to main ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: > I think this patch can be reviewed/approved now, but it needs to be submitted only after the branch […] Done -- To view, visit https://review.coreboot.org/c/flashrom/+/75706?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I8f4a377735f3f6ab4a22006949ff294a218bdf22 Gerrit-Change-Number: 75706 Gerrit-PatchSet: 2 Gerrit-Owner: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Sun, 24 Sep 2023 23:11:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: layout: Change signature for prepare_layout_for_extraction
by Stefan Reinauer (Code Review) 24 Sep '23

24 Sep '23

Attention is currently required from: Anastasia Klimchuk, Angel Pons, Nico Huber, Nikolai Artemiev. Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62554?usp=email ) Change subject: layout: Change signature for prepare_layout_for_extraction ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: > > Thanks for reply! :) […] Done -- To view, visit https://review.coreboot.org/c/flashrom/+/62554?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I7d3874d1097bb0d7bb8d9fa8e639cc1e71407627 Gerrit-Change-Number: 62554 Gerrit-PatchSet: 2 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Comment-Date: Sun, 24 Sep 2023 22:11:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: comment

1 0

[XS] Change in flashrom[refs/meta/config]: Review access change
by Stefan Reinauer (Code Review) 24 Sep '23

24 Sep '23

Stefan Reinauer has abandoned this change. ( https://review.coreboot.org/c/flashrom/+/78143?usp=email ) Change subject: Review access change ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/flashrom/+/78143?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: refs/meta/config Gerrit-Change-Id: I7d357c4cdffe9667060bb6d58cc2e2ac4b913cde Gerrit-Change-Number: 78143 Gerrit-PatchSet: 1 Gerrit-Owner: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

[XS] Change in flashrom[refs/meta/config]: Review access change
by Stefan Reinauer (Code Review) 24 Sep '23

24 Sep '23

Attention is currently required from: Stefan Reinauer. Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/78143?usp=email ) Change subject: Review access change ...................................................................... Patch Set 1: Code-Review+2 Verified+1 -- To view, visit https://review.coreboot.org/c/flashrom/+/78143?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: refs/meta/config Gerrit-Change-Id: I7d357c4cdffe9667060bb6d58cc2e2ac4b913cde Gerrit-Change-Number: 78143 Gerrit-PatchSet: 1 Gerrit-Owner: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Comment-Date: Sun, 24 Sep 2023 21:37:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in flashrom[refs/meta/config]: Review access change
by Stefan Reinauer (Code Review) 24 Sep '23

24 Sep '23

Stefan Reinauer has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/78143?usp=email ) Change subject: Review access change ...................................................................... Review access change Change-Id: I7d357c4cdffe9667060bb6d58cc2e2ac4b913cde --- M project.config 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/43/78143/1 diff --git a/project.config b/project.config index 07509f2..9cdafcb 100644 --- a/project.config +++ b/project.config @@ -47,6 +47,7 @@ owner = group user/Stefan Reinauer (stepan) owner = group user/build bot (Jenkins) (jenkins) read = block group user/Nico Huber (Nico) + abandon = group user/Stefan Reinauer (stepan) [access "refs/heads/*"] exclusiveGroupPermissions = create delete label-Code-Review submit create = group user/Anastasia Klimchuk (aklm) -- To view, visit https://review.coreboot.org/c/flashrom/+/78143?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: refs/meta/config Gerrit-Change-Id: I7d357c4cdffe9667060bb6d58cc2e2ac4b913cde Gerrit-Change-Number: 78143 Gerrit-PatchSet: 1 Gerrit-Owner: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-MessageType: newchange

1 0

[L] Change in flashrom[master]: tests: Unit tests for erase function selection algo
by Anastasia Klimchuk (Code Review) 22 Sep '23

22 Sep '23

Attention is currently required from: Aarya, Edward O'Callaghan, Nikolai Artemiev, Simon Buhrow, Thomas Heijligen. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/67535?usp=email ) Change subject: tests: Unit tests for erase function selection algo ...................................................................... Patch Set 14: (3 comments) File tests/erase_func_algo.c: https://review.coreboot.org/c/flashrom/+/67535/comment/d9f30ef6_29ab7dad : PS3, Line 238: void **state > I will check cmocka docs how to do it, keep this unresolved for now. I found something in cmocka docs, around this page https://api.cmocka.org/group__cmocka__exec.html#gaaccacc105038e49462888a3ed… They way to set this state is to implement setup function, but also it needs to be passed to cmocka_unit_test_X creation function which we have in tests.c. But that means setup needs to be visible in tests.c, which means introducing headers for setup function? Isn't it leaking internal test details to tests' main function? Another thing is that I wanted to move g_state to its separate file at some point later (probably not in the first version of the test) so that it can grow large. I don't mind adding twice more meaningful test cases to the list, but this better be in the separate file. With all that, do you think we can keep it as is for now? https://review.coreboot.org/c/flashrom/+/67535/comment/069093f7_cbb4f4fe : PS3, Line 276: void **state > ditto. other comment has the question File tests/erase_func_algo.c: https://review.coreboot.org/c/flashrom/+/67535/comment/551874f9_bb4375ee : PS5, Line 183: ) > We can reduce global state by passing the test case as an argument here, i.e. […] Done -- To view, visit https://review.coreboot.org/c/flashrom/+/67535?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I8f3fdefb76e71f6f8dc295d9dead5f38642aace7 Gerrit-Change-Number: 67535 Gerrit-PatchSet: 14 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Aarya <aarya.chaumal(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Simon Buhrow Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Alexander Goncharov <chat(a)joursoir.net> Gerrit-CC: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Attention: Simon Buhrow Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Aarya <aarya.chaumal(a)gmail.com> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Comment-Date: Fri, 22 Sep 2023 13:17:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Edward O'Callaghan <quasisec(a)chromium.org> Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Comment-In-Reply-To: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-MessageType: comment

1 0

[L] Change in flashrom[master]: tests: Unit tests for erase function selection algo
by Anastasia Klimchuk (Code Review) 22 Sep '23

22 Sep '23

Attention is currently required from: Aarya, Edward O'Callaghan, Nikolai Artemiev, Simon Buhrow, Thomas Heijligen. Hello Aarya, Edward O'Callaghan, Simon Buhrow, Thomas Heijligen, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/67535?usp=email to look at the new patch set (#14). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: tests: Unit tests for erase function selection algo ...................................................................... tests: Unit tests for erase function selection algo The test checks that algorithm for erase functions selection works and there are no regressions. Specifically, test contains an array of test cases. Each case initialises a given initial state of the memory for the mock chip, and layout regions on the chip, and then performs erase and write operations. At the end of operation, test asserts the following: - the state of mock chip memory is as expected, i.e. properly erased or written - erase blocks are invoked in expected order and expected number of them - chip operation (erase or write) returned 0. Change-Id: I8f3fdefb76e71f6f8dc295d9dead5f38642aace7 Signed-off-by: Anastasia Klimchuk <aklm(a)flashrom.org> --- A tests/erase_func_algo.c M tests/meson.build M tests/tests.c M tests/tests.h 4 files changed, 683 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/35/67535/14 -- To view, visit https://review.coreboot.org/c/flashrom/+/67535?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I8f3fdefb76e71f6f8dc295d9dead5f38642aace7 Gerrit-Change-Number: 67535 Gerrit-PatchSet: 14 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Aarya <aarya.chaumal(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Simon Buhrow Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Alexander Goncharov <chat(a)joursoir.net> Gerrit-CC: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Attention: Simon Buhrow Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Aarya <aarya.chaumal(a)gmail.com> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-MessageType: newpatchset

1 0

[XS] Change in flashrom[master]: flashchips: Mark Atmel AT29C010A chip as tested for write operation
by Anastasia Klimchuk (Code Review) 22 Sep '23

22 Sep '23

Anastasia Klimchuk has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/78069?usp=email ) Change subject: flashchips: Mark Atmel AT29C010A chip as tested for write operation ...................................................................... flashchips: Mark Atmel AT29C010A chip as tested for write operation As reported on the mailing list in https://mail.coreboot.org/hyperkitty/list/flashrom@flashrom.org/thread/4BU4… Change-Id: I267ed5583e8a9bad0b34b12d73ab2928d65144eb Signed-off-by: Anastasia Klimchuk <aklm(a)flashrom.org> --- M flashchips.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/69/78069/1 diff --git a/flashchips.c b/flashchips.c index 26decb1..44b0b31 100644 --- a/flashchips.c +++ b/flashchips.c @@ -2685,7 +2685,7 @@ .total_size = 128, .page_size = 128, .feature_bits = FEATURE_LONG_RESET, - .tested = TEST_OK_PRE, + .tested = TEST_OK_PREW, .probe = PROBE_JEDEC, .probe_timing = 10000, /* 10mS, Enter=Exec */ .block_erasers = -- To view, visit https://review.coreboot.org/c/flashrom/+/78069?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I267ed5583e8a9bad0b34b12d73ab2928d65144eb Gerrit-Change-Number: 78069 Gerrit-PatchSet: 1 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: newchange

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit September 2023