September 2023 - flashrom-gerrit

[S] Change in flashrom[master]: tree: Rename master branch to main
by Anastasia Klimchuk (Code Review) 18 Sep '23

18 Sep '23

Attention is currently required from: Patrick Georgi, Stefan Reinauer, Thomas Heijligen. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/75706?usp=email ) Change subject: tree: Rename master branch to main ...................................................................... Patch Set 2: (3 comments) Commit Message: https://review.coreboot.org/c/flashrom/+/75706/comment/025bde69_3c175823 : PS1, Line 7: Switch over master branch to main > Rename master branch to main […] Done Patchset: PS1: > Here are new Dev guidelines! CB:75906 :) I updated dev guide and uploaded new patchset. Patchset: PS2: I think this patch can be reviewed/approved now, but it needs to be submitted only after the branch is actually renamed (ideally as soon as possible after the renaming). -- To view, visit https://review.coreboot.org/c/flashrom/+/75706?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I8f4a377735f3f6ab4a22006949ff294a218bdf22 Gerrit-Change-Number: 75706 Gerrit-PatchSet: 2 Gerrit-Owner: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Comment-Date: Mon, 18 Sep 2023 11:01:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: tree: Rename master branch to main
by Anastasia Klimchuk (Code Review) 18 Sep '23

18 Sep '23

Attention is currently required from: Stefan Reinauer. Anastasia Klimchuk has uploaded a new patch set (#2) to the change originally created by Stefan Reinauer. ( https://review.coreboot.org/c/flashrom/+/75706?usp=email ) The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: tree: Rename master branch to main ...................................................................... tree: Rename master branch to main Change-Id: I8f4a377735f3f6ab4a22006949ff294a218bdf22 Signed-off-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Signed-off-by: Anastasia Klimchuk <aklm(a)flashrom.org> --- M doc/dev_guide/development_guide.rst M util/manibuilder/Makefile M util/manibuilder/README.md 3 files changed, 5 insertions(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/06/75706/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/75706?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I8f4a377735f3f6ab4a22006949ff294a218bdf22 Gerrit-Change-Number: 75706 Gerrit-PatchSet: 2 Gerrit-Owner: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

[XS] Change in flashrom[testpush]: flashchips: Add support for MXIC MX25U25643G
by Anastasia Klimchuk (Code Review) 18 Sep '23

18 Sep '23

Attention is currently required from: Name of user not set #1005084, Nikolai Artemiev, Stefan Reinauer. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/77581?usp=email ) Change subject: flashchips: Add support for MXIC MX25U25643G ...................................................................... Patch Set 4: (1 comment) Patchset: PS4: xianzheng, CB:76853 already added your chip, so I don't think you need anything else to do. CB:76853 is submitted, so the chip is added. Well done! What is one last thing you can do here: is to abandon this patch (you should have the button "Abandon" in the top right corner). If you are planning to add another chip, you will need to create new patch for that. -- To view, visit https://review.coreboot.org/c/flashrom/+/77581?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: testpush Gerrit-Change-Id: Id6c4254a02800f04c091009d19a628435fc20fce Gerrit-Change-Number: 77581 Gerrit-PatchSet: 4 Gerrit-Owner: Name of user not set #1005084 Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Attention: Name of user not set #1005084 Gerrit-Comment-Date: Mon, 18 Sep 2023 10:27:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[XS] Change in flashrom[master]: flashchips: Add support for MXIC MX25U25643G
by Name of user not set (Code Review) 18 Sep '23

18 Sep '23

Attention is currently required from: Name of user not set #1005084, Nikolai Artemiev, Stefan Reinauer. Hello Anastasia Klimchuk, Nikolai Artemiev, Stefan Reinauer, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/77581?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: flashchips: Add support for MXIC MX25U25643G ...................................................................... flashchips: Add support for MXIC MX25U25643G It is similar to the MX25U25635F and shares its RDID. Tested by ch341a programmer : read, write and erase. Datasheet is available at the following URL: https://www.mxic.com.tw/en-us/products/NOR-Flash/Serial-NOR-Flash/Pages/spe… Change-Id: Id6c4254a02800f04c091009d19a628435fc20fce Signed-off-by: xianzheng <xianzheng(a)mxic.com.cn> --- M flashchips.c M include/flashchips.h 2 files changed, 3 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/81/77581/4 -- To view, visit https://review.coreboot.org/c/flashrom/+/77581?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Id6c4254a02800f04c091009d19a628435fc20fce Gerrit-Change-Number: 77581 Gerrit-PatchSet: 4 Gerrit-Owner: Name of user not set #1005084 Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Attention: Name of user not set #1005084 Gerrit-MessageType: newpatchset

1 0

[XS] Change in flashrom[master]: flashrom_tester: Align WP output format with upstream
by Scott Chao (Code Review) 18 Sep '23

18 Sep '23

Attention is currently required from: Evan Benn. Scott Chao has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/77887?usp=email ) Change subject: flashrom_tester: Align WP output format with upstream ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: > Hi Edware, Could you please help to submit this change? Thanks. Sorry for the typo. Edward. -- To view, visit https://review.coreboot.org/c/flashrom/+/77887?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I755891e0d8b5857650febe08c2094733cf1f4c79 Gerrit-Change-Number: 77887 Gerrit-PatchSet: 2 Gerrit-Owner: Scott Chao <scott_chao(a)wistron.corp-partner.google.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Evan Benn <evanbenn(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Evan Benn <evanbenn(a)gmail.com> Gerrit-Comment-Date: Mon, 18 Sep 2023 00:17:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Scott Chao <scott_chao(a)wistron.corp-partner.google.com> Gerrit-MessageType: comment

1 0

[XS] Change in flashrom[master]: flashrom_tester: Align WP output format with upstream
by Scott Chao (Code Review) 18 Sep '23

18 Sep '23

Attention is currently required from: Evan Benn. Scott Chao has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/77887?usp=email ) Change subject: flashrom_tester: Align WP output format with upstream ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: Hi Edware, Could you please help to submit this change? Thanks. -- To view, visit https://review.coreboot.org/c/flashrom/+/77887?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I755891e0d8b5857650febe08c2094733cf1f4c79 Gerrit-Change-Number: 77887 Gerrit-PatchSet: 2 Gerrit-Owner: Scott Chao <scott_chao(a)wistron.corp-partner.google.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Evan Benn <evanbenn(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Evan Benn <evanbenn(a)gmail.com> Gerrit-Comment-Date: Mon, 18 Sep 2023 00:16:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: erasure_layout: Fix double invocation of erasers
by Alexander Goncharov (Code Review) 17 Sep '23

17 Sep '23

Attention is currently required from: Aarya, Anastasia Klimchuk, Sam McNally. Alexander Goncharov has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/77747?usp=email ) Change subject: erasure_layout: Fix double invocation of erasers ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: > Oh I missed that issue, sorry :(( I assigned to myself so that it's not missed. I still encounter an error. Added comments and logs in the issue tracker. -- To view, visit https://review.coreboot.org/c/flashrom/+/77747?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I92351eba0fd29114ce98b4a839358e92d176af28 Gerrit-Change-Number: 77747 Gerrit-PatchSet: 3 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Aarya <aarya.chaumal(a)gmail.com> Gerrit-Reviewer: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Sam McNally <sammc(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sam McNally <sammc(a)google.com> Gerrit-Attention: Aarya <aarya.chaumal(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Sun, 17 Sep 2023 15:58:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Comment-In-Reply-To: Alexander Goncharov <chat(a)joursoir.net> Gerrit-MessageType: comment

1 0

[XS] Change in flashrom[master]: flashchips: Add support for MXIC MX25U25643G
by Anastasia Klimchuk (Code Review) 17 Sep '23

17 Sep '23

Anastasia Klimchuk has submitted this change. ( https://review.coreboot.org/c/flashrom/+/76853?usp=email ) ( 3 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: flashchips: Add support for MXIC MX25U25643G ...................................................................... flashchips: Add support for MXIC MX25U25643G It is similar to the MX25U25635F and shares its RDID. Tested by ch341a programmer : read, write and erase. Datasheet is available at the following URL: https://www.mxic.com.tw/en-us/products/NOR-Flash/Serial-NOR-Flash/Pages/spe… Change-Id: Ie04a5e2325aab94bffb276675be3fa4a88c6e134 Signed-off-by: xianzheng <xianzheng(a)mxic.com.cn> Reviewed-on: https://review.coreboot.org/c/flashrom/+/76853 Reviewed-by: Anastasia Klimchuk <aklm(a)chromium.org> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M flashchips.c M include/flashchips.h 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: build bot (Jenkins): Verified Anastasia Klimchuk: Looks good to me, approved diff --git a/flashchips.c b/flashchips.c index 065ebf2..83264ef 100644 --- a/flashchips.c +++ b/flashchips.c @@ -10207,7 +10207,7 @@ { .vendor = "Macronix", - .name = "MX25U25635F", + .name = "MX25U25635F/MX25U25643G", .bustype = BUS_SPI, .manufacture_id = MACRONIX_ID, .model_id = MACRONIX_MX25U25635F, diff --git a/include/flashchips.h b/include/flashchips.h index 8645054..dfe9ec6 100644 --- a/include/flashchips.h +++ b/include/flashchips.h @@ -529,7 +529,7 @@ #define MACRONIX_MX25U3235E 0x2536 /* Same as MX25U6435F */ #define MACRONIX_MX25U6435E 0x2537 /* Same as MX25U6435F */ #define MACRONIX_MX25U12835E 0x2538 /* Same as MX25U12835F */ -#define MACRONIX_MX25U25635F 0x2539 +#define MACRONIX_MX25U25635F 0x2539 /* Same as MX25U25643G */ #define MACRONIX_MX25U51245G 0x253a #define MACRONIX_MX25L3235D 0x5E16 /* MX25L3225D/MX25L3235D/MX25L3237D */ #define MACRONIX_MX25L6495F 0x9517 -- To view, visit https://review.coreboot.org/c/flashrom/+/76853?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ie04a5e2325aab94bffb276675be3fa4a88c6e134 Gerrit-Change-Number: 76853 Gerrit-PatchSet: 6 Gerrit-Owner: Name of user not set #1005084 Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[S] Change in flashrom[master]: flashchips: add definition of the XT25F02E SPI NOR flash
by Anastasia Klimchuk (Code Review) 16 Sep '23

16 Sep '23

Anastasia Klimchuk has submitted this change. ( https://review.coreboot.org/c/flashrom/+/50263?usp=email ) ( 5 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: flashchips: add definition of the XT25F02E SPI NOR flash ...................................................................... flashchips: add definition of the XT25F02E SPI NOR flash This adds definition of the XT25F02E 2MBit SPI NOR Flash from XTX Technology Limited. Tested (Probe, Erase, Write, Read) with a VL805 USB3.0 bridge. Datasheet: https://datasheet.lcsc.com/lcsc/2006091008_XTX-XT25F02EDTIGT_C596313.pdf Signed-off-by: Neil Armstrong <narmstrong(a)baylibre.com> Change-Id: I295633c448c05520e4a6aa09c08bd7c9f2346d54 Signed-off-by: Anastasia Klimchuk <aklm(a)flashrom.org> Reviewed-on: https://review.coreboot.org/c/flashrom/+/50263 Reviewed-by: Peter Marheine <pmarheine(a)chromium.org> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M flashchips.c M include/flashchips.h 2 files changed, 36 insertions(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified Peter Marheine: Looks good to me, approved diff --git a/flashchips.c b/flashchips.c index 009624f..065ebf2 100644 --- a/flashchips.c +++ b/flashchips.c @@ -21095,6 +21095,41 @@ { .vendor = "XTX Technology Limited", + .name = "XT25F02E", + .bustype = BUS_SPI, + .manufacture_id = XTX_ID, + .model_id = XTX_XT25F02E, + .total_size = 256, + .page_size = 256, + .feature_bits = FEATURE_WRSR_WREN, + .tested = TEST_OK_PREW, + .probe = PROBE_SPI_RDID, + .probe_timing = TIMING_ZERO, + .block_erasers = + { + { + .eraseblocks = { {4 * 1024, 64} }, + .block_erase = SPI_BLOCK_ERASE_20, + }, { + .eraseblocks = { {64 * 1024, 4} }, + .block_erase = SPI_BLOCK_ERASE_D8, + }, { + .eraseblocks = { {256 * 1024, 1} }, + .block_erase = SPI_BLOCK_ERASE_60, + }, { + .eraseblocks = { {256 * 1024, 1} }, + .block_erase = SPI_BLOCK_ERASE_C7, + } + }, + .printlock = SPI_PRETTYPRINT_STATUS_REGISTER_BP1_SRWD, + .unlock = SPI_DISABLE_BLOCKPROTECT_BP1_SRWD, + .write = SPI_CHIP_WRITE256, + .read = SPI_CHIP_READ, + .voltage = {2700, 3600}, + }, + + { + .vendor = "XTX Technology Limited", .name = "XT25F64B", .bustype = BUS_SPI, .manufacture_id = XTX_ID, diff --git a/include/flashchips.h b/include/flashchips.h index 6e191eb..8645054 100644 --- a/include/flashchips.h +++ b/include/flashchips.h @@ -1045,6 +1045,7 @@ #define WINBOND_W49V002FA 0x32 #define XTX_ID 0x0B /* XTX Technology Limited */ +#define XTX_XT25F02E 0x4012 #define XTX_XT25F64B 0x4017 #define ZETTADEVICE_ID 0xBA /* Zetta Device */ -- To view, visit https://review.coreboot.org/c/flashrom/+/50263?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I295633c448c05520e4a6aa09c08bd7c9f2346d54 Gerrit-Change-Number: 50263 Gerrit-PatchSet: 7 Gerrit-Owner: Neil Armstrong <narmstrong(a)baylibre.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[S] Change in flashrom[master]: erasure_layout: Fix double invocation of erasers
by Anastasia Klimchuk (Code Review) 15 Sep '23

15 Sep '23

Attention is currently required from: Aarya, Alexander Goncharov, Sam McNally. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/77747?usp=email ) Change subject: erasure_layout: Fix double invocation of erasers ...................................................................... Patch Set 3: (1 comment) Patchset: PS2: I did some more investigation and traced when this double-erase started: initial logic which erased everything once is here: https://review.coreboot.org/c/flashrom/+/66104/67 (that's around end of last year) line flashrom.c#1174 and here second invocation was added: https://review.coreboot.org/c/flashrom/+/66104/95..96 the code moved to a separate file, so two invocations are at: erasure_layout.c#314 and #322 At head the two invocations are at erasure_layout.c#331 and #342 Now in my patch here I wrapped second invocation into a conditional, so that it is not invoked always, but only if something left to erase. I don't know whether it is a realistic scenario, and that's what you were saying: > ideally there should nothing be left once the above loop at line 309 finishes -- To view, visit https://review.coreboot.org/c/flashrom/+/77747?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I92351eba0fd29114ce98b4a839358e92d176af28 Gerrit-Change-Number: 77747 Gerrit-PatchSet: 3 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Aarya <aarya.chaumal(a)gmail.com> Gerrit-Reviewer: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Sam McNally <sammc(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sam McNally <sammc(a)google.com> Gerrit-Attention: Aarya <aarya.chaumal(a)gmail.com> Gerrit-Attention: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Comment-Date: Fri, 15 Sep 2023 06:17:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Aarya <aarya.chaumal(a)gmail.com> Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: comment

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit September 2023