September 2023 - flashrom-gerrit

[XS] Change in flashrom[master]: meson.build: Upgrade minimum Meson version to 0.56.0
by Anton Samsonov (Code Review) 14 Sep '23

14 Sep '23

Attention is currently required from: Anastasia Klimchuk, Anton Samsonov, Peter Marheine, Thomas Heijligen. Anton Samsonov has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/77779?usp=email ) Change subject: meson.build: Upgrade minimum Meson version to 0.56.0 ...................................................................... Patch Set 2: (1 comment) Commit Message: https://review.coreboot.org/c/flashrom/+/77779/comment/2622d22e_24cd1b55 : PS1, Line 7: Uplift > "Upgrade" is better Done -- To view, visit https://review.coreboot.org/c/flashrom/+/77779?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I53c6c42c27a58734742e3dce3cdbde4c65b89a90 Gerrit-Change-Number: 77779 Gerrit-PatchSet: 2 Gerrit-Owner: Anton Samsonov <devel(a)zxlab.ru> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Anton Samsonov <avscomputing(a)gmail.com> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Anton Samsonov <devel(a)zxlab.ru> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Comment-Date: Thu, 14 Sep 2023 09:25:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: comment

1 0

[XS] Change in flashrom[master]: meson.build: Upgrade minimum Meson version to 0.56.0
by Anton Samsonov (Code Review) 14 Sep '23

14 Sep '23

Attention is currently required from: Anton Samsonov, Peter Marheine, Thomas Heijligen. Anton Samsonov has uploaded a new patch set (#2) to the change originally created by Anton Samsonov. ( https://review.coreboot.org/c/flashrom/+/77779?usp=email ) Change subject: meson.build: Upgrade minimum Meson version to 0.56.0 ...................................................................... meson.build: Upgrade minimum Meson version to 0.56.0 Since doc/meson.build uses `str.substring()` introduced in Meson 0.56.0, the root meson.build should be updated from 0.53.0. Change-Id: I53c6c42c27a58734742e3dce3cdbde4c65b89a90 Signed-off-by: Anton Samsonov <devel(a)zxlab.ru> --- M meson.build 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/79/77779/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/77779?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I53c6c42c27a58734742e3dce3cdbde4c65b89a90 Gerrit-Change-Number: 77779 Gerrit-PatchSet: 2 Gerrit-Owner: Anton Samsonov <devel(a)zxlab.ru> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Anton Samsonov <devel(a)zxlab.ru> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

[XS] Change in flashrom[master]: meson.build: Uplift minimum Meson version to 0.56.0
by Anastasia Klimchuk (Code Review) 14 Sep '23

14 Sep '23

Attention is currently required from: Anton Samsonov, Peter Marheine, Thomas Heijligen. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/77779?usp=email ) Change subject: meson.build: Uplift minimum Meson version to 0.56.0 ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Commit Message: https://review.coreboot.org/c/flashrom/+/77779/comment/4876532c_076f2176 : PS1, Line 7: Uplift "Upgrade" is better -- To view, visit https://review.coreboot.org/c/flashrom/+/77779?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I53c6c42c27a58734742e3dce3cdbde4c65b89a90 Gerrit-Change-Number: 77779 Gerrit-PatchSet: 1 Gerrit-Owner: Anton Samsonov <devel(a)zxlab.ru> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Anton Samsonov <devel(a)zxlab.ru> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Comment-Date: Thu, 14 Sep 2023 09:21:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in flashrom[master]: meson.build: Uplift minimum Meson version to 0.56.0
by Anastasia Klimchuk (Code Review) 14 Sep '23

14 Sep '23

Attention is currently required from: Anton Samsonov, Peter Marheine, Thomas Heijligen. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/77779?usp=email ) Change subject: meson.build: Uplift minimum Meson version to 0.56.0 ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Patchset: PS1: I recalled there was a moment when we tried to upgrade the version but then reverted back. I found the patch CB:73361 but from the comments it seems that 0.56.0 should be fine. Also indeed substring() was only introduced in 0.56 From Jenkins logs I see that 1.0 is installed on server, so that's even higher. I hope I am not missing anything? -- To view, visit https://review.coreboot.org/c/flashrom/+/77779?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I53c6c42c27a58734742e3dce3cdbde4c65b89a90 Gerrit-Change-Number: 77779 Gerrit-PatchSet: 1 Gerrit-Owner: Anton Samsonov <devel(a)zxlab.ru> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Anton Samsonov <devel(a)zxlab.ru> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Comment-Date: Thu, 14 Sep 2023 09:20:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in flashrom[master]: flashrom_tester: Align WP output format with upstream
by Edward O'Callaghan (Code Review) 14 Sep '23

14 Sep '23

Attention is currently required from: Evan Benn, Scott Chao. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/77887?usp=email ) Change subject: flashrom_tester: Align WP output format with upstream ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/77887?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I755891e0d8b5857650febe08c2094733cf1f4c79 Gerrit-Change-Number: 77887 Gerrit-PatchSet: 2 Gerrit-Owner: Scott Chao <scott_chao(a)wistron.corp-partner.google.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Evan Benn <evanbenn(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Evan Benn <evanbenn(a)gmail.com> Gerrit-Attention: Scott Chao <scott_chao(a)wistron.corp-partner.google.com> Gerrit-Comment-Date: Thu, 14 Sep 2023 05:41:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in flashrom[master]: flashrom_tester: Align WP output format with upstream
by Scott Chao (Code Review) 14 Sep '23

14 Sep '23

Attention is currently required from: Evan Benn. Hello Evan Benn, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/77887?usp=email to look at the new patch set (#2). Change subject: flashrom_tester: Align WP output format with upstream ...................................................................... flashrom_tester: Align WP output format with upstream After WP output format changed, the flashrom_tester will always read software write protect is disabled. BUG=b:300300436 TEST=Verify on flashrom_tester Change-Id: I755891e0d8b5857650febe08c2094733cf1f4c79 Signed-off-by: Scott Chao <scott_chao(a)wistron.corp-partner.google.com> --- M util/flashrom_tester/flashrom/src/cmd.rs 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/87/77887/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/77887?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I755891e0d8b5857650febe08c2094733cf1f4c79 Gerrit-Change-Number: 77887 Gerrit-PatchSet: 2 Gerrit-Owner: Scott Chao <scott_chao(a)wistron.corp-partner.google.com> Gerrit-Reviewer: Evan Benn <evanbenn(a)gmail.com> Gerrit-Attention: Evan Benn <evanbenn(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

[XS] Change in flashrom[master]: flashrom_tester: Align WP output format with upstream
by Scott Chao (Code Review) 14 Sep '23

14 Sep '23

Scott Chao has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/77887?usp=email ) Change subject: flashrom_tester: Align WP output format with upstream ...................................................................... flashrom_tester: Align WP output format with upstream After WP output format changed, the flashrom_tester will always read software write protect is disabled. BUG=b: TEST=Verify on flashrom_tester Change-Id: I755891e0d8b5857650febe08c2094733cf1f4c79 Signed-off-by: Scott Chao <scott_chao(a)wistron.corp-partner.google.com> --- M util/flashrom_tester/flashrom/src/cmd.rs 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/87/77887/1 diff --git a/util/flashrom_tester/flashrom/src/cmd.rs b/util/flashrom_tester/flashrom/src/cmd.rs index 1f13a8e..9e66fe2 100644 --- a/util/flashrom_tester/flashrom/src/cmd.rs +++ b/util/flashrom_tester/flashrom/src/cmd.rs @@ -194,6 +194,7 @@ fn wp_status(&self, en: bool) -> Result<bool, FlashromError> { let status = if en { "en" } else { "dis" }; + let protection_mode = if en { "hardware" } else { "disable" }; info!("See if chip write protect is {}abled", status); let opts = FlashromOpt { @@ -205,7 +206,7 @@ }; let (stdout, _) = self.dispatch(opts, "wp_status")?; - let s = std::format!("write protect is {}abled", status); + let s = std::format!("Protection mode: {}", protection_mode); Ok(stdout.contains(&s)) } -- To view, visit https://review.coreboot.org/c/flashrom/+/77887?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I755891e0d8b5857650febe08c2094733cf1f4c79 Gerrit-Change-Number: 77887 Gerrit-PatchSet: 1 Gerrit-Owner: Scott Chao <scott_chao(a)wistron.corp-partner.google.com> Gerrit-MessageType: newchange

1 0

[XS] Change in flashrom[master]: flashchips: Add support for MXIC MX25U25643G
by Anastasia Klimchuk (Code Review) 14 Sep '23

14 Sep '23

Attention is currently required from: Name of user not set #1005084, Nikolai Artemiev, Stefan Reinauer. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/76853?usp=email ) Change subject: flashchips: Add support for MXIC MX25U25643G ...................................................................... Patch Set 3: Code-Review+2 (1 comment) Patchset: PS3: Thank you! it was a very good idea to update the definition of existing chip if they are almost the same. -- To view, visit https://review.coreboot.org/c/flashrom/+/76853?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ie04a5e2325aab94bffb276675be3fa4a88c6e134 Gerrit-Change-Number: 76853 Gerrit-PatchSet: 3 Gerrit-Owner: Name of user not set #1005084 Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Attention: Name of user not set #1005084 Gerrit-Comment-Date: Thu, 14 Sep 2023 00:09:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: flashchips: add definition of the XT25F02E SPI NOR flash
by Peter Marheine (Code Review) 13 Sep '23

13 Sep '23

Attention is currently required from: Anastasia Klimchuk, Angel Pons, Neil Armstrong, Nikolai Artemiev, Stefan Reinauer, Thomas Heijligen. Peter Marheine has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/50263?usp=email ) Change subject: flashchips: add definition of the XT25F02E SPI NOR flash ...................................................................... Patch Set 5: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/50263?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I295633c448c05520e4a6aa09c08bd7c9f2346d54 Gerrit-Change-Number: 50263 Gerrit-PatchSet: 5 Gerrit-Owner: Neil Armstrong <narmstrong(a)baylibre.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Neil Armstrong <narmstrong(a)baylibre.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Comment-Date: Wed, 13 Sep 2023 04:00:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in flashrom[master]: meson.build: Uplift minimum Meson version to 0.56.0
by Anton Samsonov (Code Review) 12 Sep '23

12 Sep '23

Anton Samsonov has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/77779?usp=email ) Change subject: meson.build: Uplift minimum Meson version to 0.56.0 ...................................................................... meson.build: Uplift minimum Meson version to 0.56.0 Since doc/meson.build uses `str.substring()` introduced in Meson 0.56.0, the root meson.build should be updated from 0.53.0. Change-Id: I53c6c42c27a58734742e3dce3cdbde4c65b89a90 Signed-off-by: Anton Samsonov <devel(a)zxlab.ru> --- M meson.build 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/79/77779/1 diff --git a/meson.build b/meson.build index 77d941e..c85fdf4 100644 --- a/meson.build +++ b/meson.build @@ -1,7 +1,7 @@ project('flashromutils', 'c', version : run_command('cat', 'VERSION', check: true).stdout().strip(), license : 'GPL-2.0', - meson_version : '>=0.53.0', + meson_version : '>=0.56.0', default_options : [ 'warning_level=2', 'c_std=c99', -- To view, visit https://review.coreboot.org/c/flashrom/+/77779?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I53c6c42c27a58734742e3dce3cdbde4c65b89a90 Gerrit-Change-Number: 77779 Gerrit-PatchSet: 1 Gerrit-Owner: Anton Samsonov <devel(a)zxlab.ru> Gerrit-MessageType: newchange

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit September 2023