Attention is currently required from: Alexander Goncharov, Stefan Reinauer, Thomas Heijligen.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/77438?usp=email )
Change subject: doc: Add html_logo and html_title to sphinx config
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
I missed the elephant in the room, there is a way to add logo in sphinx config.
This one will be shown …
[View More]on every page (unlike CB:77250 which only shows on home page). Maybe it's fine to have both? If it turns out both are too much, we can remove the one from CB:77250. This one should stay because it is displayed on every page.
--
To view, visit https://review.coreboot.org/c/flashrom/+/77438?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I9a530f7143880393fffc2a97327416f2cd688586
Gerrit-Change-Number: 77438
Gerrit-PatchSet: 1
Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: Alexander Goncharov <chat(a)joursoir.net>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de>
Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Attention: Thomas Heijligen <src(a)posteo.de>
Gerrit-Attention: Alexander Goncharov <chat(a)joursoir.net>
Gerrit-Comment-Date: Fri, 25 Aug 2023 12:28:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
[View Less]
Anastasia Klimchuk has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/77438?usp=email )
Change subject: doc: Add html_logo and html_title to sphinx config
......................................................................
doc: Add html_logo and html_title to sphinx config
Logo set in config will be shown at the top of the sidebar, which
means it will be shown on every page.
Change-Id: I9a530f7143880393fffc2a97327416f2cd688586
Signed-off-by: Anastasia …
[View More]Klimchuk <aklm(a)flashrom.org>
---
M doc/conf.py
1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/38/77438/1
diff --git a/doc/conf.py b/doc/conf.py
index be9cc01..df60be7 100644
--- a/doc/conf.py
+++ b/doc/conf.py
@@ -40,6 +40,9 @@
html_favicon = 'logo/flashrom_icon_color-32x32.ico'
+html_logo = 'logo/flashrom_icon_color.svg'
+
+html_title = 'flashrom documentation'
# -- Options for manual page output --------------------------------------------
man_make_section_directory = True
--
To view, visit https://review.coreboot.org/c/flashrom/+/77438?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I9a530f7143880393fffc2a97327416f2cd688586
Gerrit-Change-Number: 77438
Gerrit-PatchSet: 1
Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-MessageType: newchange
[View Less]
Attention is currently required from: Bart De Schuymer, Peter Marheine, Thomas Heijligen.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/77288?usp=email )
Change subject: Makefile: Remove a bashism when searching for sphinx-build
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
Bart, sorry I forgot to ask previously, did you have a chance to test run with both dash and bash?
…
[View More]Otherwise that's it, that's only question I have left.
--
To view, visit https://review.coreboot.org/c/flashrom/+/77288?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I4d89e24ec3401446acec857eae134928bc3064d2
Gerrit-Change-Number: 77288
Gerrit-PatchSet: 2
Gerrit-Owner: Bart De Schuymer <bdschuym(a)artinalgorithms.be>
Gerrit-Reviewer: Jan Samek <jan.samek(a)siemens.com>
Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org>
Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Attention: Thomas Heijligen <src(a)posteo.de>
Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org>
Gerrit-Attention: Bart De Schuymer <bdschuym(a)artinalgorithms.be>
Gerrit-Comment-Date: Fri, 25 Aug 2023 11:54:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
[View Less]
Attention is currently required from: Angel Pons, Nikolai Artemiev, Stefan Reinauer, mans0n+coreboot(a)gorani.run.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/63516?usp=email )
Change subject: flashchips: Add support for XMC XM25QH80B
......................................................................
Patch Set 3:
(2 comments)
Patchset:
PS1:
> Hi, […]
Sungbo, thank you so much for your contribution, sorry that your patch was …
[View More]lost and hanging for so long.
We had some structural changes in flashchips.c file since the time you sent the patch. So I made the changes to your chip definition and rebased your patch on head.
You did it right with reusing model_id of ST_M45PE80 and adding a comment.
File flashchips.c:
https://review.coreboot.org/c/flashrom/+/63516/comment/f31cfea6_fd673f2e :
PS3, Line 20776: SPI_PRETTYPRINT_STATUS_REGISTER_BP2_SRWD
I am not entirely sure about this one, we have 4 different functions to prettyprint with BP2 and it would be ideal if another reviewer checks this is correct function. Thank you!
Initial patch had plain prettyprint, but I think we can use one of BP2 ones?
--
To view, visit https://review.coreboot.org/c/flashrom/+/63516?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ib51225426d8d1a381d45af3574e5ba2bf02837aa
Gerrit-Change-Number: 63516
Gerrit-PatchSet: 3
Gerrit-Owner: mans0n+coreboot(a)gorani.run
Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: mans0n+coreboot(a)gorani.run
Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com>
Gerrit-Comment-Date: Fri, 25 Aug 2023 09:27:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: mans0n+coreboot(a)gorani.run
Gerrit-MessageType: comment
[View Less]
Attention is currently required from: Anastasia Klimchuk, Angel Pons.
Anastasia Klimchuk has uploaded a new patch set (#3) to the change originally created by mans0n+coreboot(a)gorani.run. ( https://review.coreboot.org/c/flashrom/+/63516?usp=email )
The following approvals got outdated and were removed:
Verified+1 by build bot (Jenkins)
Change subject: flashchips: Add support for XMC XM25QH80B
......................................................................
flashchips: Add support …
[View More]for XMC XM25QH80B
XM25QH80B has the same ID as M45PE80, but has more features.
Tested with CH341A.
Change-Id: Ib51225426d8d1a381d45af3574e5ba2bf02837aa
Signed-off-by: Sungbo Eo <mans0n(a)gorani.run>
Signed-off-by: Anastasia Klimchuk <aklm(a)flashrom.org>
---
M flashchips.c
M include/flashchips.h
2 files changed, 39 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/16/63516/3
--
To view, visit https://review.coreboot.org/c/flashrom/+/63516?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ib51225426d8d1a381d45af3574e5ba2bf02837aa
Gerrit-Change-Number: 63516
Gerrit-PatchSet: 3
Gerrit-Owner: mans0n+coreboot(a)gorani.run
Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-MessageType: newpatchset
[View Less]
Anastasia Klimchuk has submitted this change. ( https://review.coreboot.org/c/flashrom/+/77250?usp=email )
Change subject: doc: Add flashrom logo to index page
......................................................................
doc: Add flashrom logo to index page
Change-Id: I44a35b16a29b850e2b49d6e75c52d80b17bf7f75
Signed-off-by: Anastasia Klimchuk <aklm(a)flashrom.org>
Reviewed-on: https://review.coreboot.org/c/flashrom/+/77250
Tested-by: build bot (Jenkins) <no-reply(a)…
[View More]coreboot.org>
Reviewed-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Reviewed-by: Edward O'Callaghan <quasisec(a)chromium.org>
---
M doc/index.rst
1 file changed, 3 insertions(+), 0 deletions(-)
Approvals:
build bot (Jenkins): Verified
Edward O'Callaghan: Looks good to me, approved
Stefan Reinauer: Looks good to me, approved
diff --git a/doc/index.rst b/doc/index.rst
index cc58183..1943934 100644
--- a/doc/index.rst
+++ b/doc/index.rst
@@ -3,6 +3,9 @@
You can adapt this file completely to your liking, but it should at least
contain the root `toctree` directive.
+.. image:: logo/flashrom_logo.png
+ :alt: flashrom logo
+
.. toctree::
:hidden:
--
To view, visit https://review.coreboot.org/c/flashrom/+/77250?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I44a35b16a29b850e2b49d6e75c52d80b17bf7f75
Gerrit-Change-Number: 77250
Gerrit-PatchSet: 3
Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: Alexander Goncharov <chat(a)joursoir.net>
Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-MessageType: merged
[View Less]
Attention is currently required from: Alexander Goncharov, Thomas Heijligen.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/77250?usp=email )
Change subject: doc: Add flashrom logo to index page
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS1:
> This patch should wait for CB:77249 to be merged. Adding comment because Gerrit thinks it's ready.
Done
--
To view, visit …
[View More]https://review.coreboot.org/c/flashrom/+/77250?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I44a35b16a29b850e2b49d6e75c52d80b17bf7f75
Gerrit-Change-Number: 77250
Gerrit-PatchSet: 2
Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: Alexander Goncharov <chat(a)joursoir.net>
Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Thomas Heijligen <src(a)posteo.de>
Gerrit-Attention: Alexander Goncharov <chat(a)joursoir.net>
Gerrit-Comment-Date: Fri, 25 Aug 2023 07:53:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-MessageType: comment
[View Less]