August 2023 - flashrom-gerrit - mail.coreboot.org

[M] Change in flashrom[master]: Remove dependency on C23's __has_include()
by Anastasia Klimchuk (Code Review) 22 Aug '23

22 Aug '23

Anastasia Klimchuk has abandoned this change. ( https://review.coreboot.org/c/flashrom/+/77043?usp=email ) Change subject: Remove dependency on C23's __has_include() ...................................................................... Abandoned Replaced with CB:77089 -- To view, visit https://review.coreboot.org/c/flashrom/+/77043?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ifaeb46127785af86e69852152783f75d241b1266 Gerrit-Change-Number: 77043 Gerrit-PatchSet: 2 Gerrit-Owner: Anton Samsonov <devel(a)zxlab.ru> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-CC: Anton Samsonov <avscomputing(a)gmail.com> Gerrit-MessageType: abandon

1 0

[M] Change in flashrom[master]: Remove dependency on C23's __has_include()
by Anastasia Klimchuk (Code Review) 22 Aug '23

22 Aug '23

Attention is currently required from: Anton Samsonov, Anton Samsonov. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/77043?usp=email ) Change subject: Remove dependency on C23's __has_include() ...................................................................... Patch Set 2: (1 comment) Patchset: PS1: > I guest there must be an option for that, however I do not see such a button — perhaps because I can […] Oh I see you have 3 different emails for owner, uploader and author. Owner should be able to abandon, but the other two might not. I can do that, all good. For the next time: you don't have to create new patch if you want to fix something, you can create new patchset in the same patch. Check that Change-Id stays the same and Gerrit will recognise that new patchset belongs to the same patch. -- To view, visit https://review.coreboot.org/c/flashrom/+/77043?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ifaeb46127785af86e69852152783f75d241b1266 Gerrit-Change-Number: 77043 Gerrit-PatchSet: 2 Gerrit-Owner: Anton Samsonov <devel(a)zxlab.ru> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-CC: Anton Samsonov <avscomputing(a)gmail.com> Gerrit-Attention: Anton Samsonov <avscomputing(a)gmail.com> Gerrit-Attention: Anton Samsonov <devel(a)zxlab.ru> Gerrit-Comment-Date: Tue, 22 Aug 2023 02:19:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anton Samsonov <avscomputing(a)gmail.com> Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: comment

1 0

[XS] Change in flashrom[master]: Makefile: Remove a bashism when searching for sphinx-build
by Bart De Schuymer (Code Review) 21 Aug '23

21 Aug '23

Attention is currently required from: Anastasia Klimchuk, Peter Marheine, Thomas Heijligen. Bart De Schuymer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/77288?usp=email ) Change subject: Makefile: Remove a bashism when searching for sphinx-build ...................................................................... Patch Set 2: (1 comment) Commit Message: https://review.coreboot.org/c/flashrom/+/77288/comment/39caa1b0_eec31253 : PS1, Line 9: wongly > wrongly (typo) Done -- To view, visit https://review.coreboot.org/c/flashrom/+/77288?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I4d89e24ec3401446acec857eae134928bc3064d2 Gerrit-Change-Number: 77288 Gerrit-PatchSet: 2 Gerrit-Owner: Bart De Schuymer <bdschuym(a)artinalgorithms.be> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Comment-Date: Mon, 21 Aug 2023 20:39:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: comment

1 0

[XS] Change in flashrom[master]: Makefile: Remove a bashism when searching for sphinx-build
by Bart De Schuymer (Code Review) 21 Aug '23

21 Aug '23

Attention is currently required from: Bart De Schuymer, Peter Marheine, Thomas Heijligen. Hello Peter Marheine, Thomas Heijligen, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/77288?usp=email to look at the new patch set (#2). Change subject: Makefile: Remove a bashism when searching for sphinx-build ...................................................................... Makefile: Remove a bashism when searching for sphinx-build e.g. when the shell is dash and sphinx-build is not installed, HAS_SPHINXBUILD would be wrongly set to yes. Change-Id: I4d89e24ec3401446acec857eae134928bc3064d2 Signed-off-by: Bart De Schuymer <bdschuym(a)artinalgorithms.be> --- M Makefile 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/88/77288/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/77288?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I4d89e24ec3401446acec857eae134928bc3064d2 Gerrit-Change-Number: 77288 Gerrit-PatchSet: 2 Gerrit-Owner: Bart De Schuymer <bdschuym(a)artinalgorithms.be> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Attention: Bart De Schuymer <bdschuym(a)artinalgorithms.be> Gerrit-MessageType: newpatchset

1 0

[M] Change in flashrom[master]: Remove dependency on C23's __has_include()
by Anton Samsonov (Code Review) 21 Aug '23

21 Aug '23

Attention is currently required from: Anastasia Klimchuk, Anton Samsonov, Anton Samsonov. Anton Samsonov has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/77043?usp=email ) Change subject: Remove dependency on C23's __has_include() ...................................................................... Patch Set 2: (1 comment) Patchset: PS1: > Anton, I understand you made another patch CB:77089 as a replacement. You can abandon this patch. I guest there must be an option for that, however I do not see such a button — perhaps because I can only login here using a different authentication provider. The best I can do is to delete the files in changeset. -- To view, visit https://review.coreboot.org/c/flashrom/+/77043?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ifaeb46127785af86e69852152783f75d241b1266 Gerrit-Change-Number: 77043 Gerrit-PatchSet: 2 Gerrit-Owner: Anton Samsonov <devel(a)zxlab.ru> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-CC: Anton Samsonov <avscomputing(a)gmail.com> Gerrit-Attention: Anton Samsonov <avscomputing(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Anton Samsonov <devel(a)zxlab.ru> Gerrit-Comment-Date: Mon, 21 Aug 2023 12:47:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: Remove dependency on C23's __has_include()
by Anastasia Klimchuk (Code Review) 21 Aug '23

21 Aug '23

Attention is currently required from: Anton Samsonov. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/77043?usp=email ) Change subject: Remove dependency on C23's __has_include() ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: Anton, I understand you made another patch CB:77089 as a replacement. You can abandon this patch. -- To view, visit https://review.coreboot.org/c/flashrom/+/77043?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ifaeb46127785af86e69852152783f75d241b1266 Gerrit-Change-Number: 77043 Gerrit-PatchSet: 1 Gerrit-Owner: Anton Samsonov <devel(a)zxlab.ru> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Anton Samsonov <devel(a)zxlab.ru> Gerrit-Comment-Date: Mon, 21 Aug 2023 11:25:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[XS] Change in flashrom[master]: Makefile: Remove a bashism when searching for sphinx-build
by Anastasia Klimchuk (Code Review) 21 Aug '23

21 Aug '23

Attention is currently required from: Bart De Schuymer, Peter Marheine, Thomas Heijligen. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/77288?usp=email ) Change subject: Makefile: Remove a bashism when searching for sphinx-build ...................................................................... Patch Set 1: (1 comment) Commit Message: https://review.coreboot.org/c/flashrom/+/77288/comment/425a37ca_e51d5401 : PS1, Line 9: wongly wrongly (typo) -- To view, visit https://review.coreboot.org/c/flashrom/+/77288?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I4d89e24ec3401446acec857eae134928bc3064d2 Gerrit-Change-Number: 77288 Gerrit-PatchSet: 1 Gerrit-Owner: Bart De Schuymer <bdschuym(a)artinalgorithms.be> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Attention: Bart De Schuymer <bdschuym(a)artinalgorithms.be> Gerrit-Comment-Date: Mon, 21 Aug 2023 11:22:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[XS] Change in flashrom[master]: MAINTAINERS: Add Stefan Reinauer to flashchips
by Anastasia Klimchuk (Code Review) 21 Aug '23

21 Aug '23

Attention is currently required from: Stefan Reinauer. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/77273?usp=email ) Change subject: MAINTAINERS: Add Stefan Reinauer to flashchips ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/77273?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ib1f79d06cebf0f091382c857da0be2f5d7a73581 Gerrit-Change-Number: 77273 Gerrit-PatchSet: 3 Gerrit-Owner: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Comment-Date: Mon, 21 Aug 2023 02:11:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in flashrom[master]: MAINTAINERS: Add Stefan Reinauer to flashchips
by Stefan Reinauer (Code Review) 21 Aug '23

21 Aug '23

Attention is currently required from: Anastasia Klimchuk, Stefan Reinauer. Hello Anastasia Klimchuk, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/77273?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Code-Review+2 by Anastasia Klimchuk, Verified+1 by build bot (Jenkins) The change is no longer submittable: Code-Review and Verified are unsatisfied now. Change subject: MAINTAINERS: Add Stefan Reinauer to flashchips ...................................................................... MAINTAINERS: Add Stefan Reinauer to flashchips Change-Id: Ib1f79d06cebf0f091382c857da0be2f5d7a73581 Signed-off-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> --- M MAINTAINERS 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/73/77273/3 -- To view, visit https://review.coreboot.org/c/flashrom/+/77273?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ib1f79d06cebf0f091382c857da0be2f5d7a73581 Gerrit-Change-Number: 77273 Gerrit-PatchSet: 3 Gerrit-Owner: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

[XS] Change in flashrom[master]: MAINTAINERS: Add Nikolai Artemiev for flashchips
by Anastasia Klimchuk (Code Review) 20 Aug '23

20 Aug '23

Anastasia Klimchuk has submitted this change. ( https://review.coreboot.org/c/flashrom/+/77205?usp=email ) Change subject: MAINTAINERS: Add Nikolai Artemiev for flashchips ...................................................................... MAINTAINERS: Add Nikolai Artemiev for flashchips Change-Id: Iba4ae742f6500ef26edfc976d842ede656b916d4 Signed-off-by: Nikolai Artemiev <nartemiev(a)google.com> Reviewed-on: https://review.coreboot.org/c/flashrom/+/77205 Reviewed-by: Anastasia Klimchuk <aklm(a)chromium.org> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M MAINTAINERS 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Anastasia Klimchuk: Looks good to me, approved build bot (Jenkins): Verified diff --git a/MAINTAINERS b/MAINTAINERS index 905696f..f1e350e 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -96,6 +96,7 @@ FLASHCHIPS M: Anastasia Klimchuk <aklm(a)chromium.org> +M: Nikolai Artemiev <nartemiev(a)google.com> S: Maintained F: flashchips* F: include/flashchips* -- To view, visit https://review.coreboot.org/c/flashrom/+/77205?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Iba4ae742f6500ef26edfc976d842ede656b916d4 Gerrit-Change-Number: 77205 Gerrit-PatchSet: 2 Gerrit-Owner: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit August 2023