flashrom-gerrit August 2023

flashrom-gerrit@flashrom.org

1 participants
112 discussions

[XS] Change in flashrom[master]: MAINTAINERS: Fix the link to dev guides and simplify the paragraph
by Anastasia Klimchuk (Code Review) 02 Aug '23

02 Aug '23

Attention is currently required from: Sergii Dmytruk. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/76828?usp=email ) Change subject: MAINTAINERS: Fix the link to dev guides and simplify the paragraph ...................................................................... Patch Set 2: (1 comment) File MAINTAINERS: https://review.coreboot.org/c/flashrom/+/76828/comment/f2c67302_8483163d : PS1, Line 12: [development guide] > I think you intended to drop the brackets. Yes! And I am not sure why they were there in the first place. -- To view, visit https://review.coreboot.org/c/flashrom/+/76828?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Idf4df7426e5cf080416ba6691c7f11260c2b4623 Gerrit-Change-Number: 76828 Gerrit-PatchSet: 2 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Comment-Date: Wed, 02 Aug 2023 08:43:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-MessageType: comment

1 0

[XS] Change in flashrom[master]: MAINTAINERS: Fix the link to dev guides and simplify the paragraph
by Anastasia Klimchuk (Code Review) 02 Aug '23

02 Aug '23

Attention is currently required from: Anastasia Klimchuk. Hello Peter Marheine, Sergii Dmytruk, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/76828?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: MAINTAINERS: Fix the link to dev guides and simplify the paragraph ...................................................................... MAINTAINERS: Fix the link to dev guides and simplify the paragraph We can just say "follow the dev guide" here, the rest of information should be in the dev guide. Change-Id: Idf4df7426e5cf080416ba6691c7f11260c2b4623 Signed-off-by: Anastasia Klimchuk <aklm(a)flashrom.org> --- M MAINTAINERS 1 file changed, 2 insertions(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/28/76828/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/76828?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Idf4df7426e5cf080416ba6691c7f11260c2b4623 Gerrit-Change-Number: 76828 Gerrit-PatchSet: 2 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit August 2023