August 2023 - flashrom-gerrit - mail.coreboot.org

[M] Change in flashrom[master]: flashrom: only perform WP unlock for write/erase operations
by Nikolai Artemiev (Code Review) 16 Aug '23

16 Aug '23

Attention is currently required from: Alexander Goncharov, Brian Norris, Edward O'Callaghan. Nikolai Artemiev has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/75991?usp=email ) Change subject: flashrom: only perform WP unlock for write/erase operations ...................................................................... Patch Set 4: (3 comments) File flashrom.c: https://review.coreboot.org/c/flashrom/+/75991/comment/906b1c82_b854acfd : PS3, Line 2056: const bool read_it > not used, drop it Done https://review.coreboot.org/c/flashrom/+/75991/comment/a91dc70f_6baa17b1 : PS3, Line 2057: const bool verify_it > not used, drop it Done https://review.coreboot.org/c/flashrom/+/75991/comment/b6d2f976_9961555a : PS3, Line 2060: int ret = 0; > if ret were initialized as `-1` there would be no need for `ret = -1` in if branches. Setting the return code in each error branch is more idiomatic for C code IMO. Ideally each error block would just be `return <error code>;` but since we do a `goto ...` instead, keeping the assignment to ret at least indicates that we want to return a particular value at that point. -- To view, visit https://review.coreboot.org/c/flashrom/+/75991?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I5dc66474a0b7969b51b86ac9f5daa2c95ae968f1 Gerrit-Change-Number: 75991 Gerrit-PatchSet: 4 Gerrit-Owner: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Brian Norris <briannorris(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Attention: Brian Norris <briannorris(a)chromium.org> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Comment-Date: Wed, 16 Aug 2023 10:40:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Alexander Goncharov <chat(a)joursoir.net> Gerrit-MessageType: comment

1 0

[XS] Change in flashrom[master]: MAINTAINERS: Add Nikolai Artemiev for flashchips
by Anastasia Klimchuk (Code Review) 15 Aug '23

15 Aug '23

Attention is currently required from: Nikolai Artemiev. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/77205?usp=email ) Change subject: MAINTAINERS: Add Nikolai Artemiev for flashchips ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/77205?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Iba4ae742f6500ef26edfc976d842ede656b916d4 Gerrit-Change-Number: 77205 Gerrit-PatchSet: 1 Gerrit-Owner: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Comment-Date: Tue, 15 Aug 2023 06:31:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in flashrom[master]: MAINTAINERS: Add Nikolai Artemiev for flashchips
by Nikolai Artemiev (Code Review) 15 Aug '23

15 Aug '23

Nikolai Artemiev has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/77205?usp=email ) Change subject: MAINTAINERS: Add Nikolai Artemiev for flashchips ...................................................................... MAINTAINERS: Add Nikolai Artemiev for flashchips Change-Id: Iba4ae742f6500ef26edfc976d842ede656b916d4 Signed-off-by: Nikolai Artemiev <nartemiev(a)google.com> --- M MAINTAINERS 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/05/77205/1 diff --git a/MAINTAINERS b/MAINTAINERS index 905696f..f1e350e 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -96,6 +96,7 @@ FLASHCHIPS M: Anastasia Klimchuk <aklm(a)chromium.org> +M: Nikolai Artemiev <nartemiev(a)google.com> S: Maintained F: flashchips* F: include/flashchips* -- To view, visit https://review.coreboot.org/c/flashrom/+/77205?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Iba4ae742f6500ef26edfc976d842ede656b916d4 Gerrit-Change-Number: 77205 Gerrit-PatchSet: 1 Gerrit-Owner: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-MessageType: newchange

1 0

Change in flashrom[master]: flashchips: Add ISSI IS25LQ016
by Angel Pons (Code Review) 15 Aug '23

15 Aug '23

Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/40431 ) Change subject: flashchips: Add ISSI IS25LQ016 ...................................................................... flashchips: Add ISSI IS25LQ016 Datasheet: http://www.issi.com/WW/pdf/25LQ016.pdf Tested all four PREW functions with a FT2232H. Change-Id: I02f19767b8a60fb2d37adab34894b6edb6ac4494 Signed-off-by: Angel Pons <th3fanbus(a)gmail.com> --- M flashchips.c M flashchips.h 2 files changed, 39 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/31/40431/1 diff --git a/flashchips.c b/flashchips.c index b4006df..a25f915 100644 --- a/flashchips.c +++ b/flashchips.c @@ -7049,6 +7049,44 @@ { .vendor = "ISSI", + .name = "IS25LQ016", + .bustype = BUS_SPI, + .manufacture_id = ISSI_ID_SPI, + .model_id = ISSI_IS25LQ016, + .total_size = 2048, + .page_size = 256, + /* OTP: 1024B total; read 0x4b; write 0xb1 */ + .feature_bits = FEATURE_WRSR_WREN | FEATURE_OTP | FEATURE_QPI, + .tested = TEST_OK_PREW, + .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, + .block_erasers = + { + { + .eraseblocks = { {4 * 1024, 512} }, + .block_erase = spi_block_erase_20, + }, { + .eraseblocks = { {4 * 1024, 512} }, + .block_erase = spi_block_erase_d7, + }, { + .eraseblocks = { {64 * 1024, 32} }, + .block_erase = spi_block_erase_d8, + }, { + .eraseblocks = { {2 * 1024 * 1024, 1} }, + .block_erase = spi_block_erase_60, + }, { + .eraseblocks = { {2 * 1024 * 1024, 1} }, + .block_erase = spi_block_erase_c7, + } + }, + .unlock = spi_disable_blockprotect, + .write = spi_chip_write_256, + .read = spi_chip_read, + .voltage = {2300, 3600}, + }, + + { + .vendor = "ISSI", .name = "IS25WP032", .bustype = BUS_SPI, .manufacture_id = ISSI_ID_SPI, diff --git a/flashchips.h b/flashchips.h index e5ef390..b5c0aeb 100644 --- a/flashchips.h +++ b/flashchips.h @@ -459,6 +459,7 @@ #define ISSI_IS25LP064 0x6017 #define ISSI_IS25LP128 0x6018 #define ISSI_IS25LP256 0x6019 +#define ISSI_IS25LQ016 0x1445 #define ISSI_IS25WP032 0x7016 #define ISSI_IS25WP064 0x7017 #define ISSI_IS25WP128 0x7018 -- To view, visit https://review.coreboot.org/c/flashrom/+/40431 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I02f19767b8a60fb2d37adab34894b6edb6ac4494 Gerrit-Change-Number: 40431 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: newchange

6 8

[S] Change in flashrom[master]: Remove dependency on C23 __has_include()
by Anton Samsonov (Code Review) 08 Aug '23

08 Aug '23

Anton Samsonov has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/77089?usp=email ) Change subject: Remove dependency on C23 __has_include() ...................................................................... Remove dependency on C23 __has_include() Clang, GCC and C23-aware compilers will still use `__has_include()` to check for header presence. Old and alternative compilers will fall back to unconditional inclusion, unless user-supplied macros `HAVE_GETOPT_H` and `HAVE_PCIUTILS_PCI_H` are defined as 1 or 0. Change-Id: Ic544963ffd29626ae0a21bdddb1c78850cc43ec6 Signed-off-by: Anton Samsonov <devel(a)zxlab.ru> --- M include/cli_classic.h M include/platform/pci.h 2 files changed, 22 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/89/77089/1 diff --git a/include/cli_classic.h b/include/cli_classic.h index e651cc6..7e2848b 100644 --- a/include/cli_classic.h +++ b/include/cli_classic.h @@ -15,9 +15,21 @@ #ifndef CLI_CLASSIC_H #define CLI_CLASSIC_H -#if __has_include(<getopt.h>) +#if HAVE_GETOPT_H #include <getopt.h> +#elif !defined(HAVE_GETOPT_H) +#if !defined(__has_include) && (__STDC_VERSION__ < 202300L) +#include <getopt.h> +#define HAVE_GETOPT_H 1 +#elif __has_include(<getopt.h>) +#include <getopt.h> +#define HAVE_GETOPT_H 1 #else +#define HAVE_GETOPT_H 0 +#endif /* __has_include() */ +#endif /* HAVE_GETOPT_H */ + +#if !HAVE_GETOPT_H #define no_argument 0 #define required_argument 1 @@ -39,5 +51,5 @@ int getopt_long_only (int argc, char *const *argv, const char *shortopts, const struct option *longopts, int *longind); -#endif /* __has_include() */ +#endif /* HAVE_GETOPT_H */ #endif /* CLI_CLASSIC_H */ diff --git a/include/platform/pci.h b/include/platform/pci.h index 4ac108f..5e350ac 100644 --- a/include/platform/pci.h +++ b/include/platform/pci.h @@ -22,10 +22,16 @@ * e.g. NetBSD 9.0 on sparc64 pciutils-3.7.0nb2. * Other NetBSD platforms and versions uses the default path under pci/pci.h */ -#if __has_include(<pciutils/pci.h>) +#if !defined(__has_include) && (__STDC_VERSION__ < 202300L) +#if HAVE_PCIUTILS_PCI_H #include <pciutils/pci.h> #else #include <pci/pci.h> -#endif +#endif /* HAVE_PCIUTILS_PCI_H */ +#elif __has_include(<pciutils/pci.h>) +#include <pciutils/pci.h> +#else +#include <pci/pci.h> +#endif /* __has_include(<pciutils/pci.h>) */ #endif /* __PLATFORM_PCI_H__ */ -- To view, visit https://review.coreboot.org/c/flashrom/+/77089?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ic544963ffd29626ae0a21bdddb1c78850cc43ec6 Gerrit-Change-Number: 77089 Gerrit-PatchSet: 1 Gerrit-Owner: Anton Samsonov <devel(a)zxlab.ru> Gerrit-MessageType: newchange

1 0

[M] Change in flashrom[master]: doc: Add code of conduct
by Anastasia Klimchuk (Code Review) 08 Aug '23

08 Aug '23

Attention is currently required from: Alexander Goncharov, Angel Pons, Carl-Daniel Hailfinger, Martin L Roth, Patrick Georgi, Peter Marheine, Stefan Reinauer, Thomas Heijligen. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/76455?usp=email ) Change subject: doc: Add code of conduct ...................................................................... Patch Set 3: (1 comment) Patchset: PS2: > This patch is not merged either. […] CB:75554 merged with no changes to the wording, so this patch already contains the final version (see here https://doc.coreboot.org/community/code_of_conduct.html) I am resolving this comment. -- To view, visit https://review.coreboot.org/c/flashrom/+/76455?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ic4c646bc47d5db4d064a411d60a44f16559dfcee Gerrit-Change-Number: 76455 Gerrit-PatchSet: 3 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Martin L Roth <gaumless(a)gmail.com> Gerrit-CC: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Attention: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Attention: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Comment-Date: Tue, 08 Aug 2023 12:08:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Patrick Georgi <patrick(a)coreboot.org> Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Comment-In-Reply-To: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Comment-In-Reply-To: Peter Marheine <pmarheine(a)chromium.org> Gerrit-MessageType: comment

1 0

[XS] Change in flashrom[master]: doc: Fix broken link to old mailing list archives on pipermail
by Patrick Georgi (Code Review) 08 Aug '23

08 Aug '23

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/flashrom/+/76961?usp=email ) Change subject: doc: Fix broken link to old mailing list archives on pipermail ...................................................................... doc: Fix broken link to old mailing list archives on pipermail Change-Id: I3e88d5a86dabd453f2de9bbacf6054534bc3901a Signed-off-by: Anastasia Klimchuk <aklm(a)flashrom.org> Reviewed-on: https://review.coreboot.org/c/flashrom/+/76961 Reviewed-by: Patrick Georgi <patrick(a)coreboot.org> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M doc/contact.rst 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Patrick Georgi: Looks good to me, approved build bot (Jenkins): Verified diff --git a/doc/contact.rst b/doc/contact.rst index 220d73f..5bcac3f 100644 --- a/doc/contact.rst +++ b/doc/contact.rst @@ -23,7 +23,7 @@ Archives """""""" | https://mail.coreboot.org/hyperkitty/list/flashrom@flashrom.org/ -| https://www.flashrom.org/pipermail/flashrom/ (Up to Dec. 2018) +| https://mail.coreboot.org/pipermail/flashrom/ (Up to Dec. 2018) | https://marc.info/?l=flashrom | https://www.mail-archive.com/flashrom@flashrom.org/ -- To view, visit https://review.coreboot.org/c/flashrom/+/76961?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I3e88d5a86dabd453f2de9bbacf6054534bc3901a Gerrit-Change-Number: 76961 Gerrit-PatchSet: 2 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[S] Change in flashrom[master]: Remove dependency on C23's __has_include()
by Anton Samsonov (Code Review) 07 Aug '23

07 Aug '23

Anton Samsonov has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/77043?usp=email ) Change subject: Remove dependency on C23's __has_include() ...................................................................... Remove dependency on C23's __has_include() Change-Id: Ifaeb46127785af86e69852152783f75d241b1266 --- M include/cli_classic.h M include/platform/pci.h 2 files changed, 22 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/43/77043/1 diff --git a/include/cli_classic.h b/include/cli_classic.h index e651cc6..5b1ab6b 100644 --- a/include/cli_classic.h +++ b/include/cli_classic.h @@ -15,9 +15,21 @@ #ifndef CLI_CLASSIC_H #define CLI_CLASSIC_H -#if __has_include(<getopt.h>) +#if HAVE_GETOPT_H #include <getopt.h> +#elif !defined(HAVE_GETOPT_H) +#if !defined(__has_include) || (__STDC_VERSION__ < 202300L) +#include <getopt.h> +#define HAVE_GETOPT_H 1 +#elif __has_include(<getopt.h>) +#include <getopt.h> +#define HAVE_GETOPT_H 1 #else +#define HAVE_GETOPT_H 0 +#endif /* __has_include() */ +#endif /* HAVE_GETOPT_H */ + +#if !HAVE_GETOPT_H #define no_argument 0 #define required_argument 1 @@ -39,5 +51,5 @@ int getopt_long_only (int argc, char *const *argv, const char *shortopts, const struct option *longopts, int *longind); -#endif /* __has_include() */ +#endif /* HAVE_GETOPT_H */ #endif /* CLI_CLASSIC_H */ diff --git a/include/platform/pci.h b/include/platform/pci.h index 4ac108f..5e350ac 100644 --- a/include/platform/pci.h +++ b/include/platform/pci.h @@ -22,10 +22,16 @@ * e.g. NetBSD 9.0 on sparc64 pciutils-3.7.0nb2. * Other NetBSD platforms and versions uses the default path under pci/pci.h */ -#if __has_include(<pciutils/pci.h>) +#if !defined(__has_include) && (__STDC_VERSION__ < 202300L) +#if HAVE_PCIUTILS_PCI_H #include <pciutils/pci.h> #else #include <pci/pci.h> -#endif +#endif /* HAVE_PCIUTILS_PCI_H */ +#elif __has_include(<pciutils/pci.h>) +#include <pciutils/pci.h> +#else +#include <pci/pci.h> +#endif /* __has_include(<pciutils/pci.h>) */ #endif /* __PLATFORM_PCI_H__ */ -- To view, visit https://review.coreboot.org/c/flashrom/+/77043?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ifaeb46127785af86e69852152783f75d241b1266 Gerrit-Change-Number: 77043 Gerrit-PatchSet: 1 Gerrit-Owner: Anton Samsonov <devel(a)zxlab.ru> Gerrit-MessageType: newchange

1 0

[XS] Change in flashrom[master]: doc: Add link to flashrom patches to dev guide
by Peter Marheine (Code Review) 07 Aug '23

07 Aug '23

Peter Marheine has submitted this change. ( https://review.coreboot.org/c/flashrom/+/76771?usp=email ) Change subject: doc: Add link to flashrom patches to dev guide ...................................................................... doc: Add link to flashrom patches to dev guide People might be interested in what's currently ongoing in development, and even more practically, have a look at examples before creating their own patch. In fact, the latter is a good idea to do. Giving the link in the intro of dev guide will encourage that. Viewing the patches does not require an account, so can be done at the very beginning. Change-Id: Iecd31a5e9a3683480b33fb9ba331545a0cf669b4 Signed-off-by: Anastasia Klimchuk <aklm(a)flashrom.org> Reviewed-on: https://review.coreboot.org/c/flashrom/+/76771 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Peter Marheine <pmarheine(a)chromium.org> --- M doc/dev_guide/development_guide.rst 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Peter Marheine: Looks good to me, approved build bot (Jenkins): Verified diff --git a/doc/dev_guide/development_guide.rst b/doc/dev_guide/development_guide.rst index 950fa91..40837a9 100644 --- a/doc/dev_guide/development_guide.rst +++ b/doc/dev_guide/development_guide.rst @@ -13,6 +13,7 @@ adjusted and you avoid frustration if there is some disagreement about the design. +You can `look at the latest flashrom development efforts in Gerrit <https://review.coreboot.org/q/project:flashrom>`_. Set up the git repository and dev environment ============================================= -- To view, visit https://review.coreboot.org/c/flashrom/+/76771?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Iecd31a5e9a3683480b33fb9ba331545a0cf669b4 Gerrit-Change-Number: 76771 Gerrit-PatchSet: 3 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[XS] Change in flashrom[master]: MAINTAINERS: Fix the link to dev guides and simplify the paragraph
by Anastasia Klimchuk (Code Review) 06 Aug '23

06 Aug '23

Anastasia Klimchuk has submitted this change. ( https://review.coreboot.org/c/flashrom/+/76828?usp=email ) Change subject: MAINTAINERS: Fix the link to dev guides and simplify the paragraph ...................................................................... MAINTAINERS: Fix the link to dev guides and simplify the paragraph We can just say "follow the dev guide" here, the rest of information should be in the dev guide. Change-Id: Idf4df7426e5cf080416ba6691c7f11260c2b4623 Signed-off-by: Anastasia Klimchuk <aklm(a)flashrom.org> Reviewed-on: https://review.coreboot.org/c/flashrom/+/76828 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> --- M MAINTAINERS 1 file changed, 2 insertions(+), 5 deletions(-) Approvals: build bot (Jenkins): Verified Sergii Dmytruk: Looks good to me, approved diff --git a/MAINTAINERS b/MAINTAINERS index e3aeef0..905696f 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -9,11 +9,8 @@ it's often a good choice to look at the git history to see who worked on it last. -Please try to follow our [development guidelines]. This will make things -easier on the maintainers. Not all of these guidelines matter for every -trivial patch. So apply some common sense. - -[development guidelines]: https://www.flashrom.org/Development_Guidelines +Please follow our development guide: +https://www.flashrom.org/dev_guide/development_guide.html Happy hacking! -- To view, visit https://review.coreboot.org/c/flashrom/+/76828?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Idf4df7426e5cf080416ba6691c7f11260c2b4623 Gerrit-Change-Number: 76828 Gerrit-PatchSet: 3 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit August 2023