August 2023 - flashrom-gerrit - mail.coreboot.org

[XS] Change in flashrom[master]: doc: Fix broken link to old mailing list archives on pipermail
by Anastasia Klimchuk (Code Review) 05 Aug '23

05 Aug '23

Attention is currently required from: Stefan Reinauer, Thomas Heijligen. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/76961?usp=email ) Change subject: doc: Fix broken link to old mailing list archives on pipermail ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > oops, I guess that's one for the redirects (in addition to fixing the links)? Yes! I added to the list of redirects, which I am going to send to you very soon :) the list of not long, but it will get a bit longer later. -- To view, visit https://review.coreboot.org/c/flashrom/+/76961?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I3e88d5a86dabd453f2de9bbacf6054534bc3901a Gerrit-Change-Number: 76961 Gerrit-PatchSet: 1 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Comment-Date: Sat, 05 Aug 2023 09:40:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Patrick Georgi <patrick(a)coreboot.org> Gerrit-MessageType: comment

1 0

[XS] Change in flashrom[master]: doc: Fix broken link to old mailing list archives on pipermail
by Patrick Georgi (Code Review) 05 Aug '23

05 Aug '23

Attention is currently required from: Anastasia Klimchuk, Stefan Reinauer, Thomas Heijligen. Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/76961?usp=email ) Change subject: doc: Fix broken link to old mailing list archives on pipermail ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Patchset: PS1: oops, I guess that's one for the redirects (in addition to fixing the links)? -- To view, visit https://review.coreboot.org/c/flashrom/+/76961?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I3e88d5a86dabd453f2de9bbacf6054534bc3901a Gerrit-Change-Number: 76961 Gerrit-PatchSet: 1 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Sat, 05 Aug 2023 09:30:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in flashrom[master]: doc: Fix broken link to old mailing list archives on pipermail
by Anastasia Klimchuk (Code Review) 05 Aug '23

05 Aug '23

Anastasia Klimchuk has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/76961?usp=email ) Change subject: doc: Fix broken link to old mailing list archives on pipermail ...................................................................... doc: Fix broken link to old mailing list archives on pipermail Change-Id: I3e88d5a86dabd453f2de9bbacf6054534bc3901a Signed-off-by: Anastasia Klimchuk <aklm(a)flashrom.org> --- M doc/contact.rst 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/61/76961/1 diff --git a/doc/contact.rst b/doc/contact.rst index 220d73f..5bcac3f 100644 --- a/doc/contact.rst +++ b/doc/contact.rst @@ -23,7 +23,7 @@ Archives """""""" | https://mail.coreboot.org/hyperkitty/list/flashrom@flashrom.org/ -| https://www.flashrom.org/pipermail/flashrom/ (Up to Dec. 2018) +| https://mail.coreboot.org/pipermail/flashrom/ (Up to Dec. 2018) | https://marc.info/?l=flashrom | https://www.mail-archive.com/flashrom@flashrom.org/ -- To view, visit https://review.coreboot.org/c/flashrom/+/76961?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I3e88d5a86dabd453f2de9bbacf6054534bc3901a Gerrit-Change-Number: 76961 Gerrit-PatchSet: 1 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: newchange

1 0

[M] Change in flashrom[master]: flashchips: Add support for MXIC MX2525643G It is similar to the MX25...
by Anastasia Klimchuk (Code Review) 05 Aug '23

05 Aug '23

Attention is currently required from: Name of user not set #1005084. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/76853?usp=email ) Change subject: flashchips: Add support for MXIC MX2525643G It is similar to the MX2525635F and shares its RDID. ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: xianzheng, thank you for the patch. I can't open datasheet by the link, not found. Does the link you provided open for you? -- To view, visit https://review.coreboot.org/c/flashrom/+/76853?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ie04a5e2325aab94bffb276675be3fa4a88c6e134 Gerrit-Change-Number: 76853 Gerrit-PatchSet: 1 Gerrit-Owner: Name of user not set #1005084 Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Name of user not set #1005084 Gerrit-Comment-Date: Sat, 05 Aug 2023 08:01:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[XS] Change in flashrom[master]: doc: Add link to old wiki in the side menu
by Anastasia Klimchuk (Code Review) 04 Aug '23

04 Aug '23

Anastasia Klimchuk has submitted this change. ( https://review.coreboot.org/c/flashrom/+/76772?usp=email ) Change subject: doc: Add link to old wiki in the side menu ...................................................................... doc: Add link to old wiki in the side menu While the process of migrating pages is ongoing, wiki can be useful and is available in view-only mode. Change-Id: I093dcb1d4ce2b3feeff61115e037cfa8075a8a52 Signed-off-by: Anastasia Klimchuk <aklm(a)flashrom.org> Reviewed-on: https://review.coreboot.org/c/flashrom/+/76772 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> --- M doc/index.rst 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified Stefan Reinauer: Looks good to me, approved diff --git a/doc/index.rst b/doc/index.rst index d308155..cc58183 100644 --- a/doc/index.rst +++ b/doc/index.rst @@ -12,6 +12,7 @@ about_flashrom/index how_to_add_docs documentation_license + Old wiki website <https://wiki.flashrom.org/> .. include:: intro.rst -- To view, visit https://review.coreboot.org/c/flashrom/+/76772?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I093dcb1d4ce2b3feeff61115e037cfa8075a8a52 Gerrit-Change-Number: 76772 Gerrit-PatchSet: 3 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[XS] Change in flashrom[master]: website/gh workflow: Resolve 404 links
by Anastasia Klimchuk (Code Review) 04 Aug '23

04 Aug '23

Anastasia Klimchuk has submitted this change. ( https://review.coreboot.org/c/flashrom/+/76821?usp=email ) ( 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: website/gh workflow: Resolve 404 links ...................................................................... website/gh workflow: Resolve 404 links Fix broken links to dev guide and contact page Change-Id: Ide4a675049ff245e46001da1c7ef5769baf5a14e Signed-off-by: Anastasia Klimchuk <aklm(a)flashrom.org> Reviewed-on: https://review.coreboot.org/c/flashrom/+/76821 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Edward O'Callaghan <quasisec(a)chromium.org> --- M .github/workflows/lockdown.yml 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: Edward O'Callaghan: Looks good to me, approved build bot (Jenkins): Verified diff --git a/.github/workflows/lockdown.yml b/.github/workflows/lockdown.yml index 39b6548..f92e086 100644 --- a/.github/workflows/lockdown.yml +++ b/.github/workflows/lockdown.yml @@ -20,17 +20,17 @@ Thank you for your contribution. The flashrom project does not handle GitHub issues or pull requests, since this repository on GitHub is just a mirror of our actual repository. Thus, we would like to - encourage you to have a look at on our [development guidelines](https://www.flashrom.org/Development_Guidelines) + encourage you to have a look at on our [development guide](https://www.flashrom.org/dev_guide/development_guide.html) and submit your patch to [review.coreboot.org](https://review.coreboot.org/q/project:flashrom). Issues are handled over our [ticket system](https://ticket.coreboot.org/projects/flashrom). If you have questions, feel free to reach out to us. There are - multiple ways to [contact us](https://www.flashrom.org/Contact). + multiple ways to [contact us](https://www.flashrom.org/contact.html). pr-comment: > Thank you for your contribution. The flashrom project does not handle GitHub issues or pull requests, since this repository on GitHub is just a mirror of our actual repository. Thus, we would like to - encourage you to have a look at on our [development guidelines](https://www.flashrom.org/Development_Guidelines) + encourage you to have a look at on our [development guide](https://www.flashrom.org/dev_guide/development_guide.html) and submit your patch to [review.coreboot.org](https://review.coreboot.org/q/project:flashrom). Issues are handled over our [ticket system](https://ticket.coreboot.org/projects/flashrom). If you have questions, feel free to reach out to us. There are - multiple ways to [contact us](https://www.flashrom.org/Contact). + multiple ways to [contact us](https://www.flashrom.org/contact.html). -- To view, visit https://review.coreboot.org/c/flashrom/+/76821?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ide4a675049ff245e46001da1c7ef5769baf5a14e Gerrit-Change-Number: 76821 Gerrit-PatchSet: 3 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[XS] Change in flashrom[master]: doc: Add link to flashrom patches to dev guide
by Peter Marheine (Code Review) 03 Aug '23

03 Aug '23

Attention is currently required from: Anastasia Klimchuk, Angel Pons, Thomas Heijligen. Peter Marheine has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/76771?usp=email ) Change subject: doc: Add link to flashrom patches to dev guide ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/76771?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Iecd31a5e9a3683480b33fb9ba331545a0cf669b4 Gerrit-Change-Number: 76771 Gerrit-PatchSet: 2 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Thu, 03 Aug 2023 00:14:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in flashrom[master]: MAINTAINERS: Fix the link to dev guides and simplify the paragraph
by Sergii Dmytruk (Code Review) 02 Aug '23

02 Aug '23

Attention is currently required from: Anastasia Klimchuk. Sergii Dmytruk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/76828?usp=email ) Change subject: MAINTAINERS: Fix the link to dev guides and simplify the paragraph ...................................................................... Patch Set 2: Code-Review+2 (1 comment) File MAINTAINERS: https://review.coreboot.org/c/flashrom/+/76828/comment/309d9cf8_1aa0bd7d : PS1, Line 12: [development guide] > Yes! And I am not sure why they were there in the first place. It was a Markdown-style URL reference. -- To view, visit https://review.coreboot.org/c/flashrom/+/76828?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Idf4df7426e5cf080416ba6691c7f11260c2b4623 Gerrit-Change-Number: 76828 Gerrit-PatchSet: 2 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Wed, 02 Aug 2023 12:53:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Comment-In-Reply-To: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-MessageType: comment

1 0

[XS] Change in flashrom[master]: doc: Add link to flashrom patches to dev guide
by Anastasia Klimchuk (Code Review) 02 Aug '23

02 Aug '23

Attention is currently required from: Angel Pons, Peter Marheine, Thomas Heijligen. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/76771?usp=email ) Change subject: doc: Add link to flashrom patches to dev guide ...................................................................... Patch Set 2: (1 comment) File doc/dev_guide/development_guide.rst: https://review.coreboot.org/c/flashrom/+/76771/comment/5f9931f5_144ce81d : PS1, Line 16: here > Link text "here" is bad for accessibility; the text of the link should be descriptive. […] That's a good point, Done. -- To view, visit https://review.coreboot.org/c/flashrom/+/76771?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Iecd31a5e9a3683480b33fb9ba331545a0cf669b4 Gerrit-Change-Number: 76771 Gerrit-PatchSet: 2 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Comment-Date: Wed, 02 Aug 2023 08:59:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Peter Marheine <pmarheine(a)chromium.org> Gerrit-MessageType: comment

1 0

[XS] Change in flashrom[master]: doc: Add link to flashrom patches to dev guide
by Anastasia Klimchuk (Code Review) 02 Aug '23

02 Aug '23

Attention is currently required from: Anastasia Klimchuk, Angel Pons, Thomas Heijligen. Hello Angel Pons, Peter Marheine, Thomas Heijligen, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/76771?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: doc: Add link to flashrom patches to dev guide ...................................................................... doc: Add link to flashrom patches to dev guide People might be interested in what's currently ongoing in development, and even more practically, have a look at examples before creating their own patch. In fact, the latter is a good idea to do. Giving the link in the intro of dev guide will encourage that. Viewing the patches does not require an account, so can be done at the very beginning. Change-Id: Iecd31a5e9a3683480b33fb9ba331545a0cf669b4 Signed-off-by: Anastasia Klimchuk <aklm(a)flashrom.org> --- M doc/dev_guide/development_guide.rst 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/71/76771/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/76771?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Iecd31a5e9a3683480b33fb9ba331545a0cf669b4 Gerrit-Change-Number: 76771 Gerrit-PatchSet: 2 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit August 2023