August 2023 - flashrom-gerrit - mail.coreboot.org

[XS] Change in flashrom[master]: doc: Add flashrom logo to index page
by Anastasia Klimchuk (Code Review) 18 Aug '23

18 Aug '23

Attention is currently required from: Alexander Goncharov, Stefan Reinauer, Thomas Heijligen. Hello Alexander Goncharov, Stefan Reinauer, Thomas Heijligen, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/77250?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+2 by Stefan Reinauer, Verified+1 by build bot (Jenkins) Change subject: doc: Add flashrom logo to index page ...................................................................... doc: Add flashrom logo to index page Change-Id: I44a35b16a29b850e2b49d6e75c52d80b17bf7f75 Signed-off-by: Anastasia Klimchuk <aklm(a)flashrom.org> --- M doc/index.rst 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/50/77250/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/77250?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I44a35b16a29b850e2b49d6e75c52d80b17bf7f75 Gerrit-Change-Number: 77250 Gerrit-PatchSet: 2 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Alexander Goncharov <chat(a)joursoir.net> Gerrit-MessageType: newpatchset

1 0

[XS] Change in flashrom[master]: doc: Add flashrom logo to index page
by Anastasia Klimchuk (Code Review) 18 Aug '23

18 Aug '23

Attention is currently required from: Alexander Goncharov, Thomas Heijligen. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/77250?usp=email ) Change subject: doc: Add flashrom logo to index page ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: This patch should wait for CB:77249 to be merged. Adding comment because Gerrit thinks it's ready. -- To view, visit https://review.coreboot.org/c/flashrom/+/77250?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I44a35b16a29b850e2b49d6e75c52d80b17bf7f75 Gerrit-Change-Number: 77250 Gerrit-PatchSet: 1 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Comment-Date: Fri, 18 Aug 2023 00:11:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[L] Change in flashrom[master]: doc: Copy logo files into flashrom repository
by Anastasia Klimchuk (Code Review) 18 Aug '23

18 Aug '23

Attention is currently required from: Alexander Goncharov, Stefan Reinauer, Thomas Heijligen. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/77249?usp=email ) Change subject: doc: Copy logo files into flashrom repository ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > maybe it is enough to just add the SVG rather than all of the rendered images? Initially I just copied the whole directory without thinking about it. Now you made me thinking! :) I think, better have the whole directory because maybe we will need different images for different pages (for example)? I now started doubting that I used the right image in the next patch :\ I need to have another look. In general it's easier to have the whole dir and use any image or change them if needed, VS copying one at a time. Would you agree? -- To view, visit https://review.coreboot.org/c/flashrom/+/77249?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I38c1d820be92f2688c5fc4c63a150ab324d8b647 Gerrit-Change-Number: 77249 Gerrit-PatchSet: 1 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Comment-Date: Fri, 18 Aug 2023 00:09:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-MessageType: comment

1 0

[XS] Change in flashrom[master]: MAINTAINERS: Add Stefan Reinauer to flashchips
by Anastasia Klimchuk (Code Review) 18 Aug '23

18 Aug '23

Attention is currently required from: Stefan Reinauer. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/77273?usp=email ) Change subject: MAINTAINERS: Add Stefan Reinauer to flashchips ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/77273?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ib1f79d06cebf0f091382c857da0be2f5d7a73581 Gerrit-Change-Number: 77273 Gerrit-PatchSet: 2 Gerrit-Owner: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Comment-Date: Thu, 17 Aug 2023 22:39:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in flashrom[master]: MAINTAINERS: Add Martin Roth for AMD SPI
by Anastasia Klimchuk (Code Review) 18 Aug '23

18 Aug '23

Attention is currently required from: Edward O'Callaghan, Martin L Roth, Martin Roth. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/74954?usp=email ) Change subject: MAINTAINERS: Add Martin Roth for AMD SPI ...................................................................... Patch Set 4: Code-Review+2 (1 comment) File MAINTAINERS: https://review.coreboot.org/c/flashrom/+/74954/comment/105e3682_d0a69204 : PS4, Line 137: gaumless(a)tutanota.com Just to check, does Gerrit know about this email, do you have this email on Gerrit account? so that it can add you to the patch automatically if there is a change in the file -- To view, visit https://review.coreboot.org/c/flashrom/+/74954?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I27a07be1549ef070ad72b8e657d72170c7e85620 Gerrit-Change-Number: 74954 Gerrit-PatchSet: 4 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Comment-Date: Thu, 17 Aug 2023 22:39:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in flashrom[master]: MAINTAINERS: Add Stefan Reinauer to flashchips
by Stefan Reinauer (Code Review) 17 Aug '23

17 Aug '23

Attention is currently required from: Anastasia Klimchuk. Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/77273?usp=email ) Change subject: MAINTAINERS: Add Stefan Reinauer to flashchips ...................................................................... Patch Set 2: (1 comment) Commit Message: https://review.coreboot.org/c/flashrom/+/77273/comment/276a5a8e_b0d93529 : PS1, Line 7: Add Stefan to flashchips > We decided in the very beginning, to also put last name into commit title, so that commit title is f […] Done -- To view, visit https://review.coreboot.org/c/flashrom/+/77273?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ib1f79d06cebf0f091382c857da0be2f5d7a73581 Gerrit-Change-Number: 77273 Gerrit-PatchSet: 2 Gerrit-Owner: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Thu, 17 Aug 2023 18:17:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: comment

1 0

[XS] Change in flashrom[master]: MAINTAINERS: Add Martin Roth for AMD SPI
by Martin L Roth (Code Review) 17 Aug '23

17 Aug '23

Attention is currently required from: Anastasia Klimchuk, Edward O'Callaghan, Martin Roth. Hello Anastasia Klimchuk, Edward O'Callaghan, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/74954?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: MAINTAINERS: Add Martin Roth for AMD SPI ...................................................................... MAINTAINERS: Add Martin Roth for AMD SPI Signed-off-by: Martin Roth <gaumless(a)gmail.com> Change-Id: I27a07be1549ef070ad72b8e657d72170c7e85620 --- M MAINTAINERS 1 file changed, 5 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/54/74954/4 -- To view, visit https://review.coreboot.org/c/flashrom/+/74954?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I27a07be1549ef070ad72b8e657d72170c7e85620 Gerrit-Change-Number: 74954 Gerrit-PatchSet: 4 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-MessageType: newpatchset

1 0

[XS] Change in flashrom[master]: MAINTAINERS: Add Martin Roth for AMD SPI
by Martin L Roth (Code Review) 17 Aug '23

17 Aug '23

Attention is currently required from: Anastasia Klimchuk, Edward O'Callaghan, Martin Roth. Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/74954?usp=email ) Change subject: MAINTAINERS: Add Martin Roth for AMD SPI ...................................................................... Patch Set 3: (1 comment) Commit Message: https://review.coreboot.org/c/flashrom/+/74954/comment/d85207e7_a99c07bb : PS1, Line 7: as reviewer > I think, drop "as reviewer", we don't use it in commit messages for this file. Done -- To view, visit https://review.coreboot.org/c/flashrom/+/74954?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I27a07be1549ef070ad72b8e657d72170c7e85620 Gerrit-Change-Number: 74954 Gerrit-PatchSet: 3 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Comment-Date: Thu, 17 Aug 2023 16:38:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: comment

1 0

[XS] Change in flashrom[master]: MAINTAINERS: Add Martin Roth for AMD SPI
by Martin L Roth (Code Review) 17 Aug '23

17 Aug '23

Attention is currently required from: Anastasia Klimchuk, Edward O'Callaghan, Martin Roth. Hello Anastasia Klimchuk, Edward O'Callaghan, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/74954?usp=email to look at the new patch set (#3). Change subject: MAINTAINERS: Add Martin Roth for AMD SPI ...................................................................... MAINTAINERS: Add Martin Roth for AMD SPI Signed-off-by: Martin Roth <gaumless(a)gmail.com> Change-Id: I27a07be1549ef070ad72b8e657d72170c7e85620 --- M MAINTAINERS 1 file changed, 5 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/54/74954/3 -- To view, visit https://review.coreboot.org/c/flashrom/+/74954?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I27a07be1549ef070ad72b8e657d72170c7e85620 Gerrit-Change-Number: 74954 Gerrit-PatchSet: 3 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-MessageType: newpatchset

1 0

[XS] Change in flashrom[master]: MAINTAINERS: Add Martin Roth as reviewer for AMD SPI
by Martin L Roth (Code Review) 17 Aug '23

17 Aug '23

Attention is currently required from: Anastasia Klimchuk, Edward O'Callaghan, Martin Roth. Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/74954?usp=email ) Change subject: MAINTAINERS: Add Martin Roth as reviewer for AMD SPI ...................................................................... Patch Set 2: (1 comment) File MAINTAINERS: https://review.coreboot.org/c/flashrom/+/74954/comment/8e81892a_3c740982 : PS1, Line 133: R: > Martin maybe you would agree to be `M:` ? There can be multiple people on the same item. Done -- To view, visit https://review.coreboot.org/c/flashrom/+/74954?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I27a07be1549ef070ad72b8e657d72170c7e85620 Gerrit-Change-Number: 74954 Gerrit-PatchSet: 2 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Comment-Date: Thu, 17 Aug 2023 16:38:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: comment

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit August 2023