August 2023 - flashrom-gerrit - mail.coreboot.org

[S] Change in flashrom[master]: doc: Add Emergency help red box to the intro
by Anastasia Klimchuk (Code Review) 24 Aug '23

24 Aug '23

Anastasia Klimchuk has submitted this change. ( https://review.coreboot.org/c/flashrom/+/77292?usp=email ) Change subject: doc: Add Emergency help red box to the intro ...................................................................... doc: Add Emergency help red box to the intro Change-Id: Id7570b7f0773ec0e43662272e642bc807c8210c2 Signed-off-by: Anastasia Klimchuk <aklm(a)flashrom.org> Reviewed-on: https://review.coreboot.org/c/flashrom/+/77292 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Peter Marheine <pmarheine(a)chromium.org> --- M doc/intro.rst 1 file changed, 10 insertions(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified Peter Marheine: Looks good to me, approved diff --git a/doc/intro.rst b/doc/intro.rst index 254555a..b1fe99a 100644 --- a/doc/intro.rst +++ b/doc/intro.rst @@ -22,3 +22,13 @@ no "BIOS flashing"). .. todo:: Convert Technology page and add links here + +.. container:: danger, admonition + + **Emergency help** + + IMPORTANT: If something went wrong during flashing, do NOT turn off/reboot your computer. + Instead, let us help you recover. We can be contacted via `IRC <https://www.flashrom.org/contact.html#irc>`_ + (#flashrom on `libera.chat <irc://irc.libera.chat/#flashrom>`_, `webchat <https://web.libera.chat/#flashrom>`_), + `Discord <https://www.flashrom.org/contact.html#discord>`_, or `email <https://www.flashrom.org/contact.html#mailing-list-1>`_. + Please allow some time until someone responds, we're all volunteers. -- To view, visit https://review.coreboot.org/c/flashrom/+/77292?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Id7570b7f0773ec0e43662272e642bc807c8210c2 Gerrit-Change-Number: 77292 Gerrit-PatchSet: 2 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[XS] Change in flashrom[master]: MAINTAINERS: Add Martin Roth for AMD SPI
by Anastasia Klimchuk (Code Review) 24 Aug '23

24 Aug '23

Anastasia Klimchuk has submitted this change. ( https://review.coreboot.org/c/flashrom/+/74954?usp=email ) ( 4 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: MAINTAINERS: Add Martin Roth for AMD SPI ...................................................................... MAINTAINERS: Add Martin Roth for AMD SPI Signed-off-by: Martin Roth <gaumless(a)gmail.com> Change-Id: I27a07be1549ef070ad72b8e657d72170c7e85620 Reviewed-on: https://review.coreboot.org/c/flashrom/+/74954 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Anastasia Klimchuk <aklm(a)chromium.org> --- M MAINTAINERS 1 file changed, 5 insertions(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified Anastasia Klimchuk: Looks good to me, approved diff --git a/MAINTAINERS b/MAINTAINERS index 266e63a..40aa3ed 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -133,6 +133,11 @@ # PROGRAMMERS ################################################################################ +AMD SB600SPI +M: Martin Roth <gaumless(a)tutanota.com> +S: Maintained +F: sb600spi.c + CH347 M: Nicholas Chin <nic.c3.14(a)gmail.com> S: Maintained -- To view, visit https://review.coreboot.org/c/flashrom/+/74954?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I27a07be1549ef070ad72b8e657d72170c7e85620 Gerrit-Change-Number: 74954 Gerrit-PatchSet: 6 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-MessageType: merged

1 0

[XS] Change in flashrom[master]: MAINTAINERS: Add Stefan Reinauer to flashchips
by Anastasia Klimchuk (Code Review) 24 Aug '23

24 Aug '23

Anastasia Klimchuk has submitted this change. ( https://review.coreboot.org/c/flashrom/+/77273?usp=email ) Change subject: MAINTAINERS: Add Stefan Reinauer to flashchips ...................................................................... MAINTAINERS: Add Stefan Reinauer to flashchips Change-Id: Ib1f79d06cebf0f091382c857da0be2f5d7a73581 Signed-off-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Reviewed-on: https://review.coreboot.org/c/flashrom/+/77273 Reviewed-by: Anastasia Klimchuk <aklm(a)chromium.org> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M MAINTAINERS 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Anastasia Klimchuk: Looks good to me, approved build bot (Jenkins): Verified diff --git a/MAINTAINERS b/MAINTAINERS index f1e350e..266e63a 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1,5 +1,4 @@ - List of upstream flashrom maintainers This represents the list of maintainers that work on the upstream flashrom @@ -97,6 +96,7 @@ FLASHCHIPS M: Anastasia Klimchuk <aklm(a)chromium.org> M: Nikolai Artemiev <nartemiev(a)google.com> +M: Stefan Reinauer <stefan.reinauer(a)coreboot.org> S: Maintained F: flashchips* F: include/flashchips* -- To view, visit https://review.coreboot.org/c/flashrom/+/77273?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ib1f79d06cebf0f091382c857da0be2f5d7a73581 Gerrit-Change-Number: 77273 Gerrit-PatchSet: 4 Gerrit-Owner: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[XS] Change in flashrom[master]: MAINTAINERS: Add Martin Roth for AMD SPI
by Anastasia Klimchuk (Code Review) 24 Aug '23

24 Aug '23

Attention is currently required from: Edward O'Callaghan, Martin L Roth, Martin Roth. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/74954?usp=email ) Change subject: MAINTAINERS: Add Martin Roth for AMD SPI ...................................................................... Patch Set 4: (1 comment) File MAINTAINERS: https://review.coreboot.org/c/flashrom/+/74954/comment/56cd4002_92dbef2c : PS4, Line 137: gaumless(a)tutanota.com > Just to check, does Gerrit know about this email, do you have this email on Gerrit account? so that […] checked with Martin, yes. -- To view, visit https://review.coreboot.org/c/flashrom/+/74954?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I27a07be1549ef070ad72b8e657d72170c7e85620 Gerrit-Change-Number: 74954 Gerrit-PatchSet: 4 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Comment-Date: Thu, 24 Aug 2023 02:34:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: flashchips: add Macronix MX25L3255E
by Anastasia Klimchuk (Code Review) 23 Aug '23

23 Aug '23

Anastasia Klimchuk has submitted this change. ( https://review.coreboot.org/c/flashrom/+/57410?usp=email ) Change subject: flashchips: add Macronix MX25L3255E ...................................................................... flashchips: add Macronix MX25L3255E Tested using the linux_spi programmer on a Raspberry Pi. Datasheet: https://media.digikey.com/pdf/Data%20Sheets/Macronix/MX25L3255E.pdf Signed-off-by: Joseph C. Lehner <joseph.c.lehner(a)gmail.com> Change-Id: I65968771e22e6b823d2d6192c33f5b0cba25d5b9 Signed-off-by: Anastasia Klimchuk <aklm(a)flashrom.org> Reviewed-on: https://review.coreboot.org/c/flashrom/+/57410 Reviewed-by: Nicholas Chin <nic.c3.14(a)gmail.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M flashchips.c M include/flashchips.h 2 files changed, 41 insertions(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified Nicholas Chin: Looks good to me, approved diff --git a/flashchips.c b/flashchips.c index 98bce40..6920c03 100644 --- a/flashchips.c +++ b/flashchips.c @@ -9395,6 +9395,46 @@ { .vendor = "Macronix", + .name = "MX25L3255E", + .bustype = BUS_SPI, + .manufacture_id = MACRONIX_ID, + .model_id = MACRONIX_MX25L3255E, + .total_size = 4096, + .page_size = 256, + /* OTP: 4K total; enter 0xB1, exit 0xC1 */ + .feature_bits = FEATURE_WRSR_WREN | FEATURE_OTP, + .tested = TEST_OK_PREW, + .probe = PROBE_SPI_RDID, + .probe_timing = TIMING_ZERO, + .block_erasers = + { + { + .eraseblocks = { {4 * 1024, 1024} }, + .block_erase = SPI_BLOCK_ERASE_20, + }, { + .eraseblocks = { {32 * 1024, 128} }, + .block_erase = SPI_BLOCK_ERASE_52, + }, { + .eraseblocks = { {64 * 1024, 64} }, + .block_erase = SPI_BLOCK_ERASE_D8, + }, { + .eraseblocks = { {4 * 1024 * 1024, 1} }, + .block_erase = SPI_BLOCK_ERASE_60, + }, { + .eraseblocks = { {4 * 1024 * 1024, 1} }, + .block_erase = SPI_BLOCK_ERASE_C7, + }, + }, + .printlock = SPI_PRETTYPRINT_STATUS_REGISTER_BP3_SRWD, + .unlock = SPI_DISABLE_BLOCKPROTECT_BP3_SRWD, + .write = SPI_CHIP_WRITE256, + /* Fast read (0x0B), 2x and 4x I/O supported */ + .read = SPI_CHIP_READ, + .voltage = {2700, 3600}, + }, + + { + .vendor = "Macronix", .name = "MX25L4005(A/C)/MX25L4006E", .bustype = BUS_SPI, .manufacture_id = MACRONIX_ID, diff --git a/include/flashchips.h b/include/flashchips.h index 976b4cb..e07a48d 100644 --- a/include/flashchips.h +++ b/include/flashchips.h @@ -532,6 +532,7 @@ #define MACRONIX_MX25U51245G 0x253a #define MACRONIX_MX25L3235D 0x5E16 /* MX25L3225D/MX25L3235D/MX25L3237D */ #define MACRONIX_MX25L6495F 0x9517 +#define MACRONIX_MX25L3255E 0x9e16 #define MACRONIX_MX77L25650F 0x7519 #define MACRONIX_MX25R3235F 0x2816 -- To view, visit https://review.coreboot.org/c/flashrom/+/57410?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I65968771e22e6b823d2d6192c33f5b0cba25d5b9 Gerrit-Change-Number: 57410 Gerrit-PatchSet: 4 Gerrit-Owner: Joseph C. Lehner Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: merged

1 0

[XS] Change in flashrom[master]: doc: Add flashrom logo to index page
by Edward O'Callaghan (Code Review) 23 Aug '23

23 Aug '23

Attention is currently required from: Alexander Goncharov, Anastasia Klimchuk, Thomas Heijligen. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/77250?usp=email ) Change subject: doc: Add flashrom logo to index page ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/77250?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I44a35b16a29b850e2b49d6e75c52d80b17bf7f75 Gerrit-Change-Number: 77250 Gerrit-PatchSet: 2 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Comment-Date: Wed, 23 Aug 2023 05:06:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in flashrom[master]: doc: Add favicon to config to display in the browser tab
by Edward O'Callaghan (Code Review) 23 Aug '23

23 Aug '23

Attention is currently required from: Alexander Goncharov, Anastasia Klimchuk, Stefan Reinauer, Thomas Heijligen. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/77285?usp=email ) Change subject: doc: Add favicon to config to display in the browser tab ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/77285?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I7238890833d84b3799e873c8a37b4176822ff9a4 Gerrit-Change-Number: 77285 Gerrit-PatchSet: 1 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Comment-Date: Wed, 23 Aug 2023 05:06:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in flashrom[master]: doc: Fix nesting of About flashrom group of menu items
by Edward O'Callaghan (Code Review) 23 Aug '23

23 Aug '23

Attention is currently required from: Anastasia Klimchuk, Thomas Heijligen. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/77293?usp=email ) Change subject: doc: Fix nesting of About flashrom group of menu items ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/77293?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I595acc282a536a6d5fa26cf2f8d18dbe549f9716 Gerrit-Change-Number: 77293 Gerrit-PatchSet: 1 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Wed, 23 Aug 2023 05:03:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in flashrom[master]: flashchips: Add support for MXIC MX2525643G It is similar to the MX25...
by Name of user not set (Code Review) 23 Aug '23

23 Aug '23

Attention is currently required from: Anastasia Klimchuk. Name of user not set #1005084 has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/76853?usp=email ) Change subject: flashchips: Add support for MXIC MX2525643G It is similar to the MX2525635F and shares its RDID. ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > xianzheng, thank you for the patch. I can't open datasheet by the link, not found. […] Dear Anastasia Klimchuk I'm sorry for the inconvenience caused to you due to my mistake. Please try the link below. https://www.mxic.com.tw/en-us/products/NOR-Flash/Serial-NOR-Flash/Pages/spe… -- To view, visit https://review.coreboot.org/c/flashrom/+/76853?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ie04a5e2325aab94bffb276675be3fa4a88c6e134 Gerrit-Change-Number: 76853 Gerrit-PatchSet: 1 Gerrit-Owner: Name of user not set #1005084 Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Wed, 23 Aug 2023 04:01:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: comment

1 0

[M] Change in flashrom[master]: flashrom: only perform WP unlock for write/erase operations
by Edward O'Callaghan (Code Review) 23 Aug '23

23 Aug '23

Attention is currently required from: Alexander Goncharov, Brian Norris, Nikolai Artemiev. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/75991?usp=email ) Change subject: flashrom: only perform WP unlock for write/erase operations ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/75991?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I5dc66474a0b7969b51b86ac9f5daa2c95ae968f1 Gerrit-Change-Number: 75991 Gerrit-PatchSet: 4 Gerrit-Owner: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Brian Norris <briannorris(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Attention: Brian Norris <briannorris(a)chromium.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Attention: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Comment-Date: Wed, 23 Aug 2023 00:30:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit August 2023