August 2023 - flashrom-gerrit - mail.coreboot.org

[S] Change in flashrom[master]: Remove dependency on C23 __has_include()
by Alexander Goncharov (Code Review) 31 Aug '23

31 Aug '23

Attention is currently required from: Anton Samsonov. Alexander Goncharov has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/77089?usp=email ) Change subject: Remove dependency on C23 __has_include() ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: Thanks for the patch! Can you please provide what compiler and version you used to test this patch? It would be great to include that in the commit message. -- To view, visit https://review.coreboot.org/c/flashrom/+/77089?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ic544963ffd29626ae0a21bdddb1c78850cc43ec6 Gerrit-Change-Number: 77089 Gerrit-PatchSet: 1 Gerrit-Owner: Anton Samsonov <devel(a)zxlab.ru> Gerrit-Reviewer: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Anton Samsonov <devel(a)zxlab.ru> Gerrit-Comment-Date: Thu, 31 Aug 2023 07:15:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in flashrom[master]: flashrom: only perform WP unlock for write/erase operations
by Nikolai Artemiev (Code Review) 31 Aug '23

31 Aug '23

Nikolai Artemiev has submitted this change. ( https://review.coreboot.org/c/flashrom/+/75991?usp=email ) Change subject: flashrom: only perform WP unlock for write/erase operations ...................................................................... flashrom: only perform WP unlock for write/erase operations Don't unlock using WP for read/verify operations because WP will only disable write locks. Most chips don't have read locks anyway, but some do, so we still call the chip's unlock function for read/verify operations. Unconditionally unlocking using WP slows down flashrom significantly with some programmers, particularly linux_mtd due to inefficiency in the current kernel MTD interface. BUG=b:283779258 BRANCH=none TEST=`ninja test` TEST=`flashrom -{r,w,E,v}` on strongbad TEST=`flashrom --wp-enable; flashrom -{w,E}` on strongbad Change-Id: I5dc66474a0b7969b51b86ac9f5daa2c95ae968f1 Signed-off-by: Nikolai Artemiev <nartemiev(a)google.com> Reviewed-on: https://review.coreboot.org/c/flashrom/+/75991 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Edward O'Callaghan <quasisec(a)chromium.org> --- M flashrom.c 1 file changed, 41 insertions(+), 11 deletions(-) Approvals: build bot (Jenkins): Verified Edward O'Callaghan: Looks good to me, approved diff --git a/flashrom.c b/flashrom.c index b6e5cf8..630c69d 100644 --- a/flashrom.c +++ b/flashrom.c @@ -2052,24 +2052,49 @@ return 0; } -static int unlock_flash_wp(struct flashctx *const flash) +static int unlock_flash_wp(struct flashctx *const flash, + const bool write_it, const bool erase_it) + { - /* Save original WP state to be restored later */ - if (save_initial_flash_wp(flash)) + int ret = 0; + + /* WP only disables write protection, so only use WP to unlock + * for write/erase operations. + * + * For read/verify operations, we still call the chip's unlock + * function, which may disable read locks if the chip has them. + */ + if (!write_it && !erase_it) { + msg_cdbg("Skipping writeprotect-based unlocking for read/verify operations.\n"); return -1; + } + + /* Save original WP state to be restored later */ + if (save_initial_flash_wp(flash)) { + ret = -1; + goto warn_out; + } /* Disable WP */ struct flashrom_wp_cfg *unlocked_wp_cfg; - if (flashrom_wp_cfg_new(&unlocked_wp_cfg) != FLASHROM_WP_OK) - return -1; + if (flashrom_wp_cfg_new(&unlocked_wp_cfg) != FLASHROM_WP_OK) { + ret = -1; + goto warn_out; + } flashrom_wp_set_range(unlocked_wp_cfg, 0, 0); flashrom_wp_set_mode(unlocked_wp_cfg, FLASHROM_WP_MODE_DISABLED); - enum flashrom_wp_result ret = flashrom_wp_write_cfg(flash, unlocked_wp_cfg); + if (flashrom_wp_write_cfg(flash, unlocked_wp_cfg) != FLASHROM_WP_OK) { + ret = -1; + } flashrom_wp_cfg_release(unlocked_wp_cfg); - return (ret == FLASHROM_WP_OK) ? 0 : -1; +warn_out: + if (ret) + msg_cerr("Failed to unlock flash status reg with wp support.\n"); + + return ret; } int prepare_flash_access(struct flashctx *const flash, @@ -2092,14 +2117,19 @@ /* Initialize chip_restore_fn_count before chip unlock calls. */ flash->chip_restore_fn_count = 0; - /* Given the existence of read locks, we want to unlock for read, erase and write. */ int ret = 1; if (flash->chip->decode_range != NO_DECODE_RANGE_FUNC || (flash->mst->buses_supported & BUS_PROG && flash->mst->opaque.wp_write_cfg)) { - ret = unlock_flash_wp(flash); - if (ret) - msg_cerr("Failed to unlock flash status reg with wp support.\n"); + ret = unlock_flash_wp(flash, write_it, erase_it); } + /* + * Fall back to chip unlock function if we haven't already successfully + * unlocked using WP (e.g. WP unlocking failed, chip had no WP support, + * WP was skipped for read/verify ops). + * + * Given the existence of read locks, we want to unlock for read, + * erase, write, and verify. + */ blockprotect_func_t *bp_func = lookup_blockprotect_func_ptr(flash->chip); if (ret && bp_func) bp_func(flash); -- To view, visit https://review.coreboot.org/c/flashrom/+/75991?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I5dc66474a0b7969b51b86ac9f5daa2c95ae968f1 Gerrit-Change-Number: 75991 Gerrit-PatchSet: 5 Gerrit-Owner: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Brian Norris <briannorris(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Alexander Goncharov <chat(a)joursoir.net> Gerrit-MessageType: merged

1 0

[XS] Change in flashrom[master]: doc: Fix nesting of About flashrom group of menu items
by Alexander Goncharov (Code Review) 30 Aug '23

30 Aug '23

Alexander Goncharov has submitted this change. ( https://review.coreboot.org/c/flashrom/+/77293?usp=email ) Change subject: doc: Fix nesting of About flashrom group of menu items ...................................................................... doc: Fix nesting of About flashrom group of menu items Adding the title to About flashrom index page allows the engine to recognise it as a group with a list of menu items inside, which is as expected. Without the title on the index page, all menu items inside About flashrom are inlined into the menu. Change-Id: I595acc282a536a6d5fa26cf2f8d18dbe549f9716 Signed-off-by: Anastasia Klimchuk <aklm(a)flashrom.org> Reviewed-on: https://review.coreboot.org/c/flashrom/+/77293 Reviewed-by: Edward O'Callaghan <quasisec(a)chromium.org> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Alexander Goncharov <chat(a)joursoir.net> --- M doc/about_flashrom/index.rst 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified Alexander Goncharov: Looks good to me, approved Edward O'Callaghan: Looks good to me, approved diff --git a/doc/about_flashrom/index.rst b/doc/about_flashrom/index.rst index 11d845f..de36fc2 100644 --- a/doc/about_flashrom/index.rst +++ b/doc/about_flashrom/index.rst @@ -1,3 +1,6 @@ +About flashrom +============== + .. toctree:: :maxdepth: 1 -- To view, visit https://review.coreboot.org/c/flashrom/+/77293?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I595acc282a536a6d5fa26cf2f8d18dbe549f9716 Gerrit-Change-Number: 77293 Gerrit-PatchSet: 2 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[XS] Change in flashrom[master]: doc: Fix nesting of About flashrom group of menu items
by Alexander Goncharov (Code Review) 30 Aug '23

30 Aug '23

Attention is currently required from: Anastasia Klimchuk, Thomas Heijligen. Alexander Goncharov has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/77293?usp=email ) Change subject: doc: Fix nesting of About flashrom group of menu items ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/77293?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I595acc282a536a6d5fa26cf2f8d18dbe549f9716 Gerrit-Change-Number: 77293 Gerrit-PatchSet: 1 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Wed, 30 Aug 2023 21:08:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: flashchips: Add support for MXIC MX25U25643G
by Name of user not set (Code Review) 30 Aug '23

30 Aug '23

Name of user not set #1005084 has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/77563?usp=email ) Change subject: flashchips: Add support for MXIC MX25U25643G ...................................................................... flashchips: Add support for MXIC MX25U25643G It is similar to the MX25U25635F and shares its RDID. Tested by ch341a programmer : read, write and erase. Datasheet is available at the following URL: https://www.mxic.com.tw/en-us/products/NOR-Flash/Serial-NOR-Flash/Pages/spe… Change-Id: Ibff2780dcb86ffb7790e0204385e6350f136f21d Signed-off-by: xianzheng <xianzheng(a)mxic.com.cn> --- M flashchips.c M include/flashchips.h 2 files changed, 2 insertions(+), 43 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/63/77563/1 diff --git a/flashchips.c b/flashchips.c index ce68e95..1b3df5c 100644 --- a/flashchips.c +++ b/flashchips.c @@ -8109,46 +8109,6 @@ { .vendor = "ISSI", - .name = "IS25WQ040", - .bustype = BUS_SPI, - .manufacture_id = ISSI_ID_SPI, - .model_id = ISSI_IS25WQ040, - .total_size = 512, - .page_size = 256, - .feature_bits = FEATURE_WRSR_WREN | FEATURE_OTP | FEATURE_QPI, - .tested = TEST_OK_PREW, - .probe = PROBE_SPI_RDID, - .probe_timing = TIMING_ZERO, - .block_erasers = - { - { - .eraseblocks = { {4 * 1024, 128} }, - .block_erase = SPI_BLOCK_ERASE_20, - }, { - .eraseblocks = { {4 * 1024, 128} }, - .block_erase = SPI_BLOCK_ERASE_D7, - }, { - .eraseblocks = { {32 * 1024, 16} }, - .block_erase = SPI_BLOCK_ERASE_52, - }, { - .eraseblocks = { {64 * 1024, 8} }, - .block_erase = SPI_BLOCK_ERASE_D8, - }, { - .eraseblocks = { {512 * 1024, 1} }, - .block_erase = SPI_BLOCK_ERASE_60, - }, { - .eraseblocks = { {512 * 1024, 1} }, - .block_erase = SPI_BLOCK_ERASE_C7, - } - }, - .unlock = SPI_DISABLE_BLOCKPROTECT, - .write = SPI_CHIP_WRITE256, - .read = SPI_CHIP_READ, - .voltage = {1650, 1950}, - }, - - { - .vendor = "ISSI", .name = "IS29GL064B", .bustype = BUS_PARALLEL, .manufacture_id = ISSI_ID, @@ -10207,7 +10167,7 @@ { .vendor = "Macronix", - .name = "MX25U25635F", + .name = "MX25U25635F/MX25U25643G", .bustype = BUS_SPI, .manufacture_id = MACRONIX_ID, .model_id = MACRONIX_MX25U25635F, diff --git a/include/flashchips.h b/include/flashchips.h index 6e191eb..5e6cbdb 100644 --- a/include/flashchips.h +++ b/include/flashchips.h @@ -487,7 +487,6 @@ #define ISSI_IS25WP080 0x7014 #define ISSI_IS25WP128 0x7018 #define ISSI_IS25WP256 0x7019 -#define ISSI_IS25WQ040 0x1253 #define ISSI_PMC_IS29GL032B 0xF9 #define ISSI_PMC_IS29GL032T 0xF6 #define ISSI_PMC_IS29GL064B 0x7E1000 @@ -529,7 +528,7 @@ #define MACRONIX_MX25U3235E 0x2536 /* Same as MX25U6435F */ #define MACRONIX_MX25U6435E 0x2537 /* Same as MX25U6435F */ #define MACRONIX_MX25U12835E 0x2538 /* Same as MX25U12835F */ -#define MACRONIX_MX25U25635F 0x2539 +#define MACRONIX_MX25U25635F 0x2539 /* Same as MX25U25643G */ #define MACRONIX_MX25U51245G 0x253a #define MACRONIX_MX25L3235D 0x5E16 /* MX25L3225D/MX25L3235D/MX25L3237D */ #define MACRONIX_MX25L6495F 0x9517 -- To view, visit https://review.coreboot.org/c/flashrom/+/77563?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ibff2780dcb86ffb7790e0204385e6350f136f21d Gerrit-Change-Number: 77563 Gerrit-PatchSet: 1 Gerrit-Owner: Name of user not set #1005084 Gerrit-MessageType: newchange

1 0

[S] Change in flashrom[master]: flashchips.c: Add support for IS25WQ040
by Anastasia Klimchuk (Code Review) 30 Aug '23

30 Aug '23

Anastasia Klimchuk has submitted this change. ( https://review.coreboot.org/c/flashrom/+/58179?usp=email ) Change subject: flashchips.c: Add support for IS25WQ040 ...................................................................... flashchips.c: Add support for IS25WQ040 Based on https://github.com/flashrom/flashrom/pull/204 squashed with fixes of IS25WQ040 size: it is 4Mbits, not 4MBytes, see https://www.issi.com/WW/pdf/25WQ020-040.pdf Tested read, write and erase with ft2232_spi-based "Tigard" programmer. Change-Id: I072c6b94d7931637d1c2721c3316205f2d57320e Signed-off-by: Roman Stingler <roman.stingler(a)gmail.com> Signed-off-by: Vasily Galkin <galkin-vv(a)ya.ru> Reviewed-on: https://review.coreboot.org/c/flashrom/+/58179 Reviewed-by: Anastasia Klimchuk <aklm(a)chromium.org> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M flashchips.c M include/flashchips.h 2 files changed, 41 insertions(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified Anastasia Klimchuk: Looks good to me, approved diff --git a/flashchips.c b/flashchips.c index 6920c03..ce68e95 100644 --- a/flashchips.c +++ b/flashchips.c @@ -8109,6 +8109,46 @@ { .vendor = "ISSI", + .name = "IS25WQ040", + .bustype = BUS_SPI, + .manufacture_id = ISSI_ID_SPI, + .model_id = ISSI_IS25WQ040, + .total_size = 512, + .page_size = 256, + .feature_bits = FEATURE_WRSR_WREN | FEATURE_OTP | FEATURE_QPI, + .tested = TEST_OK_PREW, + .probe = PROBE_SPI_RDID, + .probe_timing = TIMING_ZERO, + .block_erasers = + { + { + .eraseblocks = { {4 * 1024, 128} }, + .block_erase = SPI_BLOCK_ERASE_20, + }, { + .eraseblocks = { {4 * 1024, 128} }, + .block_erase = SPI_BLOCK_ERASE_D7, + }, { + .eraseblocks = { {32 * 1024, 16} }, + .block_erase = SPI_BLOCK_ERASE_52, + }, { + .eraseblocks = { {64 * 1024, 8} }, + .block_erase = SPI_BLOCK_ERASE_D8, + }, { + .eraseblocks = { {512 * 1024, 1} }, + .block_erase = SPI_BLOCK_ERASE_60, + }, { + .eraseblocks = { {512 * 1024, 1} }, + .block_erase = SPI_BLOCK_ERASE_C7, + } + }, + .unlock = SPI_DISABLE_BLOCKPROTECT, + .write = SPI_CHIP_WRITE256, + .read = SPI_CHIP_READ, + .voltage = {1650, 1950}, + }, + + { + .vendor = "ISSI", .name = "IS29GL064B", .bustype = BUS_PARALLEL, .manufacture_id = ISSI_ID, diff --git a/include/flashchips.h b/include/flashchips.h index e07a48d..6e191eb 100644 --- a/include/flashchips.h +++ b/include/flashchips.h @@ -487,6 +487,7 @@ #define ISSI_IS25WP080 0x7014 #define ISSI_IS25WP128 0x7018 #define ISSI_IS25WP256 0x7019 +#define ISSI_IS25WQ040 0x1253 #define ISSI_PMC_IS29GL032B 0xF9 #define ISSI_PMC_IS29GL032T 0xF6 #define ISSI_PMC_IS29GL064B 0x7E1000 -- To view, visit https://review.coreboot.org/c/flashrom/+/58179?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I072c6b94d7931637d1c2721c3316205f2d57320e Gerrit-Change-Number: 58179 Gerrit-PatchSet: 7 Gerrit-Owner: Vasily Galkin Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: roman.stingler(a)gmail.com Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: merged

1 0

[XS] Change in flashrom[master]: Makefile: Remove a bashism when searching for sphinx-build
by Anastasia Klimchuk (Code Review) 29 Aug '23

29 Aug '23

Anastasia Klimchuk has submitted this change. ( https://review.coreboot.org/c/flashrom/+/77288?usp=email ) Change subject: Makefile: Remove a bashism when searching for sphinx-build ...................................................................... Makefile: Remove a bashism when searching for sphinx-build e.g. when the shell is dash and sphinx-build is not installed, HAS_SPHINXBUILD would be wrongly set to yes. Change-Id: I4d89e24ec3401446acec857eae134928bc3064d2 Signed-off-by: Bart De Schuymer <bdschuym(a)artinalgorithms.be> Reviewed-on: https://review.coreboot.org/c/flashrom/+/77288 Reviewed-by: Peter Marheine <pmarheine(a)chromium.org> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Patrick Georgi <patrick(a)coreboot.org> Reviewed-by: Jan Samek <jan.samek(a)siemens.com> --- M Makefile 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Patrick Georgi: Looks good to me, approved build bot (Jenkins): Verified Peter Marheine: Looks good to me, approved Jan Samek: Looks good to me, but someone else must approve diff --git a/Makefile b/Makefile index bc3eecb..bf01d0f 100644 --- a/Makefile +++ b/Makefile @@ -250,7 +250,7 @@ HAS_LINUX_SPI := $(call c_compile_test, Makefile.d/linux_spi_test.c) HAS_LINUX_I2C := $(call c_compile_test, Makefile.d/linux_i2c_test.c) HAS_SERIAL := $(strip $(if $(filter $(TARGET_OS), DOS libpayload), no, yes)) -HAS_SPHINXBUILD := $(shell command -v $(SPHINXBUILD) &>/dev/null && echo yes || echo no) +HAS_SPHINXBUILD := $(shell command -v $(SPHINXBUILD) >/dev/null 2>/dev/null && echo yes || echo no) EXEC_SUFFIX := $(strip $(if $(filter $(TARGET_OS), DOS MinGW), .exe)) override CFLAGS += -Iinclude -- To view, visit https://review.coreboot.org/c/flashrom/+/77288?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I4d89e24ec3401446acec857eae134928bc3064d2 Gerrit-Change-Number: 77288 Gerrit-PatchSet: 3 Gerrit-Owner: Bart De Schuymer <bdschuym(a)artinalgorithms.be> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Jan Samek <jan.samek(a)siemens.com> Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[XS] Change in flashrom[master]: spi25_statusreg: add verbose output on status registers read results
by Anastasia Klimchuk (Code Review) 28 Aug '23

28 Aug '23

Attention is currently required from: Vasily Galkin. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/77529?usp=email ) Change subject: spi25_statusreg: add verbose output on status registers read results ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > Yes, logged only for super-verbose -VVV. […] The verbosity is fine for -VVV, all good. I would say, it's really good to add something to help "a person quite new to SPI flashing". This helped you, and might also help a hundred of other people in future. Thank you for contributing. -- To view, visit https://review.coreboot.org/c/flashrom/+/77529?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ibc8e9229ab5d6578479564d11cc7aff9442e24ad Gerrit-Change-Number: 77529 Gerrit-PatchSet: 1 Gerrit-Owner: Vasily Galkin Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Vasily Galkin Gerrit-Comment-Date: Mon, 28 Aug 2023 10:25:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Vasily Galkin Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: comment

1 0

[XS] Change in flashrom[master]: spi25_statusreg: add verbose output on status registers read results
by Vasily Galkin (Code Review) 28 Aug '23

28 Aug '23

Attention is currently required from: Anastasia Klimchuk. Vasily Galkin has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/77529?usp=email ) Change subject: spi25_statusreg: add verbose output on status registers read results ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > Just to check, this will log only for super verbose mode -VVV right? […] Yes, logged only for super-verbose -VVV. The less verbose -VV does not log it. The count of produced lines depends on a chip. In general, say near 4 lines are produced (flashrom really rereads it several times). Also, since WP registers are automatically touched by flashrom's "--write" operation - it is also displayed during --write. This was especially important: before it I thought that WP is not working, but it turned out that flashrom automatically disabled it. (after that I tested WP with an external tool talking directly to programmer at lower level and seen that the WP is really working) BTW, if this is too verbose for flashrom standards - I'm fine with dropping this patch from a series. I'm seeing its usefulness only as "a person quite new to SPI flashing" -- To view, visit https://review.coreboot.org/c/flashrom/+/77529?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ibc8e9229ab5d6578479564d11cc7aff9442e24ad Gerrit-Change-Number: 77529 Gerrit-PatchSet: 1 Gerrit-Owner: Vasily Galkin Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Mon, 28 Aug 2023 08:19:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: comment

1 0

[XS] Change in flashrom[master]: spi25_statusreg: add verbose output on status registers read results
by Anastasia Klimchuk (Code Review) 28 Aug '23

28 Aug '23

Attention is currently required from: Vasily Galkin. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/77529?usp=email ) Change subject: spi25_statusreg: add verbose output on status registers read results ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Patchset: PS1: Just to check, this will log only for super verbose mode -VVV right? How many lines it produces in the log, one line per WP operation, or more? -- To view, visit https://review.coreboot.org/c/flashrom/+/77529?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ibc8e9229ab5d6578479564d11cc7aff9442e24ad Gerrit-Change-Number: 77529 Gerrit-PatchSet: 1 Gerrit-Owner: Vasily Galkin Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Vasily Galkin Gerrit-Comment-Date: Mon, 28 Aug 2023 04:25:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit August 2023