August 2023 - flashrom-gerrit - mail.coreboot.org

[XS] Change in flashrom[master]: spi25_statusreg: add verbose output on status registers read results
by Anastasia Klimchuk (Code Review) 28 Aug '23

28 Aug '23

Attention is currently required from: Vasily Galkin. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/77529?usp=email ) Change subject: spi25_statusreg: add verbose output on status registers read results ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Patchset: PS1: Just to check, this will log only for super verbose mode -VVV right? How many lines it produces in the log, one … [View More]

1 0

[XS] Change in flashrom[master]: Makefile: Remove a bashism when searching for sphinx-build
by Anastasia Klimchuk (Code Review) 28 Aug '23

28 Aug '23

Attention is currently required from: Bart De Schuymer, Thomas Heijligen. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/77288?usp=email ) Change subject: Makefile: Remove a bashism when searching for sphinx-build ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: > Bart, sorry I forgot to ask previously, did you have a chance to test run with both dash and bash? […] … [View More]

1 0

[XS] Change in flashrom[master]: Makefile: Remove a bashism when searching for sphinx-build
by Peter Marheine (Code Review) 28 Aug '23

28 Aug '23

Attention is currently required from: Bart De Schuymer, Thomas Heijligen. Peter Marheine has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/77288?usp=email ) Change subject: Makefile: Remove a bashism when searching for sphinx-build ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/77288?usp=email To unsubscribe, or for help writing mail filters, visit … [View More]

1 0

[S] Change in flashrom[master]: flashchips.c: Add support for IS25WQ040
by Anastasia Klimchuk (Code Review) 27 Aug '23

27 Aug '23

Attention is currently required from: Nikolai Artemiev, Stefan Reinauer, Thomas Heijligen, Vasily Galkin, roman.stingler(a)gmail.com. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58179?usp=email ) Change subject: flashchips.c: Add support for IS25WQ040 ...................................................................... Patch Set 6: Code-Review+2 (2 comments) Patchset: PS6: > Thanks for review! […] Yes, it's fine. File … [View More]

1 0

[S] Change in flashrom[master]: flashchips.c: Add support for IS25WQ040
by Vasily Galkin (Code Review) 27 Aug '23

27 Aug '23

Attention is currently required from: Anastasia Klimchuk, Nikolai Artemiev, Stefan Reinauer, Thomas Heijligen, roman.stingler(a)gmail.com. Vasily Galkin has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58179?usp=email ) Change subject: flashchips.c: Add support for IS25WQ040 ...................................................................... Patch Set 6: (3 comments) Patchset: PS6: Thanks for review! Seems-to-be-incorreect comments in the code are … [View More]removed; rebase done too. I have no this chip at hand by now, so the current version is not tested, but ~1y ago I used previous variant for flashing such chip, so I hope it is still fine after rebasing. File flashchips.c: https://review.coreboot.org/c/flashrom/+/58179/comment/00ecbc7a_fc780a28 : PS5, Line 7792: 1024B > Page 47 says OTP is 256Bytes ? Also are you sure about read and write? This and next-line comments were the parts of the first version of a patch by Roman Stingler that I used as a basis. While using that patch as a base I verified the constants in the code, but completely foget to look in the comments. No I see that they didn't correspond to the datasheet. So I just remove those comments. https://review.coreboot.org/c/flashrom/+/58179/comment/e035bcdf_a27858c5 : PS5, Line 7793: /* QPI enable 0x35, disable 0xF5 */ > QPI is not in the datasheet? Removed this commands 0x35, 0xF5 are not mentioned in datasheet. However the QPI I/O mode itself is mentioned, so the FEATURE_QPI flag on the line below is kept -- To view, visit https://review.coreboot.org/c/flashrom/+/58179?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I072c6b94d7931637d1c2721c3316205f2d57320e Gerrit-Change-Number: 58179 Gerrit-PatchSet: 6 Gerrit-Owner: Vasily Galkin Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: roman.stingler(a)gmail.com Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: roman.stingler(a)gmail.com Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Comment-Date: Sat, 26 Aug 2023 23:34:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: comment [View Less]

1 0

[S] Change in flashrom[master]: flashchips.c: Add support for IS25WQ040
by Vasily Galkin (Code Review) 27 Aug '23

27 Aug '23

Attention is currently required from: Thomas Heijligen, Vasily Galkin, roman.stingler(a)gmail.com. Hello Anastasia Klimchuk, Thomas Heijligen, build bot (Jenkins), roman.stingler(a)gmail.com, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/58179?usp=email to look at the new patch set (#6). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: flashchips.c: Add support for IS25WQ040 ..........… [View More]

1 0

[S] Change in flashrom[master]: flashchips: add WP features for W25X* analogous to tested W25X20
by Vasily Galkin (Code Review) 27 Aug '23

27 Aug '23

Attention is currently required from: Anastasia Klimchuk, Nikolai Artemiev, Stefan Reinauer. Vasily Galkin has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/77531?usp=email ) Change subject: flashchips: add WP features for W25X* analogous to tested W25X20 ...................................................................... flashchips: add WP features for W25X* analogous to tested W25X20 These chips were not tested physically, just added since they are very … [View More]similar to just added and tested W25X20. However basic logic test were done via running --wp-list with dummy emulating those IDs While there are per-chip datasheets like https://www.winbond.com/resource-files/W25X05CL_G%2008012019.pdf the combined datasheets that shows differences between WP modes of different chips are more useful: https://www.winbond.com/resource-files/w25x10a-20a-40a-80a%20revf%20080709.… https://media.digikey.com/pdf/data%20sheets/winbond%20pdfs/w25x16,16a,32,64… Signed-off-by: Vasily Galkin <galkin-vv(a)ya.ru> Change-Id: Ie69660a6f69e3cac31c5565792f401e69d43f8b8 --- M flashchips.c 1 file changed, 48 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/31/77531/1 diff --git a/flashchips.c b/flashchips.c index 4edceb0..d64a03a 100644 --- a/flashchips.c +++ b/flashchips.c @@ -19682,6 +19682,12 @@ .write = SPI_CHIP_WRITE256, .read = SPI_CHIP_READ, .voltage = {2300, 3600}, + .reg_bits = + { + .srp = {STATUS1, 7, RW}, + .bp = {{STATUS1, 2, RW}, {STATUS1, 3, RW}}, + }, + .decode_range = DECODE_RANGE_SPI25, }, { @@ -19714,6 +19720,13 @@ .write = SPI_CHIP_WRITE256, .read = SPI_CHIP_READ, .voltage = {2700, 3600}, + .reg_bits = + { + .srp = {STATUS1, 7, RW}, + .bp = {{STATUS1, 2, RW}, {STATUS1, 3, RW}}, + .tb = {STATUS1, 5, RW}, + }, + .decode_range = DECODE_RANGE_SPI25, }, { @@ -19752,6 +19765,13 @@ .write = SPI_CHIP_WRITE256, .read = SPI_CHIP_READ, .voltage = {2700, 3600}, + .reg_bits = + { + .srp = {STATUS1, 7, RW}, + .bp = {{STATUS1, 2, RW}, {STATUS1, 3, RW}, {STATUS1, 4, RW}}, + .tb = {STATUS1, 5, RW}, + }, + .decode_range = DECODE_RANGE_SPI25, }, { @@ -19829,6 +19849,13 @@ .write = SPI_CHIP_WRITE256, .read = SPI_CHIP_READ, .voltage = {2700, 3600}, + .reg_bits = + { + .srp = {STATUS1, 7, RW}, + .bp = {{STATUS1, 2, RW}, {STATUS1, 3, RW}, {STATUS1, 4, RW}}, + .tb = {STATUS1, 5, RW}, + }, + .decode_range = DECODE_RANGE_SPI25, }, { @@ -19861,6 +19888,13 @@ .write = SPI_CHIP_WRITE256, .read = SPI_CHIP_READ, .voltage = {2700, 3600}, + .reg_bits = + { + .srp = {STATUS1, 7, RW}, + .bp = {{STATUS1, 2, RW}, {STATUS1, 3, RW}, {STATUS1, 4, RW}}, + .tb = {STATUS1, 5, RW}, + }, + .decode_range = DECODE_RANGE_SPI25, }, { @@ -19899,6 +19933,13 @@ .write = SPI_CHIP_WRITE256, .read = SPI_CHIP_READ, .voltage = {2700, 3600}, + .reg_bits = + { + .srp = {STATUS1, 7, RW}, + .bp = {{STATUS1, 2, RW}, {STATUS1, 3, RW}, {STATUS1, 4, RW}}, + .tb = {STATUS1, 5, RW}, + }, + .decode_range = DECODE_RANGE_SPI25, }, { @@ -19931,6 +19972,13 @@ .write = SPI_CHIP_WRITE256, .read = SPI_CHIP_READ, .voltage = {2700, 3600}, + .reg_bits = + { + .srp = {STATUS1, 7, RW}, + .bp = {{STATUS1, 2, RW}, {STATUS1, 3, RW}, {STATUS1, 4, RW}}, + .tb = {STATUS1, 5, RW}, + }, + .decode_range = DECODE_RANGE_SPI25, }, /* W29EE011, W29EE012, W29C010M, W29C011A do not support probe_jedec according to the datasheet, but it works for newer(?) steppings. */ -- To view, visit https://review.coreboot.org/c/flashrom/+/77531?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ie69660a6f69e3cac31c5565792f401e69d43f8b8 Gerrit-Change-Number: 77531 Gerrit-PatchSet: 1 Gerrit-Owner: Vasily Galkin Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: newchange [View Less]

1 0

[XS] Change in flashrom[master]: flashchips: Add WP features for Winbond W25X20
by Vasily Galkin (Code Review) 27 Aug '23

27 Aug '23

Attention is currently required from: Anastasia Klimchuk, Nikolai Artemiev, Stefan Reinauer. Vasily Galkin has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/77530?usp=email ) Change subject: flashchips: Add WP features for Winbond W25X20 ...................................................................... flashchips: Add WP features for Winbond W25X20 WP-related registers list from official datasheet https://www.winbond.com/resource-files/w25x20cl_revf%… [View More]

1 0

[XS] Change in flashrom[master]: spi25_statusreg: add verbose output on status registers read results
by Vasily Galkin (Code Review) 27 Aug '23

27 Aug '23

Vasily Galkin has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/77529?usp=email ) Change subject: spi25_statusreg: add verbose output on status registers read results ...................................................................... spi25_statusreg: add verbose output on status registers read results Useful during enabling/debugging WP operations on various SPI chips Signed-off-by: Vasily Galkin <galkin-vv(a)ya.ru> Change-Id: … [View More]

1 0

[XS] Change in flashrom[master]: Makefile: Remove a bashism when searching for sphinx-build
by Patrick Georgi (Code Review) 25 Aug '23

25 Aug '23

Attention is currently required from: Bart De Schuymer, Peter Marheine, Thomas Heijligen. Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/77288?usp=email ) Change subject: Makefile: Remove a bashism when searching for sphinx-build ...................................................................... Patch Set 2: Code-Review+2 (1 comment) Patchset: PS2: As the resident portability nut, I approve of this change! -- To view, visit https://… [View More]

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit August 2023