Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35921 )
Change subject: mb/google/glados: port to FSP 2.0 ......................................................................
Patch Set 4: Code-Review+1
(2 comments)
https://review.coreboot.org/c/coreboot/+/35921/4/src/mainboard/google/glados... File src/mainboard/google/glados/romstage.c:
https://review.coreboot.org/c/coreboot/+/35921/4/src/mainboard/google/glados... PS4, Line 33: #ifdef EC_ENABLE_KEYBOARD_BACKLIGHT : /* Turn on keyboard backlight to indicate we are booting */ : const FSPM_ARCH_UPD *arch_upd = &mupd->FspmArchUpd; : if (arch_upd->BootMode != FSP_BOOT_ON_S3_RESUME) : google_chromeec_kbbacklight(25); : #endif remove one tab from entire block - #ifdefs are not indented to match current code level
https://review.coreboot.org/c/coreboot/+/35921/4/src/mainboard/google/glados... File src/mainboard/google/glados/variants/chell/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/35921/4/src/mainboard/google/glados... PS4, Line 84: #| IccMax | 7A | 34A | 35A | 35A | outside of the scope of this patch, but it appears that chell is using the wrong IccMax values (using ones for SKL-U, not SKL-Y) unless it's intentionally different from the other Y-series boards (caroline/cave)
-
Matt DeVillier (Code Review)