Attention is currently required from: Angel Pons, Máté Kukri, Nicholas Chin.
Jan Philipp Groß has posted comments on this change by Jan Philipp Groß. ( https://review.coreboot.org/c/coreboot/+/85884?usp=email )
Change subject: mb/asrock: Add Z87M Extreme4 (Haswell) ......................................................................
Patch Set 4:
(3 comments)
File src/mainboard/asrock/z87m_extreme4/bootblock.c:
https://review.coreboot.org/c/coreboot/+/85884/comment/34569998_a3e80fbe?usp... : PS3, Line 12:
nit: drop one blank line
Done
File src/mainboard/asrock/z87m_extreme4/dsdt.asl:
https://review.coreboot.org/c/coreboot/+/85884/comment/e16df6a8_de2f77ef?usp... : PS3, Line 25: /* FIXME: remove this if the board doesn't have backlight. */ : #include <drivers/intel/gma/acpi/default_brightness_levels.asl>
Yeet
Done
File src/mainboard/asrock/z87m_extreme4/romstage.c:
https://review.coreboot.org/c/coreboot/+/85884/comment/2c2a2236_729d4cc2?usp... : PS3, Line 11: /* FIXME: called after romstage_common, remove it if not used */ : void mb_late_romstage_setup(void) : { : }
Yeet
Done