[S] Change in coreboot[main]: arch/x86/cpu: Add helper function to compute cache

[Felix Held (Code Review)]

Attention is currently required from: Andy Ebrahiem, Angel Pons, Jincheng Li, Jérémy Compostella, Maximilian Brune, Naresh Solanki, Patrick Rudolph, Shuo Liu.

Felix Held has posted comments on this change by Naresh Solanki. ( https://review.coreboot.org/c/coreboot/+/85638?usp=email )

Change subject: arch/x86/cpu: Add helper function to compute cache
......................................................................

Patch Set 7:

(1 comment)

File src/arch/x86/cpu_common.c:

https://review.coreboot.org/c/coreboot/+/85638/comment/6281fd91_46e3f42d?usp... :
PS7, Line 215: bool __weak soc_fill_cpu_cache_info(uint8_t level, struct cpu_cache_info *info)
> I wrote it in this because I felt it is easy for various SoC vendors to easily chip in custom handle […]

yes, that was what i was thinking of. i don't think that this makes things more difficult for the soc vendors, but it helps catching possibly bugs which using weak functions wouldn't.
examples where i think using weak functions is probably a good thing to do are for example the smbios data fill functions where the weak function just provides a default and the intention is that those are overridden or inside of mainboard baseboards where variants can override functions; in that case that's all in one folder, so its not too easy to lose track of that. in most other cases, i'd probably try to avoid using weak functions; at least unless there's a strong reason to still use those over for example having a kconfig option to skip or replace some calls