Attention is currently required from: Ravi kumar, Sajida Bhanu.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50586 )
Change subject: HACK sc7280: QSIP SPI NOR addressing mode HACK
......................................................................
Patch Set 3:
(2 comments)
File src/drivers/spi/spi_flash.c:
https://review.coreboot.org/c/coreboot/+/50586/comment/3a652afc_7696b84f
PS3, Line 493: if (reg8 & 0x20){
space required before the open brace '{'
https://review.coreboot.org/c/coreboot/+/50586/comment/c6445c4e_17f49177
PS3, Line 497: while (1);
trailing statements should be on next line
--
To view, visit
https://review.coreboot.org/c/coreboot/+/50586
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ied5b647d0fcc8e3effff3bb7c8680ed5a0c1f3d4
Gerrit-Change-Number: 50586
Gerrit-PatchSet: 3
Gerrit-Owner: Ravi kumar
rbokka@codeaurora.org
Gerrit-Reviewer: Sajida Bhanu
sbhanu@codeaurora.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Ravi kumar
rbokka@codeaurora.org
Gerrit-Attention: Sajida Bhanu
sbhanu@codeaurora.org
Gerrit-Comment-Date: Thu, 18 Feb 2021 23:04:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment