Attention is currently required from: Andrey Petrov, Intel coreboot Reviewers, Julius Werner, Ronak Kanabar, Subrata Banik.
Jérémy Compostella has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/86001?usp=email )
Change subject: drivers/intel/fsp2_0: Add option to control debug log level using CBFS
......................................................................
Patch Set 5:
(3 comments)
File src/drivers/intel/fsp2_0/Kconfig:
https://review.coreboot.org/c/coreboot/+/86001/comment/bdc4f5a9_f351246a?usp... :
PS5, Line 528: default n
unnecessary default, n is default for boolean.
https://review.coreboot.org/c/coreboot/+/86001/comment/c9969f48_dddfcc1e?usp... :
PS5, Line 537: Here is the example of adding RAW binary file into the RO-CBFS to specify the
Here is **an** example
File src/drivers/intel/fsp2_0/include/fsp/debug.h:
https://review.coreboot.org/c/coreboot/+/86001/comment/941b80ee_bb1f07d8?usp... :
PS5, Line 69: If `fsp_pcd_debug_level` not present
If `fsp_pcd_debug_level` file is not present
--
To view, visit
https://review.coreboot.org/c/coreboot/+/86001?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I2c14d26021dd0048fa24024119df857e216f18bd
Gerrit-Change-Number: 86001
Gerrit-PatchSet: 5
Gerrit-Owner: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Intel coreboot Reviewers
intel_coreboot_reviewers@intel.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Attention: Intel coreboot Reviewers
intel_coreboot_reviewers@intel.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Attention: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Comment-Date: Wed, 15 Jan 2025 16:45:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No