Attention is currently required from: Lance Zhao, Furquan Shaikh, Subrata Banik, Kyösti Mälkki, Patrick Rudolph. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50297 )
Change subject: soc/intel: Drop CID1 from GNVS ......................................................................
Patch Set 2:
(2 comments)
File src/soc/intel/common/block/acpi/acpi/globalnvs.asl:
https://review.coreboot.org/c/coreboot/+/50297/comment/ec26eced_6ab45ccb PS2, Line 23: , 16, // 0x29 - 0x2a Wifi Country Identifier
If we totally drop it, why not delete here as well?
Dropping it would mess with alignment, and all the comments would need to be updated. See comment on nvs.h for a more detailed explanation.
File src/soc/intel/common/block/include/intelblocks/nvs.h:
https://review.coreboot.org/c/coreboot/+/50297/comment/cac96c85_a1d075ac PS2, Line 23: unused_was_cid1
Why not totally drop it if removed everywhere?
Removing these fields would affect the layout of the structure, and the comments would need to be updated, which would be wasteful and pointless. All unused fields will be removed later.
We decided to invalidate unused GNVS fields by renaming them, so that builds will fail if an instance is missed. On the ASL side, we keep the padding but drop the identifier.
-
Angel Pons (Code Review)