Attention is currently required from: Mac Chiang, Naveen M, Pranava Y N, Subrata Banik, Tongtong Pan, Varun Upadhyay, Weimin Wu.
Paul Menzel has posted comments on this change by Weimin Wu. ( https://review.coreboot.org/c/coreboot/+/85571?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: drivers/soundwire: Support Realtek ALC712 codec
......................................................................
Patch Set 4:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/85571/comment/f73c2382_c2b8ad24?usp... :
PS4, Line 9: Update SoundWire driver to support ALC712 audio codec.
Sorry, for commenting again. Please describe and elaborate, why lane_mapping_count and audio_mode_count is needed. No other driver seems to use it.
https://review.coreboot.org/c/coreboot/+/85571/comment/5f275209_a0f3904c?usp... :
PS4, Line 14: TEST=emerge-fatcat coreboot
I guess, you tested this. Please add the commands how to check that your patch works.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85571?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ib79896a9fe23f2f66d6ee3a24f5a62bfa0f7a649
Gerrit-Change-Number: 85571
Gerrit-PatchSet: 4
Gerrit-Owner: Weimin Wu
wuweimin@huaqin.corp-partner.google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Mac Chiang
mac.chiang@intel.com
Gerrit-Reviewer: Naveen M
naveen.m@intel.corp-partner.google.com
Gerrit-Reviewer: Pranava Y N
pranavayn@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tongtong Pan
pantongtong@huaqin.corp-partner.google.com
Gerrit-Reviewer: Varun Upadhyay
varun.upadhyay@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Naveen M
naveen.m@intel.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Mac Chiang
mac.chiang@intel.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Varun Upadhyay
varun.upadhyay@intel.com
Gerrit-Attention: Weimin Wu
wuweimin@huaqin.corp-partner.google.com
Gerrit-Attention: Tongtong Pan
pantongtong@huaqin.corp-partner.google.com
Gerrit-Attention: Naveen M
naveen.m@intel.corp-partner.google.com
Gerrit-Attention: Pranava Y N
pranavayn@google.com
Gerrit-Comment-Date: Mon, 31 Mar 2025 21:05:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No