Change in coreboot[master]: soc/intel/common: Do not trigger crashlog on all resets by default

[Felix Held (Code Review)]

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/59951 )

Change subject: soc/intel/common: Do not trigger crashlog on all resets by default
......................................................................

soc/intel/common: Do not trigger crashlog on all resets by default

Crashlog has error records and PMC reset records two parts. When we
send ipc cmd "PMC_IPC_CMD_ID_CRASHLOG_ON_RESET", PMC reset record is
enabled. At each warm/cold/global reset, crashlog would be triggered.
The cause of this crash would be "TRIGGER_ON_ALL_RESETS", it is used to
catch unknown reset reason. At the same time, we would see [Hardware
Error] in the kernel log.

If we default enable TRIGGER_ON_ALL_RESETS, we would have too many false
alarm. Now we disable PMC reset records part by default. And we could
enable it when we need it for the debug purpose.

The generated bert dump is under /var/spool/crash/, we could check this
path to verify this CONFIG disable/enable status.

BUG=b:202737385
TEST=No new bert dump after a warm reset.

Signed-off-by: Curtis Chen 
Change-Id: I3ec4ff3c8a3799156de030f4556fe6ce61305139
Reviewed-on: https://review.coreboot.org/c/coreboot/+/59951
Tested-by: build bot (Jenkins) 
Reviewed-by: Tim Wawrzynczak 
---
M src/soc/intel/alderlake/Kconfig
M src/soc/intel/common/Kconfig.common
M src/soc/intel/common/block/crashlog/crashlog.c
M src/soc/intel/tigerlake/Kconfig
4 files changed, 18 insertions(+), 16 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Tim Wawrzynczak: Looks good to me, approved

diff --git a/src/soc/intel/alderlake/Kconfig b/src/soc/intel/alderlake/Kconfig
index 9e69663..46fd742 100644
--- a/src/soc/intel/alderlake/Kconfig
+++ b/src/soc/intel/alderlake/Kconfig
@@ -333,13 +333,6 @@
    int
    default 16

-config SOC_INTEL_CRASHLOG
-	def_bool n
-	select SOC_INTEL_COMMON_BLOCK_CRASHLOG
-	select ACPI_BERT
-	help
-	  Enables CrashLog.
-
 config ACPI_ADL_IPU_ES_SUPPORT
    def_bool n
    help
diff --git a/src/soc/intel/common/Kconfig.common b/src/soc/intel/common/Kconfig.common
index 5f1f608..c7e1aec 100644
--- a/src/soc/intel/common/Kconfig.common
+++ b/src/soc/intel/common/Kconfig.common
@@ -79,4 +79,18 @@
    hex
    default 0x800

+config SOC_INTEL_CRASHLOG
+	def_bool n
+	select SOC_INTEL_COMMON_BLOCK_CRASHLOG
+	select ACPI_BERT
+	help
+	  Enables Crashlog.
+
+config SOC_INTEL_CRASHLOG_ON_RESET
+	def_bool n
+	help
+	  Enables the PMC to collect crashlog records on every reset event. NOTE:
+	  This will result in a BERT table being populated containing a PMC
+	  crashlog record on every boot.
+
 endif # SOC_INTEL_COMMON
diff --git a/src/soc/intel/common/block/crashlog/crashlog.c b/src/soc/intel/common/block/crashlog/crashlog.c
index c3d0cfd..8c31d03 100644
--- a/src/soc/intel/common/block/crashlog/crashlog.c
+++ b/src/soc/intel/common/block/crashlog/crashlog.c
@@ -479,8 +479,10 @@
 {
    if (pmc_crashlog_support() && cl_pmc_data_present()
    	&& (cl_get_pmc_record_size() > 0)) {
-		cl_pmc_en_gen_on_all_reboot();
-		printk(BIOS_DEBUG, "Crashlog collection enabled on every reboot.\n");
+		if (CONFIG(SOC_INTEL_CRASHLOG_ON_RESET)) {
+			cl_pmc_en_gen_on_all_reboot();
+			printk(BIOS_DEBUG, "Crashlog collection enabled on every reboot.\n");
+		}
    	cl_get_pmc_sram_data();
    } else {
    	printk(BIOS_DEBUG, "Skipping PMC crashLog collection. Data not present.\n");
diff --git a/src/soc/intel/tigerlake/Kconfig b/src/soc/intel/tigerlake/Kconfig
index a7b3ae4..cf59b60 100644
--- a/src/soc/intel/tigerlake/Kconfig
+++ b/src/soc/intel/tigerlake/Kconfig
@@ -284,13 +284,6 @@
    int
    default 16

-config SOC_INTEL_CRASHLOG
-	def_bool n
-	select SOC_INTEL_COMMON_BLOCK_CRASHLOG
-	select ACPI_BERT
-	help
-	  Enables CrashLog.
-
 # Intel recommends reserving the following resources per USB4 root port,
 # from TGL BIOS Spec (doc #611569) Revision 0.7.6 Section 7.2.5.1.5
 # - 42 buses