Attention is currently required from: Patrick Rudolph.
Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49973 )
Change subject: sb/intel/common/firmware/Kconfig
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
The Kconfig is part of the choice and allows you to keep the IFD unmodified.
You're right.
I could not detect the config in other code and assume that the other selections will be used.
After re-check I noticed that removing this config LOCK_MANAGEMENT_ENGINE or UNLOCK_FLASH_REGIONS must be select and these config is used in Makefile.inc
--
To view, visit
https://review.coreboot.org/c/coreboot/+/49973
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I077effc4df922f99f2e6ba81e08f6ee2b4ee2fca
Gerrit-Change-Number: 49973
Gerrit-PatchSet: 1
Gerrit-Owner: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Wed, 27 Jan 2021 10:34:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Rudolph
siro@das-labor.org
Gerrit-MessageType: comment