Matt DeVillier has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/80057?usp=email )
Change subject: Revert "soc/intel/cannonlake: Add missing min sleep state for thermal device" ......................................................................
Revert "soc/intel/cannonlake: Add missing min sleep state for thermal device"
This reverts commit d64b66ba267a217d0b6716309019c36c8cfdf8c2: "soc/intel/cannonlake: Add missing min sleep state for thermal device."
Reverting because commit e00523aae2ea ("soc/intel/cannonlake: Drop entries from soc_acpi_name()") removed the ACPI device name for the PCH thermal device, since there is no ACPI device defined for it. Removing the name without removing the minimum sleep state caused an invalid LPI entry to be created, which caused a Windows BSOD: INTERNAL_POWER_ERROR.
TEST=build/boot Win11 on google/puff (wyvern).
Change-Id: I2dfe76d5f72cde7742cee338fa24eaafb84c4604 Signed-off-by: Matt DeVillier matt.devillier@gmail.com --- M src/soc/intel/cannonlake/acpi.c 1 file changed, 0 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/57/80057/1
diff --git a/src/soc/intel/cannonlake/acpi.c b/src/soc/intel/cannonlake/acpi.c index 1545d19..ff93e2a 100644 --- a/src/soc/intel/cannonlake/acpi.c +++ b/src/soc/intel/cannonlake/acpi.c @@ -170,7 +170,6 @@ { SA_DEVFN_TS, ACPI_DEVICE_SLEEP_D3 }, { SA_DEVFN_IPU, ACPI_DEVICE_SLEEP_D3 }, { SA_DEVFN_GNA, ACPI_DEVICE_SLEEP_D3 }, - { PCH_DEVFN_THERMAL, ACPI_DEVICE_SLEEP_D3 }, { PCH_DEVFN_UFS, ACPI_DEVICE_SLEEP_D3 }, { PCH_DEVFN_GSPI2, ACPI_DEVICE_SLEEP_D3 }, { PCH_DEVFN_ISH, ACPI_DEVICE_SLEEP_D3 },