Attention is currently required from: Michał Żygowski, Arthur Heymans, Alexander Couzens, Kyösti Mälkki, Patrick Rudolph, Piotr Król. Hello Arthur Heymans, Kyösti Mälkki,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/53981
to review the following change.
Change subject: AGESA boards: Drop comments about `IDS_DEBUG_PORT` ......................................................................
AGESA boards: Drop comments about `IDS_DEBUG_PORT`
No board defines this macro. In preparation to drop OptionsIds.h files from mainboards, remove commented-out references to `IDS_DEBUG_PORT`.
Change-Id: I67a10d863aeea9e1b91c38aa02d19106b7b97659 Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/mainboard/amd/inagua/OptionsIds.h M src/mainboard/amd/olivehill/OptionsIds.h M src/mainboard/amd/parmer/OptionsIds.h M src/mainboard/amd/persimmon/OptionsIds.h M src/mainboard/amd/south_station/OptionsIds.h M src/mainboard/amd/thatcher/OptionsIds.h M src/mainboard/amd/union_station/OptionsIds.h M src/mainboard/asrock/e350m1/OptionsIds.h M src/mainboard/asrock/imb-a180/OptionsIds.h M src/mainboard/asus/a88xm-e/OptionsIds.h M src/mainboard/asus/am1i-a/OptionsIds.h M src/mainboard/asus/f2a85-m/OptionsIds.h M src/mainboard/bap/ode_e20XX/OptionsIds.h M src/mainboard/biostar/a68n_5200/OptionsIds.h M src/mainboard/biostar/am1ml/OptionsIds.h M src/mainboard/elmex/pcm205400/OptionsIds.h M src/mainboard/gizmosphere/gizmo/OptionsIds.h M src/mainboard/gizmosphere/gizmo2/OptionsIds.h M src/mainboard/hp/abm/OptionsIds.h M src/mainboard/hp/pavilion_m6_1035dx/OptionsIds.h M src/mainboard/jetway/nf81-t56n-lf/OptionsIds.h M src/mainboard/lenovo/g505s/OptionsIds.h M src/mainboard/lippert/frontrunner-af/OptionsIds.h M src/mainboard/msi/ms7721/OptionsIds.h M src/mainboard/pcengines/apu1/OptionsIds.h 25 files changed, 0 insertions(+), 50 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/81/53981/1
diff --git a/src/mainboard/amd/inagua/OptionsIds.h b/src/mainboard/amd/inagua/OptionsIds.h index f035e7d..fdd5de0 100644 --- a/src/mainboard/amd/inagua/OptionsIds.h +++ b/src/mainboard/amd/inagua/OptionsIds.h @@ -24,7 +24,6 @@ * IDSOPT_TRACING_ENABLED * IDSOPT_PERF_ANALYSIS * IDSOPT_ASSERT_ENABLED - * IDS_DEBUG_PORT * IDSOPT_CAR_CORRUPTION_CHECK_ENABLED * **/ @@ -33,6 +32,5 @@ //#define IDSOPT_TRACING_ENABLED TRUE #define IDSOPT_ASSERT_ENABLED TRUE
-//#define IDS_DEBUG_PORT 0x80
#endif diff --git a/src/mainboard/amd/olivehill/OptionsIds.h b/src/mainboard/amd/olivehill/OptionsIds.h index 4ca6b4e..130d852 100644 --- a/src/mainboard/amd/olivehill/OptionsIds.h +++ b/src/mainboard/amd/olivehill/OptionsIds.h @@ -24,7 +24,6 @@ * IDSOPT_TRACING_ENABLED * IDSOPT_PERF_ANALYSIS * IDSOPT_ASSERT_ENABLED - * IDS_DEBUG_PORT * IDSOPT_CAR_CORRUPTION_CHECK_ENABLED * **/ @@ -35,6 +34,5 @@ #define IDSOPT_TRACING_CONSOLE_SERIALPORT TRUE //#define IDSOPT_PERF_ANALYSIS TRUE #define IDSOPT_ASSERT_ENABLED TRUE -//#define IDS_DEBUG_PORT 0x80
#endif diff --git a/src/mainboard/amd/parmer/OptionsIds.h b/src/mainboard/amd/parmer/OptionsIds.h index 4ca6b4e..130d852 100644 --- a/src/mainboard/amd/parmer/OptionsIds.h +++ b/src/mainboard/amd/parmer/OptionsIds.h @@ -24,7 +24,6 @@ * IDSOPT_TRACING_ENABLED * IDSOPT_PERF_ANALYSIS * IDSOPT_ASSERT_ENABLED - * IDS_DEBUG_PORT * IDSOPT_CAR_CORRUPTION_CHECK_ENABLED * **/ @@ -35,6 +34,5 @@ #define IDSOPT_TRACING_CONSOLE_SERIALPORT TRUE //#define IDSOPT_PERF_ANALYSIS TRUE #define IDSOPT_ASSERT_ENABLED TRUE -//#define IDS_DEBUG_PORT 0x80
#endif diff --git a/src/mainboard/amd/persimmon/OptionsIds.h b/src/mainboard/amd/persimmon/OptionsIds.h index f035e7d..fdd5de0 100644 --- a/src/mainboard/amd/persimmon/OptionsIds.h +++ b/src/mainboard/amd/persimmon/OptionsIds.h @@ -24,7 +24,6 @@ * IDSOPT_TRACING_ENABLED * IDSOPT_PERF_ANALYSIS * IDSOPT_ASSERT_ENABLED - * IDS_DEBUG_PORT * IDSOPT_CAR_CORRUPTION_CHECK_ENABLED * **/ @@ -33,6 +32,5 @@ //#define IDSOPT_TRACING_ENABLED TRUE #define IDSOPT_ASSERT_ENABLED TRUE
-//#define IDS_DEBUG_PORT 0x80
#endif diff --git a/src/mainboard/amd/south_station/OptionsIds.h b/src/mainboard/amd/south_station/OptionsIds.h index f035e7d..fdd5de0 100644 --- a/src/mainboard/amd/south_station/OptionsIds.h +++ b/src/mainboard/amd/south_station/OptionsIds.h @@ -24,7 +24,6 @@ * IDSOPT_TRACING_ENABLED * IDSOPT_PERF_ANALYSIS * IDSOPT_ASSERT_ENABLED - * IDS_DEBUG_PORT * IDSOPT_CAR_CORRUPTION_CHECK_ENABLED * **/ @@ -33,6 +32,5 @@ //#define IDSOPT_TRACING_ENABLED TRUE #define IDSOPT_ASSERT_ENABLED TRUE
-//#define IDS_DEBUG_PORT 0x80
#endif diff --git a/src/mainboard/amd/thatcher/OptionsIds.h b/src/mainboard/amd/thatcher/OptionsIds.h index 4ca6b4e..130d852 100644 --- a/src/mainboard/amd/thatcher/OptionsIds.h +++ b/src/mainboard/amd/thatcher/OptionsIds.h @@ -24,7 +24,6 @@ * IDSOPT_TRACING_ENABLED * IDSOPT_PERF_ANALYSIS * IDSOPT_ASSERT_ENABLED - * IDS_DEBUG_PORT * IDSOPT_CAR_CORRUPTION_CHECK_ENABLED * **/ @@ -35,6 +34,5 @@ #define IDSOPT_TRACING_CONSOLE_SERIALPORT TRUE //#define IDSOPT_PERF_ANALYSIS TRUE #define IDSOPT_ASSERT_ENABLED TRUE -//#define IDS_DEBUG_PORT 0x80
#endif diff --git a/src/mainboard/amd/union_station/OptionsIds.h b/src/mainboard/amd/union_station/OptionsIds.h index f035e7d..fdd5de0 100644 --- a/src/mainboard/amd/union_station/OptionsIds.h +++ b/src/mainboard/amd/union_station/OptionsIds.h @@ -24,7 +24,6 @@ * IDSOPT_TRACING_ENABLED * IDSOPT_PERF_ANALYSIS * IDSOPT_ASSERT_ENABLED - * IDS_DEBUG_PORT * IDSOPT_CAR_CORRUPTION_CHECK_ENABLED * **/ @@ -33,6 +32,5 @@ //#define IDSOPT_TRACING_ENABLED TRUE #define IDSOPT_ASSERT_ENABLED TRUE
-//#define IDS_DEBUG_PORT 0x80
#endif diff --git a/src/mainboard/asrock/e350m1/OptionsIds.h b/src/mainboard/asrock/e350m1/OptionsIds.h index fded3c6..5a46df2 100644 --- a/src/mainboard/asrock/e350m1/OptionsIds.h +++ b/src/mainboard/asrock/e350m1/OptionsIds.h @@ -24,7 +24,6 @@ * IDSOPT_TRACING_ENABLED * IDSOPT_PERF_ANALYSIS * IDSOPT_ASSERT_ENABLED - * IDS_DEBUG_PORT * IDSOPT_CAR_CORRUPTION_CHECK_ENABLED * **/ @@ -34,6 +33,5 @@ //#define IDSOPT_TRACING_ENABLED TRUE //#define IDSOPT_PERF_ANALYSIS TRUE #define IDSOPT_ASSERT_ENABLED TRUE -//#define IDS_DEBUG_PORT 0x80
#endif diff --git a/src/mainboard/asrock/imb-a180/OptionsIds.h b/src/mainboard/asrock/imb-a180/OptionsIds.h index 4ca6b4e..130d852 100644 --- a/src/mainboard/asrock/imb-a180/OptionsIds.h +++ b/src/mainboard/asrock/imb-a180/OptionsIds.h @@ -24,7 +24,6 @@ * IDSOPT_TRACING_ENABLED * IDSOPT_PERF_ANALYSIS * IDSOPT_ASSERT_ENABLED - * IDS_DEBUG_PORT * IDSOPT_CAR_CORRUPTION_CHECK_ENABLED * **/ @@ -35,6 +34,5 @@ #define IDSOPT_TRACING_CONSOLE_SERIALPORT TRUE //#define IDSOPT_PERF_ANALYSIS TRUE #define IDSOPT_ASSERT_ENABLED TRUE -//#define IDS_DEBUG_PORT 0x80
#endif diff --git a/src/mainboard/asus/a88xm-e/OptionsIds.h b/src/mainboard/asus/a88xm-e/OptionsIds.h index fe5356b..b7d9144 100644 --- a/src/mainboard/asus/a88xm-e/OptionsIds.h +++ b/src/mainboard/asus/a88xm-e/OptionsIds.h @@ -22,7 +22,6 @@ * IDSOPT_TRACING_ENABLED * IDSOPT_PERF_ANALYSIS * IDSOPT_ASSERT_ENABLED - * IDS_DEBUG_PORT * IDSOPT_CAR_CORRUPTION_CHECK_ENABLED **/
@@ -32,6 +31,5 @@ #define IDSOPT_TRACING_CONSOLE_SERIALPORT TRUE //#define IDSOPT_PERF_ANALYSIS TRUE #define IDSOPT_ASSERT_ENABLED TRUE -//#define IDS_DEBUG_PORT 0x80
#endif diff --git a/src/mainboard/asus/am1i-a/OptionsIds.h b/src/mainboard/asus/am1i-a/OptionsIds.h index 4ca6b4e..130d852 100644 --- a/src/mainboard/asus/am1i-a/OptionsIds.h +++ b/src/mainboard/asus/am1i-a/OptionsIds.h @@ -24,7 +24,6 @@ * IDSOPT_TRACING_ENABLED * IDSOPT_PERF_ANALYSIS * IDSOPT_ASSERT_ENABLED - * IDS_DEBUG_PORT * IDSOPT_CAR_CORRUPTION_CHECK_ENABLED * **/ @@ -35,6 +34,5 @@ #define IDSOPT_TRACING_CONSOLE_SERIALPORT TRUE //#define IDSOPT_PERF_ANALYSIS TRUE #define IDSOPT_ASSERT_ENABLED TRUE -//#define IDS_DEBUG_PORT 0x80
#endif diff --git a/src/mainboard/asus/f2a85-m/OptionsIds.h b/src/mainboard/asus/f2a85-m/OptionsIds.h index f8ec6c9..690f702 100644 --- a/src/mainboard/asus/f2a85-m/OptionsIds.h +++ b/src/mainboard/asus/f2a85-m/OptionsIds.h @@ -24,7 +24,6 @@ * IDSOPT_TRACING_ENABLED * IDSOPT_PERF_ANALYSIS * IDSOPT_ASSERT_ENABLED - * IDS_DEBUG_PORT * IDSOPT_CAR_CORRUPTION_CHECK_ENABLED * **/ @@ -35,6 +34,5 @@ #define IDSOPT_TRACING_CONSOLE_SERIALPORT TRUE //#define IDSOPT_PERF_ANALYSIS TRUE #define IDSOPT_ASSERT_ENABLED TRUE -//#define IDS_DEBUG_PORT 0x80
#endif diff --git a/src/mainboard/bap/ode_e20XX/OptionsIds.h b/src/mainboard/bap/ode_e20XX/OptionsIds.h index 4ca6b4e..130d852 100644 --- a/src/mainboard/bap/ode_e20XX/OptionsIds.h +++ b/src/mainboard/bap/ode_e20XX/OptionsIds.h @@ -24,7 +24,6 @@ * IDSOPT_TRACING_ENABLED * IDSOPT_PERF_ANALYSIS * IDSOPT_ASSERT_ENABLED - * IDS_DEBUG_PORT * IDSOPT_CAR_CORRUPTION_CHECK_ENABLED * **/ @@ -35,6 +34,5 @@ #define IDSOPT_TRACING_CONSOLE_SERIALPORT TRUE //#define IDSOPT_PERF_ANALYSIS TRUE #define IDSOPT_ASSERT_ENABLED TRUE -//#define IDS_DEBUG_PORT 0x80
#endif diff --git a/src/mainboard/biostar/a68n_5200/OptionsIds.h b/src/mainboard/biostar/a68n_5200/OptionsIds.h index 4ca6b4e..130d852 100644 --- a/src/mainboard/biostar/a68n_5200/OptionsIds.h +++ b/src/mainboard/biostar/a68n_5200/OptionsIds.h @@ -24,7 +24,6 @@ * IDSOPT_TRACING_ENABLED * IDSOPT_PERF_ANALYSIS * IDSOPT_ASSERT_ENABLED - * IDS_DEBUG_PORT * IDSOPT_CAR_CORRUPTION_CHECK_ENABLED * **/ @@ -35,6 +34,5 @@ #define IDSOPT_TRACING_CONSOLE_SERIALPORT TRUE //#define IDSOPT_PERF_ANALYSIS TRUE #define IDSOPT_ASSERT_ENABLED TRUE -//#define IDS_DEBUG_PORT 0x80
#endif diff --git a/src/mainboard/biostar/am1ml/OptionsIds.h b/src/mainboard/biostar/am1ml/OptionsIds.h index 4ca6b4e..130d852 100644 --- a/src/mainboard/biostar/am1ml/OptionsIds.h +++ b/src/mainboard/biostar/am1ml/OptionsIds.h @@ -24,7 +24,6 @@ * IDSOPT_TRACING_ENABLED * IDSOPT_PERF_ANALYSIS * IDSOPT_ASSERT_ENABLED - * IDS_DEBUG_PORT * IDSOPT_CAR_CORRUPTION_CHECK_ENABLED * **/ @@ -35,6 +34,5 @@ #define IDSOPT_TRACING_CONSOLE_SERIALPORT TRUE //#define IDSOPT_PERF_ANALYSIS TRUE #define IDSOPT_ASSERT_ENABLED TRUE -//#define IDS_DEBUG_PORT 0x80
#endif diff --git a/src/mainboard/elmex/pcm205400/OptionsIds.h b/src/mainboard/elmex/pcm205400/OptionsIds.h index f035e7d..fdd5de0 100644 --- a/src/mainboard/elmex/pcm205400/OptionsIds.h +++ b/src/mainboard/elmex/pcm205400/OptionsIds.h @@ -24,7 +24,6 @@ * IDSOPT_TRACING_ENABLED * IDSOPT_PERF_ANALYSIS * IDSOPT_ASSERT_ENABLED - * IDS_DEBUG_PORT * IDSOPT_CAR_CORRUPTION_CHECK_ENABLED * **/ @@ -33,6 +32,5 @@ //#define IDSOPT_TRACING_ENABLED TRUE #define IDSOPT_ASSERT_ENABLED TRUE
-//#define IDS_DEBUG_PORT 0x80
#endif diff --git a/src/mainboard/gizmosphere/gizmo/OptionsIds.h b/src/mainboard/gizmosphere/gizmo/OptionsIds.h index f035e7d..fdd5de0 100644 --- a/src/mainboard/gizmosphere/gizmo/OptionsIds.h +++ b/src/mainboard/gizmosphere/gizmo/OptionsIds.h @@ -24,7 +24,6 @@ * IDSOPT_TRACING_ENABLED * IDSOPT_PERF_ANALYSIS * IDSOPT_ASSERT_ENABLED - * IDS_DEBUG_PORT * IDSOPT_CAR_CORRUPTION_CHECK_ENABLED * **/ @@ -33,6 +32,5 @@ //#define IDSOPT_TRACING_ENABLED TRUE #define IDSOPT_ASSERT_ENABLED TRUE
-//#define IDS_DEBUG_PORT 0x80
#endif diff --git a/src/mainboard/gizmosphere/gizmo2/OptionsIds.h b/src/mainboard/gizmosphere/gizmo2/OptionsIds.h index 4ca6b4e..130d852 100644 --- a/src/mainboard/gizmosphere/gizmo2/OptionsIds.h +++ b/src/mainboard/gizmosphere/gizmo2/OptionsIds.h @@ -24,7 +24,6 @@ * IDSOPT_TRACING_ENABLED * IDSOPT_PERF_ANALYSIS * IDSOPT_ASSERT_ENABLED - * IDS_DEBUG_PORT * IDSOPT_CAR_CORRUPTION_CHECK_ENABLED * **/ @@ -35,6 +34,5 @@ #define IDSOPT_TRACING_CONSOLE_SERIALPORT TRUE //#define IDSOPT_PERF_ANALYSIS TRUE #define IDSOPT_ASSERT_ENABLED TRUE -//#define IDS_DEBUG_PORT 0x80
#endif diff --git a/src/mainboard/hp/abm/OptionsIds.h b/src/mainboard/hp/abm/OptionsIds.h index 70affed..5700025 100644 --- a/src/mainboard/hp/abm/OptionsIds.h +++ b/src/mainboard/hp/abm/OptionsIds.h @@ -28,7 +28,6 @@ * IDSOPT_TRACING_ENABLED * IDSOPT_PERF_ANALYSIS * IDSOPT_ASSERT_ENABLED - * IDS_DEBUG_PORT * IDSOPT_CAR_CORRUPTION_CHECK_ENABLED * **/ @@ -39,6 +38,5 @@ #define IDSOPT_TRACING_CONSOLE_SERIALPORT TRUE //#define IDSOPT_PERF_ANALYSIS TRUE #define IDSOPT_ASSERT_ENABLED TRUE -//#define IDS_DEBUG_PORT 0x80
#endif /* _OPTION_IDS_H_ */ diff --git a/src/mainboard/hp/pavilion_m6_1035dx/OptionsIds.h b/src/mainboard/hp/pavilion_m6_1035dx/OptionsIds.h index 4ca6b4e..130d852 100644 --- a/src/mainboard/hp/pavilion_m6_1035dx/OptionsIds.h +++ b/src/mainboard/hp/pavilion_m6_1035dx/OptionsIds.h @@ -24,7 +24,6 @@ * IDSOPT_TRACING_ENABLED * IDSOPT_PERF_ANALYSIS * IDSOPT_ASSERT_ENABLED - * IDS_DEBUG_PORT * IDSOPT_CAR_CORRUPTION_CHECK_ENABLED * **/ @@ -35,6 +34,5 @@ #define IDSOPT_TRACING_CONSOLE_SERIALPORT TRUE //#define IDSOPT_PERF_ANALYSIS TRUE #define IDSOPT_ASSERT_ENABLED TRUE -//#define IDS_DEBUG_PORT 0x80
#endif diff --git a/src/mainboard/jetway/nf81-t56n-lf/OptionsIds.h b/src/mainboard/jetway/nf81-t56n-lf/OptionsIds.h index f035e7d..fdd5de0 100644 --- a/src/mainboard/jetway/nf81-t56n-lf/OptionsIds.h +++ b/src/mainboard/jetway/nf81-t56n-lf/OptionsIds.h @@ -24,7 +24,6 @@ * IDSOPT_TRACING_ENABLED * IDSOPT_PERF_ANALYSIS * IDSOPT_ASSERT_ENABLED - * IDS_DEBUG_PORT * IDSOPT_CAR_CORRUPTION_CHECK_ENABLED * **/ @@ -33,6 +32,5 @@ //#define IDSOPT_TRACING_ENABLED TRUE #define IDSOPT_ASSERT_ENABLED TRUE
-//#define IDS_DEBUG_PORT 0x80
#endif diff --git a/src/mainboard/lenovo/g505s/OptionsIds.h b/src/mainboard/lenovo/g505s/OptionsIds.h index 4ca6b4e..130d852 100644 --- a/src/mainboard/lenovo/g505s/OptionsIds.h +++ b/src/mainboard/lenovo/g505s/OptionsIds.h @@ -24,7 +24,6 @@ * IDSOPT_TRACING_ENABLED * IDSOPT_PERF_ANALYSIS * IDSOPT_ASSERT_ENABLED - * IDS_DEBUG_PORT * IDSOPT_CAR_CORRUPTION_CHECK_ENABLED * **/ @@ -35,6 +34,5 @@ #define IDSOPT_TRACING_CONSOLE_SERIALPORT TRUE //#define IDSOPT_PERF_ANALYSIS TRUE #define IDSOPT_ASSERT_ENABLED TRUE -//#define IDS_DEBUG_PORT 0x80
#endif diff --git a/src/mainboard/lippert/frontrunner-af/OptionsIds.h b/src/mainboard/lippert/frontrunner-af/OptionsIds.h index f035e7d..fdd5de0 100644 --- a/src/mainboard/lippert/frontrunner-af/OptionsIds.h +++ b/src/mainboard/lippert/frontrunner-af/OptionsIds.h @@ -24,7 +24,6 @@ * IDSOPT_TRACING_ENABLED * IDSOPT_PERF_ANALYSIS * IDSOPT_ASSERT_ENABLED - * IDS_DEBUG_PORT * IDSOPT_CAR_CORRUPTION_CHECK_ENABLED * **/ @@ -33,6 +32,5 @@ //#define IDSOPT_TRACING_ENABLED TRUE #define IDSOPT_ASSERT_ENABLED TRUE
-//#define IDS_DEBUG_PORT 0x80
#endif diff --git a/src/mainboard/msi/ms7721/OptionsIds.h b/src/mainboard/msi/ms7721/OptionsIds.h index f8ec6c9..690f702 100644 --- a/src/mainboard/msi/ms7721/OptionsIds.h +++ b/src/mainboard/msi/ms7721/OptionsIds.h @@ -24,7 +24,6 @@ * IDSOPT_TRACING_ENABLED * IDSOPT_PERF_ANALYSIS * IDSOPT_ASSERT_ENABLED - * IDS_DEBUG_PORT * IDSOPT_CAR_CORRUPTION_CHECK_ENABLED * **/ @@ -35,6 +34,5 @@ #define IDSOPT_TRACING_CONSOLE_SERIALPORT TRUE //#define IDSOPT_PERF_ANALYSIS TRUE #define IDSOPT_ASSERT_ENABLED TRUE -//#define IDS_DEBUG_PORT 0x80
#endif diff --git a/src/mainboard/pcengines/apu1/OptionsIds.h b/src/mainboard/pcengines/apu1/OptionsIds.h index f035e7d..fdd5de0 100644 --- a/src/mainboard/pcengines/apu1/OptionsIds.h +++ b/src/mainboard/pcengines/apu1/OptionsIds.h @@ -24,7 +24,6 @@ * IDSOPT_TRACING_ENABLED * IDSOPT_PERF_ANALYSIS * IDSOPT_ASSERT_ENABLED - * IDS_DEBUG_PORT * IDSOPT_CAR_CORRUPTION_CHECK_ENABLED * **/ @@ -33,6 +32,5 @@ //#define IDSOPT_TRACING_ENABLED TRUE #define IDSOPT_ASSERT_ENABLED TRUE
-//#define IDS_DEBUG_PORT 0x80
#endif
-
Angel Pons (Code Review)