Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/41930 )
Change subject: soc/intel/broadwell/Kconfig: Tidy up selected symbols ......................................................................
soc/intel/broadwell/Kconfig: Tidy up selected symbols
Order the `select` entries alphabetically except for the stage architecture entries. Also, rename the dummy symbol where these are selected from `CPU_SPECIFIC_OPTIONS` to `SOC_SPECIFIC_OPTIONS`, because the original symbol would result in name clashes in future commits.
With BUILD_TIMELESS=1 but without adding the .config file into the resulting coreboot image, google/auron (Buddy) remains identical.
Change-Id: I042189c271bf918bf7d988ecdc062ffeccfd881a Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/soc/intel/broadwell/Kconfig 1 file changed, 19 insertions(+), 19 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/30/41930/1
diff --git a/src/soc/intel/broadwell/Kconfig b/src/soc/intel/broadwell/Kconfig index 67f7563..bdbdda4 100644 --- a/src/soc/intel/broadwell/Kconfig +++ b/src/soc/intel/broadwell/Kconfig @@ -5,7 +5,7 @@
if SOC_INTEL_BROADWELL
-config CPU_SPECIFIC_OPTIONS +config SOC_SPECIFIC_OPTIONS def_bool y select ACPI_INTEL_HARDWARE_SLEEP_VALUES select ARCH_BOOTBLOCK_X86_32 @@ -14,37 +14,37 @@ select ARCH_RAMSTAGE_X86_32 select BOOT_DEVICE_SUPPORTS_WRITES select CACHE_MRC_SETTINGS - select MRC_SETTINGS_PROTECT select CPU_INTEL_COMMON select CPU_INTEL_FIRMWARE_INTERFACE_TABLE - select SUPPORT_CPU_UCODE_IN_CBFS + select HAVE_POWER_STATE_AFTER_FAILURE + select HAVE_POWER_STATE_PREVIOUS_AFTER_FAILURE select HAVE_SMI_HANDLER - select SOUTHBRIDGE_INTEL_COMMON_RESET - select SOUTHBRIDGE_INTEL_COMMON_RTC - select SOUTHBRIDGE_INTEL_COMMON_SMBUS - select SOUTHBRIDGE_INTEL_COMMON_SPI_ICH9 + select HAVE_SPI_CONSOLE_SUPPORT select HAVE_USBDEBUG select IOAPIC - select REG_SCRIPT + select INTEL_DESCRIPTOR_MODE_CAPABLE + select INTEL_GMA_ACPI + select MRC_SETTINGS_PROTECT + select NO_FIXED_XIP_ROM_SIZE select PARALLEL_MP + select REG_SCRIPT select RTC select SMP - select SPI_FLASH - select SSE2 - select TSC_SYNC_MFENCE - select UDELAY_TSC - select TSC_MONOTONIC_TIMER select SOC_INTEL_COMMON select SOC_INTEL_COMMON_BLOCK select SOC_INTEL_COMMON_BLOCK_CPU select SOC_INTEL_COMMON_BLOCK_POWER_LIMIT - select INTEL_DESCRIPTOR_MODE_CAPABLE select SOC_INTEL_COMMON_ACPI_WAKE_SOURCE - select HAVE_SPI_CONSOLE_SUPPORT - select INTEL_GMA_ACPI - select HAVE_POWER_STATE_AFTER_FAILURE - select HAVE_POWER_STATE_PREVIOUS_AFTER_FAILURE - select NO_FIXED_XIP_ROM_SIZE + select SOUTHBRIDGE_INTEL_COMMON_RESET + select SOUTHBRIDGE_INTEL_COMMON_RTC + select SOUTHBRIDGE_INTEL_COMMON_SMBUS + select SOUTHBRIDGE_INTEL_COMMON_SPI_ICH9 + select SPI_FLASH + select SSE2 + select SUPPORT_CPU_UCODE_IN_CBFS + select TSC_MONOTONIC_TIMER + select TSC_SYNC_MFENCE + select UDELAY_TSC
config PCIEXP_ASPM bool
Hello build bot (Jenkins), Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/41930
to look at the new patch set (#5).
Change subject: soc/intel/broadwell/Kconfig: Tidy up selected symbols ......................................................................
soc/intel/broadwell/Kconfig: Tidy up selected symbols
Order the `select` entries alphabetically except for the stage architecture entries. Also, rename the dummy symbol where these are selected from `CPU_SPECIFIC_OPTIONS` to `SOC_SPECIFIC_OPTIONS`, because the original symbol would result in name clashes in future commits.
With BUILD_TIMELESS=1 but without adding the .config file into the resulting coreboot image, google/auron (Buddy) remains identical.
Change-Id: I042189c271bf918bf7d988ecdc062ffeccfd881a Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/soc/intel/broadwell/Kconfig 1 file changed, 18 insertions(+), 18 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/30/41930/5
Hello build bot (Jenkins), Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/41930
to look at the new patch set (#9).
Change subject: soc/intel/broadwell/Kconfig: Tidy up selected symbols ......................................................................
soc/intel/broadwell/Kconfig: Tidy up selected symbols
Order the `select` entries alphabetically except for the stage architecture entries. Also, rename the dummy symbol where these are selected from `CPU_SPECIFIC_OPTIONS` to `SOC_SPECIFIC_OPTIONS`, because the original symbol would result in name clashes in future commits.
With BUILD_TIMELESS=1 but without adding the .config file into the resulting coreboot image, google/auron (Buddy) remains identical.
Change-Id: I042189c271bf918bf7d988ecdc062ffeccfd881a Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/soc/intel/broadwell/Kconfig 1 file changed, 18 insertions(+), 18 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/30/41930/9
Hello build bot (Jenkins), Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/41930
to look at the new patch set (#12).
Change subject: soc/intel/broadwell/Kconfig: Tidy up selected symbols ......................................................................
soc/intel/broadwell/Kconfig: Tidy up selected symbols
Order the `select` entries alphabetically except for the stage architecture entries. Also, rename the dummy symbol where these are selected from `CPU_SPECIFIC_OPTIONS` to `SOC_SPECIFIC_OPTIONS`, because the original symbol would result in name clashes in future commits.
With BUILD_TIMELESS=1 but without adding the .config file into the resulting coreboot image, google/auron (Buddy) remains identical.
Change-Id: I042189c271bf918bf7d988ecdc062ffeccfd881a Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/soc/intel/broadwell/Kconfig 1 file changed, 18 insertions(+), 18 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/30/41930/12
Angel Pons has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/41930 )
Change subject: soc/intel/broadwell/Kconfig: Tidy up selected symbols ......................................................................
Abandoned
-
Angel Pons (Code Review)