Attention is currently required from: Kyösti Mälkki.
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78227?usp=email )
Change subject: sb/intel/bd82x6x: Use helper for PCIe hotplug
......................................................................
Patch Set 2:
(1 comment)
File src/southbridge/intel/bd82x6x/pcie.c:
https://review.coreboot.org/c/coreboot/+/78227/comment/9db83cf1_1f0f880a :
PS1, Line 213: pci_write_config16(dev, 0x42, 0x142);
Good catch. At this point all of the bits are read-only, so I'll drop the write to register 0x42.
See CB:78238
--
To view, visit
https://review.coreboot.org/c/coreboot/+/78227?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I25aae540ff2ffa3ec5b93ed9caa838b4e50048d2
Gerrit-Change-Number: 78227
Gerrit-PatchSet: 2
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Attention: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Comment-Date: Thu, 05 Oct 2023 06:16:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Rudolph
patrick.rudolph@9elements.com
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-MessageType: comment