Attention is currently required from: Michał Żygowski, Patrick Rudolph.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59521 )
Change subject: security/intel/txt/romstage.c: Unlock memory when SCLEAN not needed
......................................................................
Patch Set 3:
(1 comment)
File src/security/intel/txt/romstage.c:
https://review.coreboot.org/c/coreboot/+/59521/comment/7466bad9_c475c0e5
PS3, Line 138: wrmsr(TXT_UNLOCK_MEMORY_MSR, msr);
Yes it does, we have a separate discussion in this patch. […]
I simply don't understand why this is needed. The write in sandybridge native raminit code is unconditionally executed. In which scenario is the native raminit write skipped? I'm pretty sure MRC.bin also does the write.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/59521
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idd29d163a2310f0b574fc72d575f23088ab1d11d
Gerrit-Change-Number: 59521
Gerrit-PatchSet: 3
Gerrit-Owner: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Mon, 22 Nov 2021 16:14:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Michał Żygowski
michal.zygowski@3mdeb.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment