Martin Roth has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/41063 )
Change subject: mb/google/kahlee: Don't reset the touchpad/screen on boot ......................................................................
mb/google/kahlee: Don't reset the touchpad/screen on boot
touchpad & touchscreen power enable gets reset during resume causing unintended wake interrupts, causing dark resume failures. This prevents the board from being shut down after it's been suspended for a long period of time and can end up draining the battery.
BUG=b:153173717 TEST=Build only - Needs to be tested by ODMs.
Signed-off-by: Martin Roth martin@coreboot.org Change-Id: If403da8853e59eaaf589062c9bd6f10deb626998 --- M src/mainboard/google/kahlee/variants/baseboard/gpio.c 1 file changed, 0 insertions(+), 8 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/63/41063/1
diff --git a/src/mainboard/google/kahlee/variants/baseboard/gpio.c b/src/mainboard/google/kahlee/variants/baseboard/gpio.c index fe0744a..72db0a2 100644 --- a/src/mainboard/google/kahlee/variants/baseboard/gpio.c +++ b/src/mainboard/google/kahlee/variants/baseboard/gpio.c @@ -26,10 +26,6 @@ /* GPIO_15 - EC_IN_RW_OD */ PAD_GPI(GPIO_15, PULL_UP),
- /* GPIO_12 - EN_PP3300_TRACKPAD */ - /* Init low to reset the chip */ - PAD_GPO(GPIO_12, LOW), - /* GPIO_22 - EC_SCI_ODL, SCI */ PAD_SCI(GPIO_22, PULL_UP, EDGE_LOW),
@@ -45,10 +41,6 @@ /* GPIO_74 - LPC_CLK0_EC_R */ PAD_NF(GPIO_74, LPCCLK0, PULL_DOWN),
- /* GPIO_76 - EN_PP3300_TOUCHSCREEN */ - /* Init low to reset the chip */ - PAD_GPO(GPIO_76, LOW), - /* GPIO_92 - WLAN_PCIE_CLKREQ_3V3_ODL */ PAD_NF(GPIO_92, CLK_REQ0_L, PULL_UP),
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41063 )
Change subject: mb/google/kahlee: Don't reset the touchpad/screen on boot ......................................................................
Patch Set 1:
(3 comments)
https://review.coreboot.org/c/coreboot/+/41063/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/41063/1//COMMIT_MSG@9 PS1, Line 9: resume The summary says *boot*?
https://review.coreboot.org/c/coreboot/+/41063/1//COMMIT_MSG@10 PS1, Line 10: dark resume failures Does that mean, the screen stays black?
https://review.coreboot.org/c/coreboot/+/41063/1//COMMIT_MSG@12 PS1, Line 12: for a long period of time and can end up draining the battery. Sorry for being slow, but the empty battery causes the shutdown?
Kevin Chiu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41063 )
Change subject: mb/google/kahlee: Don't reset the touchpad/screen on boot ......................................................................
Patch Set 1: Code-Review+2
Hi Martin, try on careena TS sku, TS is functional after cold boot/warm reset/s3. thanks.
Kevin Chiu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41063 )
Change subject: mb/google/kahlee: Don't reset the touchpad/screen on boot ......................................................................
Patch Set 1:
Also the power_WakeSources test item & wake source manual test were passed. (dark resume is disabled).
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41063 )
Change subject: mb/google/kahlee: Don't reset the touchpad/screen on boot ......................................................................
Patch Set 2:
(3 comments)
https://review.coreboot.org/c/coreboot/+/41063/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/41063/1//COMMIT_MSG@9 PS1, Line 9: resume
The summary says *boot*?
Yes, On cold boot or resume (which runs much of the same code as the initial boot. Now it doesn't get reset on any type of boot.
https://review.coreboot.org/c/coreboot/+/41063/1//COMMIT_MSG@10 PS1, Line 10: dark resume failures
Does that mean, the screen stays black?
Yes.
https://review.coreboot.org/c/coreboot/+/41063/1//COMMIT_MSG@12 PS1, Line 12: for a long period of time and can end up draining the battery.
Sorry for being slow, but the empty battery causes the shutdown?
Yes that's the bad case. In the good case the system comes out of S3 and shuts the system down BEFORE the battery is dead.
Martin Roth has submitted this change. ( https://review.coreboot.org/c/coreboot/+/41063 )
Change subject: mb/google/kahlee: Don't reset the touchpad/screen on boot ......................................................................
mb/google/kahlee: Don't reset the touchpad/screen on boot
touchpad & touchscreen power enable gets reset during resume causing unintended wake interrupts, causing dark resume failures. This prevents the board from being shut down after it's been suspended for a long period of time and can end up draining the battery.
BUG=b:153173717 TEST=Build only - Needs to be tested by ODMs.
Signed-off-by: Martin Roth martin@coreboot.org Change-Id: If403da8853e59eaaf589062c9bd6f10deb626998 Reviewed-on: https://review.coreboot.org/c/coreboot/+/41063 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Kevin Chiu Kevin.Chiu@quantatw.com --- M src/mainboard/google/kahlee/variants/baseboard/gpio.c 1 file changed, 0 insertions(+), 8 deletions(-)
Approvals: build bot (Jenkins): Verified Kevin Chiu: Looks good to me, approved
diff --git a/src/mainboard/google/kahlee/variants/baseboard/gpio.c b/src/mainboard/google/kahlee/variants/baseboard/gpio.c index fe0744a..72db0a2 100644 --- a/src/mainboard/google/kahlee/variants/baseboard/gpio.c +++ b/src/mainboard/google/kahlee/variants/baseboard/gpio.c @@ -26,10 +26,6 @@ /* GPIO_15 - EC_IN_RW_OD */ PAD_GPI(GPIO_15, PULL_UP),
- /* GPIO_12 - EN_PP3300_TRACKPAD */ - /* Init low to reset the chip */ - PAD_GPO(GPIO_12, LOW), - /* GPIO_22 - EC_SCI_ODL, SCI */ PAD_SCI(GPIO_22, PULL_UP, EDGE_LOW),
@@ -45,10 +41,6 @@ /* GPIO_74 - LPC_CLK0_EC_R */ PAD_NF(GPIO_74, LPCCLK0, PULL_DOWN),
- /* GPIO_76 - EN_PP3300_TOUCHSCREEN */ - /* Init low to reset the chip */ - PAD_GPO(GPIO_76, LOW), - /* GPIO_92 - WLAN_PCIE_CLKREQ_3V3_ODL */ PAD_NF(GPIO_92, CLK_REQ0_L, PULL_UP),
9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41063 )
Change subject: mb/google/kahlee: Don't reset the touchpad/screen on boot ......................................................................
Patch Set 3:
Automatic boot test returned (PASS/FAIL/TOTAL): 4/0/4 Emulation targets: "QEMU x86 q35/ich9" using payload TianoCore : SUCCESS : https://lava.9esec.io/r/3291 "QEMU x86 q35/ich9" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/3290 "QEMU x86 i440fx/piix4" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/3289 "QEMU AArch64" using payload LinuxBoot_u-root_kexec : SUCCESS : https://lava.9esec.io/r/3288
Please note: This test is under development and might not be accurate at all!