Attention is currently required from: Felix Singer, Martin L Roth.
Werner Zeh has posted comments on this change by Werner Zeh. ( https://review.coreboot.org/c/coreboot/+/85915?usp=email )
Change subject: Documentation: Fix wrong link to commit message guidelines
......................................................................
Patch Set 1:
(1 comment)
File Documentation/contributing/gerrit_guidelines.md:
https://review.coreboot.org/c/coreboot/+/85915/comment/c407b71c_20ccd6bc?usp... :
PS1, Line 442: The first line of the commit message consists of a short
: (less than 65 characters, absolute maximum is 75) summary
I realize this is just ported over, but I think we may want to update/clarify it in a follow-on patc […]
Yes, this is what I realized, too.
I can start a discussion on the mailing list and get peoples suggestions here.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85915?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I1cd2b13da6fe59697d677c7350d73eda5d486544
Gerrit-Change-Number: 85915
Gerrit-PatchSet: 1
Gerrit-Owner: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Comment-Date: Thu, 09 Jan 2025 15:25:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Matt DeVillier
matt.devillier@gmail.com