Attention is currently required from: Maximilian Brune.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73980 )
Change subject: arch/x86/smbios: Check str for NULL in smbios_add_string()
......................................................................
Patch Set 3: Code-Review+1
(1 comment)
File src/arch/x86/smbios.c:
https://review.coreboot.org/c/coreboot/+/73980/comment/6d9ebf6a_7dca61aa
PS2, Line 48: if (str == NULL || *str == '\0')
Done
Thank you for sharing your perspective. (Maybe add it to the commit message.)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/73980
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic228b869aea362c1f07e0808c2735ff3b285a6bd
Gerrit-Change-Number: 73980
Gerrit-PatchSet: 3
Gerrit-Owner: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Reviewer: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Comment-Date: Mon, 03 Apr 2023 11:11:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Comment-In-Reply-To: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-MessageType: comment