Attention is currently required from: Tarun Tuli, Dinesh Gehlot.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74256 )
Change subject: soc/intel/: Store CSE firmware version into cbmem table ......................................................................
Patch Set 6:
(2 comments)
File src/soc/intel/alderlake/romstage/romstage.c:
https://review.coreboot.org/c/coreboot/+/74256/comment/d5acf84e_82af9644 PS6, Line 235: DRIVERS_INTEL_ISH we don't need this check as SOC_INTEL_STORE_CSE_FPT_PARTITION_VERSION already depends on DRIVERS_INTEL_ISH
if SOC_INTEL_STORE_CSE_FPT_PARTITION_VERSION=y meaning DRIVERS_INTEL_ISH is also set
File src/soc/intel/common/block/cse/cse_lite.c:
https://review.coreboot.org/c/coreboot/+/74256/comment/657080e1_9402f2f0 PS6, Line 1184: DRIVERS_INTEL_ISH don't need this.
-
Subrata Banik (Code Review)