Change in coreboot[master]: mb/ocp/deltalake: Update GPIO configurations according to schematics
Jingle Hsu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47229 )
Change subject: mb/ocp/deltalake: Update GPIO configurations according to schematics ......................................................................
Patch Set 8:
(3 comments)
Patch Set 7:
Uhm, I must be missing something... what's wrong with the current gpio config? Why does the "new" one differ that much?
Modify with suitable syntax.
https://review.coreboot.org/c/coreboot/+/47229/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/47229/3//COMMIT_MSG@11 PS3, Line 11: Add a config to switch between EVT and DVT.
On desktop/laptop boards, one would usually have some PCH GPIOs connected to external pull up/down r […]
The DVT and EVT GPIO configurations are the same.
https://review.coreboot.org/c/coreboot/+/47229/6//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/47229/6//COMMIT_MSG@7 PS6, Line 7: mb/ocp/deltalake: Configure GPIO
GPIOs
Done
https://review.coreboot.org/c/coreboot/+/47229/6//COMMIT_MSG@13 PS6, Line 13: by Intel ITP and verify the results match with the header file.
This change is hard to review. Could you split it out in two patches. […]
Modify with suitable syntax.
-
Jingle Hsu (Code Review)