Sridhar Siricilla has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35402 )
Change subject: soc/intel/common/block/cse: Add boot partition related APIs ......................................................................
Patch Set 6:
(4 comments)
This change is ready for review.
https://review.coreboot.org/c/coreboot/+/35402/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/35402/3//COMMIT_MSG@11 PS3, Line 11: within CSE region, and their version and partition status. : SET_BOOT_PARTITION_INFO - Sets the next boot partition to boot for CSE
line between paragraphs will make it more readable.
Done
https://review.coreboot.org/c/coreboot/+/35402/3/src/soc/intel/common/block/... File src/soc/intel/common/block/include/intelblocks/cse.h:
https://review.coreboot.org/c/coreboot/+/35402/3/src/soc/intel/common/block/... PS3, Line 189: uint8_t current_bp;
add description
Done
https://review.coreboot.org/c/coreboot/+/35402/3/src/soc/intel/common/block/... PS3, Line 198: uint8_t flags;
add description
Done
https://review.coreboot.org/c/coreboot/+/35402/2/src/soc/intel/common/block/... File src/soc/intel/common/block/include/intelblocks/cse.h:
https://review.coreboot.org/c/coreboot/+/35402/2/src/soc/intel/common/block/... PS2, Line 153: BP_STATUS_HOST_REQUEST_FOR_PARTITION_SWITCH = 3,
please, no space before tabs
Done
-
Sridhar Siricilla (Code Review)