Attention is currently required from: Furquan Shaikh, Martin Roth, Kangheui Won, Isaac Lee, Marco Chen, EricR Lai.
Frank Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52261 )
Change subject: mb/google/zork/vilboz: Enable SSFC function in vilboz
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
Hi Google,
Would you give us some suggestion?
The audio amp source selection depends on SSFC.
We can use the command to set SSFC "ectool cbi set 8 0x0 4" for old vilboz devices.
The SSFC-updated script is under review now.
This CL prevents other zork platform devices from SSFC.
For now, the SSFC is removed in zork firmware branch.
2820811: Revert "UPSTREAM: mb/google/zork: Enable SSFC as upper 32 bit of fw_config" | https://chromium-review.googlesource.com/c/chromiumos/third_party/coreboot/+...
Details:
https://partnerissuetracker.corp.google.com/issues/184233670#comment9
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52261
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia1987f62ef23140fe2004b81f54fcd00830ced68
Gerrit-Change-Number: 52261
Gerrit-PatchSet: 2
Gerrit-Owner: Frank Wu
frank_wu@compal.corp-partner.google.com
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Isaac Lee
isaaclee@google.com
Gerrit-Reviewer: Kangheui Won
khwon@chromium.org
Gerrit-Reviewer: Marco Chen
marcochen@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Alan Lee
alan_lee@compal.corp-partner.google.com
Gerrit-CC: John Su
john_su@compal.corp-partner.google.com
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Kangheui Won
khwon@chromium.org
Gerrit-Attention: Isaac Lee
isaaclee@google.com
Gerrit-Attention: Marco Chen
marcochen@google.com
Gerrit-Attention: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Comment-Date: Mon, 12 Apr 2021 08:54:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment