Attention is currently required from: Marc Jones, Nico Huber, Jonathan Zhang, Philipp Deppenwiese, Tim Wawrzynczak, Angel Pons, Subrata Banik, Aaron Durbin, Patrick Rudolph, Peter Tsung Ho Wu, Ron Minnich.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52585 )
Change subject: lib: set up specific purpose memory as LB_MEM_SOFT_RESERVED
......................................................................
Patch Set 2:
(1 comment)
File src/include/bootmem.h:
https://review.coreboot.org/c/coreboot/+/52585/comment/21fdf608_5cadc3eb
PS2, Line 32: BM_MEM_OS_CUTOFF = BM_MEM_TABLE,
Careful here! You should insert your new line above BM_MEM_TABLE so the cutoff will still be where it's supposed to. (Right now, I don't think your patch would work because memory types after the cutoff are not written to the coreboot table. Did you test it?)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52585
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie70795bcb8c97e9dd5fb772adc060e1606f9bab0
Gerrit-Change-Number: 52585
Gerrit-PatchSet: 2
Gerrit-Owner: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Marc Jones
marc@marcjonesconsulting.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Peter Tsung Ho Wu
tsung@amazon.com
Gerrit-Reviewer: Philipp Deppenwiese
philipp.deppenwiese@9elements.com
Gerrit-Reviewer: Ron Minnich
rminnich@google.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Marc Jones
marc@marcjonesconsulting.com
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Jonathan Zhang
jonzhang@fb.com
Gerrit-Attention: Philipp Deppenwiese
philipp.deppenwiese@9elements.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Subrata Banik
subrata.banik@intel.com
Gerrit-Attention: Aaron Durbin
adurbin@chromium.org
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Attention: Peter Tsung Ho Wu
tsung@amazon.com
Gerrit-Attention: Ron Minnich
rminnich@google.com
Gerrit-Comment-Date: Wed, 21 Apr 2021 23:36:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment