Attention is currently required from: Nico Huber, Michał Żygowski, Kyösti Mälkki.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52934 )
Change subject: nb/amd/agesa/family14: Use generic allocation functions for northbridge
......................................................................
Patch Set 4:
(2 comments)
File src/northbridge/amd/agesa/family14/northbridge.c:
https://review.coreboot.org/c/coreboot/+/52934/comment/35b60a90_cc57d157
PS4, Line 255: 1
There should be macros for the flags.
Looks like I was looking at a diff between two patchsets.
https://review.coreboot.org/c/coreboot/+/52934/comment/00119038_26c0655f
PS4, Line 370: lovely
I don't think so. In any case, `this lovely routine` doesn't say much. How about: […]
Looks like I was looking at a diff between two patchsets.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52934
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I74a0ed1fcbbc9e066c42c4d51d30ab1d7138134a
Gerrit-Change-Number: 52934
Gerrit-PatchSet: 4
Gerrit-Owner: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Attention: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Comment-Date: Sun, 09 May 2021 13:10:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment