Hello Philip Chen,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/43147
to review the following change.
Change subject: google/trogdor: Add new variant Pompom ......................................................................
google/trogdor: Add new variant Pompom
This patch adds a new variant called Pompom that is identical to Lazor for now. Also reorder variants alphabetically while we're here.
Signed-off-by: Julius Werner jwerner@chromium.org Change-Id: I5a0f297413765bce8353d5a781f0f67446de4e7c --- M src/mainboard/google/trogdor/Kconfig M src/mainboard/google/trogdor/Kconfig.name 2 files changed, 11 insertions(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/47/43147/1
diff --git a/src/mainboard/google/trogdor/Kconfig b/src/mainboard/google/trogdor/Kconfig index dfd98f0..5feee22 100644 --- a/src/mainboard/google/trogdor/Kconfig +++ b/src/mainboard/google/trogdor/Kconfig @@ -49,8 +49,9 @@
config MAINBOARD_PART_NUMBER string - default "Trogdor" if BOARD_GOOGLE_TROGDOR - default "Lazor" if BOARD_GOOGLE_LAZOR default "Bubs" if BOARD_GOOGLE_BUBS + default "Lazor" if BOARD_GOOGLE_LAZOR + default "Pompom" if BOARD_GOOGLE_POMPOM + default "Trogdor" if BOARD_GOOGLE_TROGDOR
endif # BOARD_GOOGLE_TROGDOR_COMMON diff --git a/src/mainboard/google/trogdor/Kconfig.name b/src/mainboard/google/trogdor/Kconfig.name index 7be1a2d..b7c03f9 100644 --- a/src/mainboard/google/trogdor/Kconfig.name +++ b/src/mainboard/google/trogdor/Kconfig.name @@ -1,13 +1,17 @@ comment "Trogdor"
-config BOARD_GOOGLE_TROGDOR - bool "Trogdor" +config BOARD_GOOGLE_BUBS + bool "Bubs" select BOARD_GOOGLE_TROGDOR_COMMON
config BOARD_GOOGLE_LAZOR bool "Lazor" select BOARD_GOOGLE_TROGDOR_COMMON
-config BOARD_GOOGLE_BUBS - bool "Bubs" +config BOARD_GOOGLE_POMPOM + bool "Pompom" + select BOARD_GOOGLE_TROGDOR_COMMON + +config BOARD_GOOGLE_TROGDOR + bool "Trogdor" select BOARD_GOOGLE_TROGDOR_COMMON
Philip Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43147 )
Change subject: google/trogdor: Add new variant Pompom ......................................................................
Patch Set 1:
Do we care about Documentation/security/vboot/list_vboot.md?
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43147 )
Change subject: google/trogdor: Add new variant Pompom ......................................................................
Patch Set 1:
Do we care about Documentation/security/vboot/list_vboot.md?
This is the first time I learn about that file, so I can ask them what the idea there is but for now I'd say no.
Philip Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43147 )
Change subject: google/trogdor: Add new variant Pompom ......................................................................
Patch Set 1: Code-Review+2
Patch Set 1:
Do we care about Documentation/security/vboot/list_vboot.md?
This is the first time I learn about that file, so I can ask them what the idea there is but for now I'd say no.
OK
EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43147 )
Change subject: google/trogdor: Add new variant Pompom ......................................................................
Patch Set 1: Code-Review+2
Julius Werner has submitted this change. ( https://review.coreboot.org/c/coreboot/+/43147 )
Change subject: google/trogdor: Add new variant Pompom ......................................................................
google/trogdor: Add new variant Pompom
This patch adds a new variant called Pompom that is identical to Lazor for now. Also reorder variants alphabetically while we're here.
Signed-off-by: Julius Werner jwerner@chromium.org Change-Id: I5a0f297413765bce8353d5a781f0f67446de4e7c Reviewed-on: https://review.coreboot.org/c/coreboot/+/43147 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Philip Chen philipchen@google.com Reviewed-by: EricR Lai ericr_lai@compal.corp-partner.google.com --- M src/mainboard/google/trogdor/Kconfig M src/mainboard/google/trogdor/Kconfig.name 2 files changed, 11 insertions(+), 6 deletions(-)
Approvals: build bot (Jenkins): Verified Philip Chen: Looks good to me, approved EricR Lai: Looks good to me, approved
diff --git a/src/mainboard/google/trogdor/Kconfig b/src/mainboard/google/trogdor/Kconfig index 0500574..6a0f912 100644 --- a/src/mainboard/google/trogdor/Kconfig +++ b/src/mainboard/google/trogdor/Kconfig @@ -50,8 +50,9 @@
config MAINBOARD_PART_NUMBER string - default "Trogdor" if BOARD_GOOGLE_TROGDOR - default "Lazor" if BOARD_GOOGLE_LAZOR default "Bubs" if BOARD_GOOGLE_BUBS + default "Lazor" if BOARD_GOOGLE_LAZOR + default "Pompom" if BOARD_GOOGLE_POMPOM + default "Trogdor" if BOARD_GOOGLE_TROGDOR
endif # BOARD_GOOGLE_TROGDOR_COMMON diff --git a/src/mainboard/google/trogdor/Kconfig.name b/src/mainboard/google/trogdor/Kconfig.name index 7be1a2d..b7c03f9 100644 --- a/src/mainboard/google/trogdor/Kconfig.name +++ b/src/mainboard/google/trogdor/Kconfig.name @@ -1,13 +1,17 @@ comment "Trogdor"
-config BOARD_GOOGLE_TROGDOR - bool "Trogdor" +config BOARD_GOOGLE_BUBS + bool "Bubs" select BOARD_GOOGLE_TROGDOR_COMMON
config BOARD_GOOGLE_LAZOR bool "Lazor" select BOARD_GOOGLE_TROGDOR_COMMON
-config BOARD_GOOGLE_BUBS - bool "Bubs" +config BOARD_GOOGLE_POMPOM + bool "Pompom" + select BOARD_GOOGLE_TROGDOR_COMMON + +config BOARD_GOOGLE_TROGDOR + bool "Trogdor" select BOARD_GOOGLE_TROGDOR_COMMON