Julius Werner submitted this change.

View Change

Approvals: build bot (Jenkins): Verified Philip Chen: Looks good to me, approved EricR Lai: Looks good to me, approved
google/trogdor: Add new variant Pompom

This patch adds a new variant called Pompom that is identical to Lazor
for now. Also reorder variants alphabetically while we're here.

Signed-off-by: Julius Werner <jwerner@chromium.org>
Change-Id: I5a0f297413765bce8353d5a781f0f67446de4e7c
Reviewed-on: https://review.coreboot.org/c/coreboot/+/43147
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Philip Chen <philipchen@google.com>
Reviewed-by: EricR Lai <ericr_lai@compal.corp-partner.google.com>
---
M src/mainboard/google/trogdor/Kconfig
M src/mainboard/google/trogdor/Kconfig.name
2 files changed, 11 insertions(+), 6 deletions(-)

diff --git a/src/mainboard/google/trogdor/Kconfig b/src/mainboard/google/trogdor/Kconfig
index 0500574..6a0f912 100644
--- a/src/mainboard/google/trogdor/Kconfig
+++ b/src/mainboard/google/trogdor/Kconfig
@@ -50,8 +50,9 @@

config MAINBOARD_PART_NUMBER
string
- default "Trogdor" if BOARD_GOOGLE_TROGDOR
- default "Lazor" if BOARD_GOOGLE_LAZOR
default "Bubs" if BOARD_GOOGLE_BUBS
+ default "Lazor" if BOARD_GOOGLE_LAZOR
+ default "Pompom" if BOARD_GOOGLE_POMPOM
+ default "Trogdor" if BOARD_GOOGLE_TROGDOR

endif # BOARD_GOOGLE_TROGDOR_COMMON
diff --git a/src/mainboard/google/trogdor/Kconfig.name b/src/mainboard/google/trogdor/Kconfig.name
index 7be1a2d..b7c03f9 100644
--- a/src/mainboard/google/trogdor/Kconfig.name
+++ b/src/mainboard/google/trogdor/Kconfig.name
@@ -1,13 +1,17 @@
comment "Trogdor"

-config BOARD_GOOGLE_TROGDOR
- bool "Trogdor"
+config BOARD_GOOGLE_BUBS
+ bool "Bubs"
select BOARD_GOOGLE_TROGDOR_COMMON

config BOARD_GOOGLE_LAZOR
bool "Lazor"
select BOARD_GOOGLE_TROGDOR_COMMON

-config BOARD_GOOGLE_BUBS
- bool "Bubs"
+config BOARD_GOOGLE_POMPOM
+ bool "Pompom"
+ select BOARD_GOOGLE_TROGDOR_COMMON
+
+config BOARD_GOOGLE_TROGDOR
+ bool "Trogdor"
select BOARD_GOOGLE_TROGDOR_COMMON

To view, visit change 43147. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5a0f297413765bce8353d5a781f0f67446de4e7c
Gerrit-Change-Number: 43147
Gerrit-PatchSet: 2
Gerrit-Owner: Julius Werner <jwerner@chromium.org>
Gerrit-Reviewer: EricR Lai <ericr_lai@compal.corp-partner.google.com>
Gerrit-Reviewer: Julius Werner <jwerner@chromium.org>
Gerrit-Reviewer: Philip Chen <philipchen@chromium.org>
Gerrit-Reviewer: Philip Chen <philipchen@google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-CC: mturney mturney <mturney@codeaurora.org>
Gerrit-MessageType: merged