Li1 Feng has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/39478 )
Change subject: drivers/intel/ish: add TGL ISH PCI id ......................................................................
drivers/intel/ish: add TGL ISH PCI id
BRANCH=none BUG=b:145946347 TEST=none
Signed-off-by: Hu, Hebo hebo.hu@intel.com Signed-off-by: li feng li1.feng@intel.com Change-Id: I3a4f73e82f62def3adb2cb1332a315366078c918 --- M src/drivers/intel/ish/Kconfig M src/drivers/intel/ish/ish.c M src/include/device/pci_ids.h 3 files changed, 3 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/39478/1
diff --git a/src/drivers/intel/ish/Kconfig b/src/drivers/intel/ish/Kconfig index 635864e..a2828d1 100644 --- a/src/drivers/intel/ish/Kconfig +++ b/src/drivers/intel/ish/Kconfig @@ -1,5 +1,6 @@ config DRIVERS_INTEL_ISH bool + default n help When enabled, chip driver/intel/ish will publish information to the SSDT _DSD table for the ISH device. diff --git a/src/drivers/intel/ish/ish.c b/src/drivers/intel/ish/ish.c index e9d5ae96..d542bd3 100644 --- a/src/drivers/intel/ish/ish.c +++ b/src/drivers/intel/ish/ish.c @@ -65,6 +65,7 @@ static const unsigned short pci_device_ids[] = { PCI_DEVICE_ID_INTEL_CNL_ISHB, PCI_DEVICE_ID_INTEL_CML_ISHB, + PCI_DEVICE_ID_INTEL_TGL_ISHB, 0 };
diff --git a/src/include/device/pci_ids.h b/src/include/device/pci_ids.h index ccbfe40..3da326b 100644 --- a/src/include/device/pci_ids.h +++ b/src/include/device/pci_ids.h @@ -2105,6 +2105,7 @@ #define PCI_DEVICE_ID_INTEL_82439TX 0x7100 #define PCI_DEVICE_ID_INTEL_CNL_ISHB 0x9dfc #define PCI_DEVICE_ID_INTEL_CML_ISHB 0x02fc +#define PCI_DEVICE_ID_INTEL_TGL_ISHB 0xa0fc
/* Intel 82371FB (PIIX) */ #define PCI_DEVICE_ID_INTEL_82371FB_ISA 0x122e
Li1 Feng has removed Wonkyu Kim from this change. ( https://review.coreboot.org/c/coreboot/+/39478 )
Change subject: drivers/intel/ish: add TGL ISH PCI id ......................................................................
Removed reviewer Wonkyu Kim.
Wonkyu Kim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39478 )
Change subject: drivers/intel/ish: add TGL ISH PCI id ......................................................................
Patch Set 1: Code-Review+2
Wonkyu Kim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39478 )
Change subject: drivers/intel/ish: add TGL ISH PCI id ......................................................................
Patch Set 1: Code-Review+1
Wonkyu Kim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39478 )
Change subject: drivers/intel/ish: add TGL ISH PCI id ......................................................................
Patch Set 1:
(1 comment)
Add topic info: TGL_UPSTREAM
https://review.coreboot.org/c/coreboot/+/39478/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/39478/1//COMMIT_MSG@11 PS1, Line 11: TEST=none Add test information
Wonkyu Kim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39478 )
Change subject: drivers/intel/ish: add TGL ISH PCI id ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39478/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/39478/1//COMMIT_MSG@7 PS1, Line 7: add Add
Hello build bot (Jenkins), Wonkyu Kim, Raj Astekar, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/39478
to look at the new patch set (#2).
Change subject: drivers/intel/ish: Add TGL ISH PCI id ......................................................................
drivers/intel/ish: Add TGL ISH PCI id
BRANCH=none BUG=b:145946347 TEST=none
Signed-off-by: Hu, Hebo hebo.hu@intel.com Signed-off-by: li feng li1.feng@intel.com Change-Id: I3a4f73e82f62def3adb2cb1332a315366078c918 --- M src/drivers/intel/ish/Kconfig M src/drivers/intel/ish/ish.c M src/include/device/pci_ids.h 3 files changed, 3 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/39478/2
Hello build bot (Jenkins), Wonkyu Kim, Raj Astekar, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/39478
to look at the new patch set (#3).
Change subject: TGL_UPSTREAM: drivers/intel/ish: Add TGL ISH PCI id ......................................................................
TGL_UPSTREAM: drivers/intel/ish: Add TGL ISH PCI id
BRANCH=none BUG=b:145946347 TEST=none
Signed-off-by: Hu, Hebo hebo.hu@intel.com Signed-off-by: li feng li1.feng@intel.com Change-Id: I3a4f73e82f62def3adb2cb1332a315366078c918 --- M src/drivers/intel/ish/Kconfig M src/drivers/intel/ish/ish.c M src/include/device/pci_ids.h 3 files changed, 3 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/39478/3
Li1 Feng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39478 )
Change subject: TGL_UPSTREAM: drivers/intel/ish: Add TGL ISH PCI id ......................................................................
Patch Set 3:
(1 comment)
Patch Set 1:
(1 comment)
Add topic info: TGL_UPSTREAM
https://review.coreboot.org/c/coreboot/+/39478/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/39478/1//COMMIT_MSG@7 PS1, Line 7: add
Add
Done
Hello build bot (Jenkins), Wonkyu Kim, Raj Astekar, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/39478
to look at the new patch set (#4).
Change subject: drivers/intel/ish: Add TGL ISH PCI id ......................................................................
drivers/intel/ish: Add TGL ISH PCI id
BRANCH=none BUG=b:145946347 TEST=none
Signed-off-by: Hu, Hebo hebo.hu@intel.com Signed-off-by: li feng li1.feng@intel.com Change-Id: I3a4f73e82f62def3adb2cb1332a315366078c918 --- M src/drivers/intel/ish/Kconfig M src/drivers/intel/ish/ish.c M src/include/device/pci_ids.h 3 files changed, 3 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/39478/4
Hello build bot (Jenkins), Wonkyu Kim, Raj Astekar, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/39478
to look at the new patch set (#6).
Change subject: drivers/intel/ish: Add TGL ISH PCI id ......................................................................
drivers/intel/ish: Add TGL ISH PCI id
BRANCH=none BUG=b:145946347 TEST==boot to OS with TGL RVP UP3
Signed-off-by: Hu, Hebo hebo.hu@intel.com Signed-off-by: li feng li1.feng@intel.com Change-Id: I3a4f73e82f62def3adb2cb1332a315366078c918 --- M src/drivers/intel/ish/Kconfig M src/drivers/intel/ish/ish.c M src/include/device/pci_ids.h 3 files changed, 3 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/39478/6
Wonkyu Kim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39478 )
Change subject: drivers/intel/ish: Add TGL ISH PCI id ......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39478/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/39478/1//COMMIT_MSG@11 PS1, Line 11: TEST=none
Add test information
Done
Wonkyu Kim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39478 )
Change subject: drivers/intel/ish: Add TGL ISH PCI id ......................................................................
Patch Set 7: Code-Review+2
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39478 )
Change subject: drivers/intel/ish: Add TGL ISH PCI id ......................................................................
Patch Set 7: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/39478 )
Change subject: drivers/intel/ish: Add TGL ISH PCI id ......................................................................
drivers/intel/ish: Add TGL ISH PCI id
BRANCH=none BUG=b:145946347 TEST==boot to OS with TGL RVP UP3
Signed-off-by: Hu, Hebo hebo.hu@intel.com Signed-off-by: li feng li1.feng@intel.com Change-Id: I3a4f73e82f62def3adb2cb1332a315366078c918 Reviewed-on: https://review.coreboot.org/c/coreboot/+/39478 Reviewed-by: Wonkyu Kim wonkyu.kim@intel.com Reviewed-by: Patrick Georgi pgeorgi@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/drivers/intel/ish/Kconfig M src/drivers/intel/ish/ish.c M src/include/device/pci_ids.h 3 files changed, 3 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved Wonkyu Kim: Looks good to me, approved
diff --git a/src/drivers/intel/ish/Kconfig b/src/drivers/intel/ish/Kconfig index 635864e..a2828d1 100644 --- a/src/drivers/intel/ish/Kconfig +++ b/src/drivers/intel/ish/Kconfig @@ -1,5 +1,6 @@ config DRIVERS_INTEL_ISH bool + default n help When enabled, chip driver/intel/ish will publish information to the SSDT _DSD table for the ISH device. diff --git a/src/drivers/intel/ish/ish.c b/src/drivers/intel/ish/ish.c index e9d5ae96..d542bd3 100644 --- a/src/drivers/intel/ish/ish.c +++ b/src/drivers/intel/ish/ish.c @@ -65,6 +65,7 @@ static const unsigned short pci_device_ids[] = { PCI_DEVICE_ID_INTEL_CNL_ISHB, PCI_DEVICE_ID_INTEL_CML_ISHB, + PCI_DEVICE_ID_INTEL_TGL_ISHB, 0 };
diff --git a/src/include/device/pci_ids.h b/src/include/device/pci_ids.h index ccbfe40..3da326b 100644 --- a/src/include/device/pci_ids.h +++ b/src/include/device/pci_ids.h @@ -2105,6 +2105,7 @@ #define PCI_DEVICE_ID_INTEL_82439TX 0x7100 #define PCI_DEVICE_ID_INTEL_CNL_ISHB 0x9dfc #define PCI_DEVICE_ID_INTEL_CML_ISHB 0x02fc +#define PCI_DEVICE_ID_INTEL_TGL_ISHB 0xa0fc
/* Intel 82371FB (PIIX) */ #define PCI_DEVICE_ID_INTEL_82371FB_ISA 0x122e
-
Li1 Feng (Code Review) -
Patrick Georgi (Code Review)
-
Wonkyu Kim (Code Review)