Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Angel Pons, Felix Held.
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50559 )
Change subject: mb/amd/majolica: Add plain dsdt
......................................................................
Patch Set 4: Code-Review+1
(1 comment)
File src/mainboard/amd/majolica/dsdt.asl:
https://review.coreboot.org/c/coreboot/+/50559/comment/c20feeab_e347a749
PS3, Line 16: #include <soc.asl>
Right, it gets added in CB:50273. […]
Maybe follow stoney and picasso -model now and move them all at once at a later date. There's a chance we start discussing that intel side needs some TLC too and this would unnecessarily hold you back here.
There is no soc.asl under soc/intel, but there is acpi/platform.asl. I'd like to see some consistency across vendors here too, but don't want to dig into this right now.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/50559
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifd71635d3493e0cf104b60ecf94ebdf70d512b94
Gerrit-Change-Number: 50559
Gerrit-PatchSet: 4
Gerrit-Owner: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Patrick Georgi
pgeorgi@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Fri, 12 Feb 2021 20:15:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-MessageType: comment