Paul Menzel has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/41018 )
Change subject: mb/51nb/x210: Remove duplicate ACPI power button device ......................................................................
mb/51nb/x210: Remove duplicate ACPI power button device
This is copied from the Purism Librem 13v3, and is not needed, as the standard fixed power button is used. It was removed for the Pursim devices in commit 2d977b2dcb (mb/purism: remove duplicate ACPI power button).
Change-Id: I8fe19b8fbcc11d859a75b3dc6b9bcc42c80d13f1 Signed-off-by: Paul Menzel pmenzel@molgen.mpg.de --- M src/mainboard/51nb/x210/acpi/mainboard.asl 1 file changed, 0 insertions(+), 12 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/18/41018/1
diff --git a/src/mainboard/51nb/x210/acpi/mainboard.asl b/src/mainboard/51nb/x210/acpi/mainboard.asl index fb389a4..cf63b5b 100644 --- a/src/mainboard/51nb/x210/acpi/mainboard.asl +++ b/src/mainboard/51nb/x210/acpi/mainboard.asl @@ -18,18 +18,6 @@ } }
- Device (PWRB) - { - Name (_HID, EisaId ("PNP0C0C")) - - Method (_STA) - { - Return (0xF) - } - - Name (_PRW, Package () { 27, 4 }) - } - Device (SLPB) { Name (_HID, EisaId ("PNP0C0E"))
Rafael Send has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41018 )
Change subject: mb/51nb/x210: Remove duplicate ACPI power button device ......................................................................
Patch Set 2: Code-Review+1
Power button continues to work correctly across Linux & Windows with this change.
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41018 )
Change subject: mb/51nb/x210: Remove duplicate ACPI power button device ......................................................................
Patch Set 2: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/41018 )
Change subject: mb/51nb/x210: Remove duplicate ACPI power button device ......................................................................
mb/51nb/x210: Remove duplicate ACPI power button device
This is copied from the Purism Librem 13v3, and is not needed, as the standard fixed power button is used. It was removed for the Pursim devices in commit 2d977b2dcb (mb/purism: remove duplicate ACPI power button).
Change-Id: I8fe19b8fbcc11d859a75b3dc6b9bcc42c80d13f1 Signed-off-by: Paul Menzel pmenzel@molgen.mpg.de Reviewed-on: https://review.coreboot.org/c/coreboot/+/41018 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Rafael Send flyingfishfinger@gmail.com Reviewed-by: Patrick Georgi pgeorgi@google.com --- M src/mainboard/51nb/x210/acpi/mainboard.asl 1 file changed, 0 insertions(+), 12 deletions(-)
Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved Rafael Send: Looks good to me, but someone else must approve
diff --git a/src/mainboard/51nb/x210/acpi/mainboard.asl b/src/mainboard/51nb/x210/acpi/mainboard.asl index 36c7a33..c8c4f25 100644 --- a/src/mainboard/51nb/x210/acpi/mainboard.asl +++ b/src/mainboard/51nb/x210/acpi/mainboard.asl @@ -17,18 +17,6 @@ } }
- Device (PWRB) - { - Name (_HID, EisaId ("PNP0C0C")) - - Method (_STA) - { - Return (0xF) - } - - Name (_PRW, Package () { 27, 4 }) - } - Device (SLPB) { Name (_HID, EisaId ("PNP0C0E"))
9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41018 )
Change subject: mb/51nb/x210: Remove duplicate ACPI power button device ......................................................................
Patch Set 3:
Automatic boot test returned (PASS/FAIL/TOTAL): 4/0/4 Emulation targets: "QEMU x86 q35/ich9" using payload TianoCore : SUCCESS : https://lava.9esec.io/r/4980 "QEMU x86 q35/ich9" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/4979 "QEMU x86 i440fx/piix4" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/4978 "QEMU AArch64" using payload LinuxBoot_u-root_kexec : SUCCESS : https://lava.9esec.io/r/4977
Please note: This test is under development and might not be accurate at all!