Kyösti Mälkki has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/41905 )
Change subject: mb/roda/rk9: Control SMI related FADT entries ......................................................................
mb/roda/rk9: Control SMI related FADT entries
When no SMI is installed, FADT should not advertise a trigger mechanism that does respond.
Change-Id: Iefa1e7d80367dbe380f69e768238b4124a45626f Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com --- M src/mainboard/roda/rk9/fadt.c 1 file changed, 8 insertions(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/41905/1
diff --git a/src/mainboard/roda/rk9/fadt.c b/src/mainboard/roda/rk9/fadt.c index b854667..102865d 100644 --- a/src/mainboard/roda/rk9/fadt.c +++ b/src/mainboard/roda/rk9/fadt.c @@ -25,11 +25,14 @@ fadt->reserved = 0x00; fadt->preferred_pm_profile = PM_MOBILE; fadt->sci_int = 0x9; - fadt->smi_cmd = APM_CNT; - fadt->acpi_enable = APM_CNT_ACPI_ENABLE; - fadt->acpi_disable = APM_CNT_ACPI_DISABLE; - fadt->s4bios_req = 0x0; - fadt->pstate_cnt = APM_CNT_PST_CONTROL; + + if (CONFIG(HAVE_SMI_HANDLER)) { + fadt->smi_cmd = APM_CNT; + fadt->acpi_enable = APM_CNT_ACPI_ENABLE; + fadt->acpi_disable = APM_CNT_ACPI_DISABLE; + fadt->pstate_cnt = APM_CNT_PST_CONTROL; + fadt->cst_cnt = APM_CNT_CST_CONTROL; + }
fadt->pm1a_evt_blk = pmbase; fadt->pm1b_evt_blk = 0x0; @@ -48,7 +51,6 @@ fadt->gpe0_blk_len = 16; fadt->gpe1_blk_len = 0; fadt->gpe1_base = 0; - fadt->cst_cnt = APM_CNT_CST_CONTROL; fadt->p_lvl2_lat = 1; fadt->p_lvl3_lat = 0x39; fadt->flush_size = 0;
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41905 )
Change subject: mb/roda/rk9: Control SMI related FADT entries ......................................................................
Patch Set 1: Code-Review+1
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41905 )
Change subject: mb/roda/rk9: Control SMI related FADT entries ......................................................................
Patch Set 1: Code-Review+2
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41905 )
Change subject: mb/roda/rk9: Control SMI related FADT entries ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41905/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/41905/1//COMMIT_MSG@10 PS1, Line 10: does did you mean `doesn't`?
Hello build bot (Jenkins), Nico Huber, Angel Pons,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/41905
to look at the new patch set (#2).
Change subject: mb/roda/rk9: Control SMI related FADT entries ......................................................................
mb/roda/rk9: Control SMI related FADT entries
When no SMI is installed, FADT should not advertise a trigger mechanism that does not respond.
Change-Id: Iefa1e7d80367dbe380f69e768238b4124a45626f Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com --- M src/mainboard/roda/rk9/fadt.c 1 file changed, 8 insertions(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/41905/2
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41905 )
Change subject: mb/roda/rk9: Control SMI related FADT entries ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41905/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/41905/1//COMMIT_MSG@10 PS1, Line 10: does
did you mean `doesn't`?
Done
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41905 )
Change subject: mb/roda/rk9: Control SMI related FADT entries ......................................................................
Patch Set 3: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/41905 )
Change subject: mb/roda/rk9: Control SMI related FADT entries ......................................................................
mb/roda/rk9: Control SMI related FADT entries
When no SMI is installed, FADT should not advertise a trigger mechanism that does not respond.
Change-Id: Iefa1e7d80367dbe380f69e768238b4124a45626f Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/41905 Reviewed-by: Angel Pons th3fanbus@gmail.com Reviewed-by: Nico Huber nico.h@gmx.de Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/roda/rk9/fadt.c 1 file changed, 8 insertions(+), 6 deletions(-)
Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved Angel Pons: Looks good to me, approved
diff --git a/src/mainboard/roda/rk9/fadt.c b/src/mainboard/roda/rk9/fadt.c index b854667..102865d 100644 --- a/src/mainboard/roda/rk9/fadt.c +++ b/src/mainboard/roda/rk9/fadt.c @@ -25,11 +25,14 @@ fadt->reserved = 0x00; fadt->preferred_pm_profile = PM_MOBILE; fadt->sci_int = 0x9; - fadt->smi_cmd = APM_CNT; - fadt->acpi_enable = APM_CNT_ACPI_ENABLE; - fadt->acpi_disable = APM_CNT_ACPI_DISABLE; - fadt->s4bios_req = 0x0; - fadt->pstate_cnt = APM_CNT_PST_CONTROL; + + if (CONFIG(HAVE_SMI_HANDLER)) { + fadt->smi_cmd = APM_CNT; + fadt->acpi_enable = APM_CNT_ACPI_ENABLE; + fadt->acpi_disable = APM_CNT_ACPI_DISABLE; + fadt->pstate_cnt = APM_CNT_PST_CONTROL; + fadt->cst_cnt = APM_CNT_CST_CONTROL; + }
fadt->pm1a_evt_blk = pmbase; fadt->pm1b_evt_blk = 0x0; @@ -48,7 +51,6 @@ fadt->gpe0_blk_len = 16; fadt->gpe1_blk_len = 0; fadt->gpe1_base = 0; - fadt->cst_cnt = APM_CNT_CST_CONTROL; fadt->p_lvl2_lat = 1; fadt->p_lvl3_lat = 0x39; fadt->flush_size = 0;
9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41905 )
Change subject: mb/roda/rk9: Control SMI related FADT entries ......................................................................
Patch Set 4:
Automatic boot test returned (PASS/FAIL/TOTAL): 4/0/4 Emulation targets: "QEMU x86 q35/ich9" using payload TianoCore : SUCCESS : https://lava.9esec.io/r/4974 "QEMU x86 q35/ich9" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/4973 "QEMU x86 i440fx/piix4" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/4972 "QEMU AArch64" using payload LinuxBoot_u-root_kexec : SUCCESS : https://lava.9esec.io/r/4971
Please note: This test is under development and might not be accurate at all!