Kyösti Mälkki has submitted this change. ( https://review.coreboot.org/c/coreboot/+/50524 )
Change subject: src/mb: Remove unused <console/console.h> ......................................................................
src/mb: Remove unused <console/console.h>
Change-Id: I6e0f33172fbcecebddfccdf64c22685636a23936 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/50524 Reviewed-by: Werner Zeh werner.zeh@siemens.com Reviewed-by: Kyösti Mälkki kyosti.malkki@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/apple/macbook21/smihandler.c M src/mainboard/dell/optiplex_9010/smihandler.c M src/mainboard/emulation/qemu-q35/romstage.c M src/mainboard/google/auron/variants/auron_paine/spd/spd.c M src/mainboard/google/auron/variants/auron_yuna/spd/spd.c M src/mainboard/google/auron/variants/gandof/spd/spd.c M src/mainboard/google/auron/variants/lulu/spd/spd.c M src/mainboard/google/auron/variants/samus/spd/spd.c M src/mainboard/google/dedede/romstage.c M src/mainboard/google/dedede/variants/drawcia/gpio.c M src/mainboard/google/fizz/variants/endeavour/board.c M src/mainboard/google/hatch/romstage_spd_cbfs.c M src/mainboard/google/zork/smihandler.c M src/mainboard/google/zork/variants/dirinboz/variant.c M src/mainboard/google/zork/variants/gumboz/variant.c M src/mainboard/intel/dcp847ske/early_southbridge.c M src/mainboard/intel/elkhartlake_crb/romstage_fsp_params.c M src/mainboard/intel/jasperlake_rvp/romstage_fsp_params.c M src/mainboard/packardbell/ms2290/smihandler.c M src/mainboard/pcengines/apu2/romstage.c M src/mainboard/siemens/mc_apl1/variants/mc_apl1/mainboard.c M src/mainboard/siemens/mc_apl1/variants/mc_apl2/mainboard.c M src/mainboard/siemens/mc_apl1/variants/mc_apl3/mainboard.c M src/mainboard/siemens/mc_apl1/variants/mc_apl5/mainboard.c M src/mainboard/siemens/mc_apl1/variants/mc_apl6/mainboard.c 25 files changed, 1 insertion(+), 25 deletions(-)
Approvals: build bot (Jenkins): Verified Kyösti Mälkki: Looks good to me, but someone else must approve Werner Zeh: Looks good to me, approved
diff --git a/src/mainboard/apple/macbook21/smihandler.c b/src/mainboard/apple/macbook21/smihandler.c index 8219d60..b96d948 100644 --- a/src/mainboard/apple/macbook21/smihandler.c +++ b/src/mainboard/apple/macbook21/smihandler.c @@ -1,6 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */
-#include <console/console.h> #include <cpu/x86/smm.h> #include <soc/nvs.h> #include <southbridge/intel/common/pmutil.h> diff --git a/src/mainboard/dell/optiplex_9010/smihandler.c b/src/mainboard/dell/optiplex_9010/smihandler.c index 1c7d328..3ed0d11 100644 --- a/src/mainboard/dell/optiplex_9010/smihandler.c +++ b/src/mainboard/dell/optiplex_9010/smihandler.c @@ -2,7 +2,6 @@
#include <stdint.h> #include <arch/io.h> -#include <console/console.h> #include <cpu/x86/smm.h> #include <superio/smsc/sch5545/sch5545.h>
diff --git a/src/mainboard/emulation/qemu-q35/romstage.c b/src/mainboard/emulation/qemu-q35/romstage.c index c9bc339..ff06640 100644 --- a/src/mainboard/emulation/qemu-q35/romstage.c +++ b/src/mainboard/emulation/qemu-q35/romstage.c @@ -2,7 +2,6 @@
#include <arch/romstage.h> #include <cbmem.h> -#include <console/console.h> #include <southbridge/intel/i82801ix/i82801ix.h> #include <device/pci_ops.h>
diff --git a/src/mainboard/google/auron/variants/auron_paine/spd/spd.c b/src/mainboard/google/auron/variants/auron_paine/spd/spd.c index e44c42e..5527a2e 100644 --- a/src/mainboard/google/auron/variants/auron_paine/spd/spd.c +++ b/src/mainboard/google/auron/variants/auron_paine/spd/spd.c @@ -1,6 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */
-#include <console/console.h> #include <endian.h> #include <string.h> #include <southbridge/intel/lynxpoint/lp_gpio.h> diff --git a/src/mainboard/google/auron/variants/auron_yuna/spd/spd.c b/src/mainboard/google/auron/variants/auron_yuna/spd/spd.c index e44c42e..5527a2e 100644 --- a/src/mainboard/google/auron/variants/auron_yuna/spd/spd.c +++ b/src/mainboard/google/auron/variants/auron_yuna/spd/spd.c @@ -1,6 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */
-#include <console/console.h> #include <endian.h> #include <string.h> #include <southbridge/intel/lynxpoint/lp_gpio.h> diff --git a/src/mainboard/google/auron/variants/gandof/spd/spd.c b/src/mainboard/google/auron/variants/gandof/spd/spd.c index fe1aa2a..90958c8 100644 --- a/src/mainboard/google/auron/variants/gandof/spd/spd.c +++ b/src/mainboard/google/auron/variants/gandof/spd/spd.c @@ -1,6 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */
-#include <console/console.h> #include <endian.h> #include <string.h> #include <southbridge/intel/lynxpoint/lp_gpio.h> diff --git a/src/mainboard/google/auron/variants/lulu/spd/spd.c b/src/mainboard/google/auron/variants/lulu/spd/spd.c index a4cc07c..495bdaf 100644 --- a/src/mainboard/google/auron/variants/lulu/spd/spd.c +++ b/src/mainboard/google/auron/variants/lulu/spd/spd.c @@ -1,6 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */
-#include <console/console.h> #include <endian.h> #include <string.h> #include <southbridge/intel/lynxpoint/lp_gpio.h> diff --git a/src/mainboard/google/auron/variants/samus/spd/spd.c b/src/mainboard/google/auron/variants/samus/spd/spd.c index 87ecfa0..9b27db5 100644 --- a/src/mainboard/google/auron/variants/samus/spd/spd.c +++ b/src/mainboard/google/auron/variants/samus/spd/spd.c @@ -1,6 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */
-#include <console/console.h> #include <endian.h> #include <string.h> #include <southbridge/intel/lynxpoint/lp_gpio.h> diff --git a/src/mainboard/google/dedede/romstage.c b/src/mainboard/google/dedede/romstage.c index 02ebfac..f6a94ec 100644 --- a/src/mainboard/google/dedede/romstage.c +++ b/src/mainboard/google/dedede/romstage.c @@ -1,7 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-or-later */
#include <baseboard/variants.h> -#include <console/console.h> #include <ec/google/chromeec/ec.h> #include <gpio.h> #include <memory_info.h> diff --git a/src/mainboard/google/dedede/variants/drawcia/gpio.c b/src/mainboard/google/dedede/variants/drawcia/gpio.c index a91a94e..863d289 100644 --- a/src/mainboard/google/dedede/variants/drawcia/gpio.c +++ b/src/mainboard/google/dedede/variants/drawcia/gpio.c @@ -3,7 +3,6 @@ #include <baseboard/gpio.h> #include <baseboard/variants.h> #include <fw_config.h> -#include <console/console.h> #include <ec/google/chromeec/ec.h>
/* Pad configuration in ramstage*/ diff --git a/src/mainboard/google/fizz/variants/endeavour/board.c b/src/mainboard/google/fizz/variants/endeavour/board.c index 0fdc914..3da8f22 100644 --- a/src/mainboard/google/fizz/variants/endeavour/board.c +++ b/src/mainboard/google/fizz/variants/endeavour/board.c @@ -1,6 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-only */ + #include <baseboard/variants.h> -#include <console/console.h> #include <nhlt.h> #include <soc/nhlt.h>
diff --git a/src/mainboard/google/hatch/romstage_spd_cbfs.c b/src/mainboard/google/hatch/romstage_spd_cbfs.c index f3c38bb..8a12d70 100644 --- a/src/mainboard/google/hatch/romstage_spd_cbfs.c +++ b/src/mainboard/google/hatch/romstage_spd_cbfs.c @@ -1,7 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-only */
#include <baseboard/variants.h> -#include <console/console.h> #include <ec/google/chromeec/ec.h> #include <gpio.h> #include <memory_info.h> diff --git a/src/mainboard/google/zork/smihandler.c b/src/mainboard/google/zork/smihandler.c index 1c26d45..802487b 100644 --- a/src/mainboard/google/zork/smihandler.c +++ b/src/mainboard/google/zork/smihandler.c @@ -8,7 +8,6 @@ #include <soc/smi.h> #include <variant/ec.h> #include <variant/gpio.h> -#include <console/console.h>
void mainboard_smi_gpi(u32 gpi_sts) { diff --git a/src/mainboard/google/zork/variants/dirinboz/variant.c b/src/mainboard/google/zork/variants/dirinboz/variant.c index ff57f50..4dd371a 100644 --- a/src/mainboard/google/zork/variants/dirinboz/variant.c +++ b/src/mainboard/google/zork/variants/dirinboz/variant.c @@ -1,7 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-or-later */
#include <baseboard/variants.h> -#include <console/console.h> #include <device/device.h> #include <drivers/i2c/generic/chip.h> #include <soc/pci_devs.h> diff --git a/src/mainboard/google/zork/variants/gumboz/variant.c b/src/mainboard/google/zork/variants/gumboz/variant.c index ff57f50..4dd371a 100644 --- a/src/mainboard/google/zork/variants/gumboz/variant.c +++ b/src/mainboard/google/zork/variants/gumboz/variant.c @@ -1,7 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-or-later */
#include <baseboard/variants.h> -#include <console/console.h> #include <device/device.h> #include <drivers/i2c/generic/chip.h> #include <soc/pci_devs.h> diff --git a/src/mainboard/intel/dcp847ske/early_southbridge.c b/src/mainboard/intel/dcp847ske/early_southbridge.c index c18aa83..d09da01 100644 --- a/src/mainboard/intel/dcp847ske/early_southbridge.c +++ b/src/mainboard/intel/dcp847ske/early_southbridge.c @@ -3,7 +3,6 @@ #include <bootblock_common.h> #include <stdint.h> #include <cf9_reset.h> -#include <console/console.h> #include <northbridge/intel/sandybridge/raminit_native.h> #include <southbridge/intel/bd82x6x/pch.h>
diff --git a/src/mainboard/intel/elkhartlake_crb/romstage_fsp_params.c b/src/mainboard/intel/elkhartlake_crb/romstage_fsp_params.c index 3240834..809ea1f 100644 --- a/src/mainboard/intel/elkhartlake_crb/romstage_fsp_params.c +++ b/src/mainboard/intel/elkhartlake_crb/romstage_fsp_params.c @@ -1,7 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-only */
#include <baseboard/variants.h> -#include <console/console.h> #include <soc/meminit.h> #include <soc/romstage.h>
diff --git a/src/mainboard/intel/jasperlake_rvp/romstage_fsp_params.c b/src/mainboard/intel/jasperlake_rvp/romstage_fsp_params.c index 6516131..467dbc6 100644 --- a/src/mainboard/intel/jasperlake_rvp/romstage_fsp_params.c +++ b/src/mainboard/intel/jasperlake_rvp/romstage_fsp_params.c @@ -1,7 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-only */
#include <baseboard/variants.h> -#include <console/console.h> #include <soc/meminit.h> #include <soc/romstage.h> #include "board_id.h" diff --git a/src/mainboard/packardbell/ms2290/smihandler.c b/src/mainboard/packardbell/ms2290/smihandler.c index 0f2ca42..0dc575c 100644 --- a/src/mainboard/packardbell/ms2290/smihandler.c +++ b/src/mainboard/packardbell/ms2290/smihandler.c @@ -1,6 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */
-#include <console/console.h> #include <cpu/x86/smm.h> #include <device/pci_ops.h> #include <southbridge/intel/common/pmutil.h> diff --git a/src/mainboard/pcengines/apu2/romstage.c b/src/mainboard/pcengines/apu2/romstage.c index e0a63f0..09a0309 100644 --- a/src/mainboard/pcengines/apu2/romstage.c +++ b/src/mainboard/pcengines/apu2/romstage.c @@ -2,7 +2,6 @@
#include <stdint.h> #include <amdblocks/acpimmio.h> -#include <console/console.h> #include <device/pci_def.h> #include <device/pci_ops.h> #include <gpio.h> diff --git a/src/mainboard/siemens/mc_apl1/variants/mc_apl1/mainboard.c b/src/mainboard/siemens/mc_apl1/variants/mc_apl1/mainboard.c index 5dbc4b9..769c9f0 100644 --- a/src/mainboard/siemens/mc_apl1/variants/mc_apl1/mainboard.c +++ b/src/mainboard/siemens/mc_apl1/variants/mc_apl1/mainboard.c @@ -1,7 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-only */
#include <bootstate.h> -#include <console/console.h> #include <device/pci_ids.h> #include <device/pci_ops.h> #include <gpio.h> diff --git a/src/mainboard/siemens/mc_apl1/variants/mc_apl2/mainboard.c b/src/mainboard/siemens/mc_apl1/variants/mc_apl2/mainboard.c index 9cfd86f..e8cc2e6 100644 --- a/src/mainboard/siemens/mc_apl1/variants/mc_apl2/mainboard.c +++ b/src/mainboard/siemens/mc_apl1/variants/mc_apl2/mainboard.c @@ -1,7 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-only */
#include <bootstate.h> -#include <console/console.h> #include <device/pci_def.h> #include <device/pci_ids.h> #include <device/pci_ops.h> diff --git a/src/mainboard/siemens/mc_apl1/variants/mc_apl3/mainboard.c b/src/mainboard/siemens/mc_apl1/variants/mc_apl3/mainboard.c index 22d2388..842f377 100644 --- a/src/mainboard/siemens/mc_apl1/variants/mc_apl3/mainboard.c +++ b/src/mainboard/siemens/mc_apl1/variants/mc_apl3/mainboard.c @@ -3,7 +3,6 @@ #include <arch/io.h> #include <bootstate.h> #include <cf9_reset.h> -#include <console/console.h> #include <device/pci_def.h> #include <device/pci_ids.h> #include <device/pci_ops.h> diff --git a/src/mainboard/siemens/mc_apl1/variants/mc_apl5/mainboard.c b/src/mainboard/siemens/mc_apl1/variants/mc_apl5/mainboard.c index 5a4c01f..7554fee 100644 --- a/src/mainboard/siemens/mc_apl1/variants/mc_apl5/mainboard.c +++ b/src/mainboard/siemens/mc_apl1/variants/mc_apl5/mainboard.c @@ -1,7 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-only */
#include <bootstate.h> -#include <console/console.h> #include <device/pci_def.h> #include <device/pci_ids.h> #include <device/pci_ops.h> diff --git a/src/mainboard/siemens/mc_apl1/variants/mc_apl6/mainboard.c b/src/mainboard/siemens/mc_apl1/variants/mc_apl6/mainboard.c index 15c170b..1cecef7 100644 --- a/src/mainboard/siemens/mc_apl1/variants/mc_apl6/mainboard.c +++ b/src/mainboard/siemens/mc_apl1/variants/mc_apl6/mainboard.c @@ -3,7 +3,6 @@ #include <arch/io.h> #include <bootstate.h> #include <cf9_reset.h> -#include <console/console.h> #include <device/pci_def.h> #include <device/pci_ids.h> #include <device/pci_ops.h>